Ah, good point. I assumed that the report was valid because they aren't showing up in the doxygen: http://llvm.org/docs/doxygen/html/classllvm_1_1StringRef.html
I'll go ahead and revert. On Wed, Feb 24, 2016 at 2:06 PM, Benjamin Kramer <benny....@gmail.com> wrote: > Were you able to reproduce this build failure? ltrim has overloads for > "char" and "StringRef", the former being very new. From the error > message I suspect out of sync LLVM and Clang checkouts. > > On Wed, Feb 24, 2016 at 10:55 PM, David Majnemer via cfe-commits > <cfe-commits@lists.llvm.org> wrote: > > Author: majnemer > > Date: Wed Feb 24 15:55:58 2016 > > New Revision: 261780 > > > > URL: http://llvm.org/viewvc/llvm-project?rev=261780&view=rev > > Log: > > Don't convert a char to a const char * > > > > This fixes PR26728. > > > > Modified: > > cfe/trunk/lib/Lex/PPDirectives.cpp > > > > Modified: cfe/trunk/lib/Lex/PPDirectives.cpp > > URL: > http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Lex/PPDirectives.cpp?rev=261780&r1=261779&r2=261780&view=diff > > > ============================================================================== > > --- cfe/trunk/lib/Lex/PPDirectives.cpp (original) > > +++ cfe/trunk/lib/Lex/PPDirectives.cpp Wed Feb 24 15:55:58 2016 > > @@ -1226,7 +1226,7 @@ void Preprocessor::HandleUserDiagnosticD > > > > // Find the first non-whitespace character, so that we can make the > > // diagnostic more succinct. > > - StringRef Msg = StringRef(Message).ltrim(' '); > > + StringRef Msg = StringRef(Message).ltrim(" "); > > > > if (isWarning) > > Diag(Tok, diag::pp_hash_warning) << Msg; > > > > > > _______________________________________________ > > cfe-commits mailing list > > cfe-commits@lists.llvm.org > > http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits >
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
