[Differential] [Requested Changes To] D362: Modularity++: Move find_package() to places where they belong, make other optional

kossebau requested changes to this revision. kossebau added a comment. This revision now requires changes to proceed. Hm, moving checking for required packages into the subdirs and thus after calculating which products can be built or, if internal dep, should be built breaks the concept of the c

[Differential] [Updated] D360: KoFileDialog rather belongs to kowidgetutils than kowidgetsThis way apps can use the class without larger deps of kowidgets

kossebau added a comment. Issue in any case: this patch misses to also move the test app, filedialogtester. Then I wonder if we could first come up with a definition what the purpose of kowidgets and kowidgetutils is. And if perhaps we should split them up some more or reshuffle together with

[Differential] [Request, 173 lines] D364: Move KoFindToolbar to Words, it's only user

kossebau created this revision. kossebau added reviewers: boemann, deniskuplyakov. kossebau added a subscriber: Calligra-Devel-list. REVISION SUMMARY Nothing shares this widget. Can be still moved to a shared lib again, once another app wants to use exaxtly the same widget. REPOSITORY rCALL

[Differential] [Accepted] D360: KoFileDialog rather belongs to kowidgetutils than kowidgetsThis way apps can use the class without larger deps of kowidgets

kossebau accepted this revision. kossebau added a comment. This revision is now accepted and ready to land. Agree on removal of i18n, not really needed IMHO, let's have translators only spend time on enduser facing strings :) While moving filedialogtester, could you please move it into the subdir

[Differential] [Commented On] D360: KoFileDialog rather belongs to kowidgetutils than kowidgetsThis way apps can use the class without larger deps of kowidgets

kossebau added a comment. Not sure I would have moved the main.cpp into the other file, but there is no policy in Calligra about such utils apps, so if you prefer it like that, keep it as you did now. (I prefer having entry points in a separate file, even do main.cpp files for plugins, but I kn

[Maniphest] [Commented On] T665: Show default (empty) document on startup in document-based Calligra apps

kossebau added a subscriber: kossebau. kossebau added a comment. Would it be a good idea to have UI/UX experts look at this as well? Because I personally prefer the current UI if I just start the application binary itself, without any parameters. So if we agree on changing the default start UI,

[Maniphest] [Commented On] T665: Show default (empty) document on startup in document-based Calligra apps

kossebau added a comment. Unless I have seen and read the reports of the UI designers of MS, LO & Co. and their reasoning for why it is like this, it seem just blind copying of their UI, which does not make sense to me and my needs. And otherwise I also would not need to work on Calligra, if LO

[Differential] [Request, 8 lines] D2058: Make TestXmlReader/TestXmlReaderWithoutSpaces handle translated error messages

kossebau created this revision. kossebau added a reviewer: Calligra-Devel-list. Restricted Application added projects: Kexi, Calligra: 3.0. REVISION SUMMARY Linking KI18n results in Qt translations being loaded on start. And QXmlStreamReader, used internally by KoXmlDocument, returns translate

[Differential] [Closed] D2058: Make TestXmlReader/TestXmlReaderWithoutSpaces handle translated error messages

This revision was automatically updated to reflect the committed changes. Closed by commit rCALLIGRA9f1ebd6d901a: Make TestXmlReader/TestXmlReaderWithoutSpaces handle translated error messages (authored by kossebau). REPOSITORY rCALLIGRA Calligra CHANGES SINCE LAST UPDATE https://phabricato

[Differential] [Accepted] D2702: flake: Include rather than

kossebau accepted this revision. kossebau added a reviewer: kossebau. kossebau added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > KoSnapStrategy.cpp:34 > > #if defined(_MSC_VER) && (_MSC_VER < 1800) > #define isfinite(x) (double)(x) Please also remove t

[Maniphest] [Commented On] T3755: Kexi API docs missing in the calligra section

kossebau added a comment. For one, Kexi is currently covered by api.kde.org, just not explicitely listed on https://api.kde.org/other.php (similar to krita). @ochurlaud Do you have access to that page and could add Kexi & Krita there? Kexi: https://api.kde.org/bundled-apps-api/kexi-api

[Maniphest] [Commented On] T3755: Kexi API docs missing in the calligra section

kossebau added a comment. In https://phabricator.kde.org/T3755#55355, @staniek wrote: > > there is not much content right now on the kexi pages > > Right if you mean 'special pages' with prose. But there's plenty of doxygen API docs in the context of classes and functions. Over 4000 l

[Maniphest] [Commented On] T3755: Kexi API docs missing in the calligra section

kossebau added a comment. In https://phabricator.kde.org/T3755#55412, @staniek wrote: > Are we sure? > > For example KDevelop has kdevplatform https://api.kde.org/extragear-api/kdevelop-apidocs/index.html, just released yesterday, but Calligra does not: > > https://api.kde.org/bu

[Differential] [Closed] D364: Move KoFindToolbar to Words, it's only user

This revision was automatically updated to reflect the committed changes. Closed by commit rCALLIGRAd628f85b24b3: Move KoFindToolbar to Words, it's only user (authored by kossebau). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D364?vs=895&id=6836#toc REPOSITORY rCALLIGRA Calligra CHA

[Differential] [Request, 52 lines] D128: Restore loading of defaultstyles.xml

kossebau created this revision. kossebau added a subscriber: Calligra-Devel-list. REVISION SUMMARY Fetching the resource dirs for "styles" from the main componentdata failed, as the resource dirs were registered by the factories with componentdata instances which never become main componen

[Differential] [Commented On] D128: Restore loading of defaultstyles.xml

kossebau added a comment. Here a more detailed description of the problem: `KoOdfLoadingContext::KoOdfLoadingContext(...)` uses the passed componentData to get path of `defaultstyles.xml`, by `KStandardDirs::locate( "styles", "defaultstyles.xml", componentData )` In all 3 known usages where `Ko

[Differential] [Updated, 51 lines] D128: Restore loading of defaultstyles.xml

kossebau updated this revision to Diff 283. kossebau added a comment. Remove unneeded KoPart.h include REPOSITORY rCALLIGRA Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D128?vs=282&id=283 BRANCH fixFindingDefaultStylesXml REVISION DETAIL https://phabricator.kde.org/D

[Differential] [Closed] D128: Restore loading of defaultstyles.xml

kossebau closed this revision. REPOSITORY rCALLIGRA Calligra REVISION DETAIL https://phabricator.kde.org/D128 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kossebau, yue, boemann Cc: boemann, yue, zachmann, Calligra-Devel-list _

[Differential] [Changed Subscribers] D126: Modernize version macros for the 3.0 series: use 2.99.89 for the 3.0.0 Pre-Alpha

kossebau added a subscriber: kossebau. INLINE COMMENTS CMakeLists.txt:44 for //Pre-Alpha and// Alpha, to be consistent with text for CALLIGRA_ALPHA CMakeLists.txt:59 While touching this, could you please add a short comment about the magic value 15? That it is the offset needed currently rel

[Differential] [Commented On] D126: Modernize version macros for the 3.0 series: use 2.99.89 for the 3.0.0 Pre-Alpha

kossebau added a comment. Minor issues found :) In general makes sense to me and perhaps matches better our mental model of the different values and vars (if one gets the STABLE name property :) ). So no objections from my side. INLINE COMMENTS libs/version/calligraversion.h.cmake:88 Perfect

[Differential] [Request, 391 lines] D154: Sanitize memory management of KoXmlNodeData a little

kossebau created this revision. kossebau added a subscriber: Calligra-Devel-list. REVISION SUMMARY 1. Cleanup sharing of KoXmlNodeData objects Many null DOM element types (as created by default constructor) did not get the KoXmlNodeData::null instance to share, but a new separate instance,

[Differential] [Updated, 381 lines] D154: Sanitize memory management of KoXmlNodeData a little

kossebau updated this revision to Diff 333. kossebau added a comment. Cleared patch from all small fixups for better readibility REPOSITORY rCALLIGRA Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D154?vs=332&id=333 BRANCH properKoXmlNodeData REVISION DETAIL https://ph

[Differential] [Updated] D154: Sanitize memory management of KoXmlNodeData a little

kossebau updated the summary for this revision. REPOSITORY rCALLIGRA Calligra REVISION DETAIL https://phabricator.kde.org/D154 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kossebau Cc: Calligra-Devel-list __

[Differential] [Updated, 293 lines] D154: Sanitize memory management of KoXmlNodeData a little

kossebau updated this revision to Diff 334. kossebau added a comment. Remove the change to const node data for now REPOSITORY rCALLIGRA Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D154?vs=333&id=334 BRANCH properKoXmlNodeData REVISION DETAIL https://phabricator.kde.

[Differential] [Updated] D154: Sanitize memory management of KoXmlNodeData a little

kossebau updated the summary for this revision. REPOSITORY rCALLIGRA Calligra REVISION DETAIL https://phabricator.kde.org/D154 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kossebau Cc: Calligra-Devel-list __

[Differential] [Commented On] D154: Sanitize memory management of KoXmlNodeData a little

kossebau added a comment. Guess I will have a hard time finding someone to review this more complex code, given the original author(s) are no longer here and anyone else has no time left? Given I feel quite good with the changes, any loading still works, and could not find any crash or failed t

[Differential] [Closed] D154: Sanitize memory management of KoXmlNodeData a little

This revision was automatically updated to reflect the committed changes. Closed by commit rCALLIGRA1d3684be07a1: Sanitize memory management of KoXmlNodeData a little (authored by kossebau). REPOSITORY rCALLIGRA Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D154?vs=334&id=44

[Differential] [Commented On] D183: Add library export definitions

kossebau added a comment. In https://phabricator.kde.org/D183#4272, @abrahams wrote: > Things are not as simple as renaming krita_export.h to kritaimage_export.h. > The former was actually a collection of different symbol definitions. The > intermediate change you're proposing would mean you

[Differential] [Commented On] D183: Add library export definitions

kossebau added a comment. In https://phabricator.kde.org/D183#4274, @staniek wrote: > In 3.x there shouldn't exist any *_export.h files if you ask me. Yes, multiple persons already changed a few files to be generated, so that seems an agreed goal :) The initial patch just was only about a sing

[Differential] [Commented On] D183: Add library export definitions

kossebau added a comment. In https://phabricator.kde.org/D183#4278, @abrahams wrote: > OK, I understand now. The problem with doing it personally is that > maintaining separate 2.9 and 3.0 builds on Windows is a huge challenge, and > since installing Windows 10 I have not bothered with 2.9 an

[Differential] [Request, 596 lines] D269: Replace KoToolButton with KoToolAction

kossebau created this revision. kossebau added reviewers: rempt, boemann. kossebau added a subscriber: Calligra-Devel-list. REVISION SUMMARY * change KoToolBox to use own buttons, made from new KoToolBoxButton which wires up to the KoToolAction * change KoModeBox to directly use KoToolActi

[Differential] [Closed] D269: Replace KoToolButton with KoToolAction

This revision was automatically updated to reflect the committed changes. Closed by commit rCALLIGRAda0778264cb5: Replace KoToolButton with KoToolAction (authored by kossebau). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D269?vs=604&id=618#toc REPOSITORY rCALLIGRA Calligra CHANGES S

[Differential] [Accepted] D183: Add library export definitions

kossebau accepted this revision. kossebau added a comment. This revision is now accepted and ready to land. Yes, looks fine to me as well, please commit. INLINE COMMENTS libs/widgets/KoTriangleColorSelector.h:25 Any chance to get easily rid of this? If not, okay to leave in, will be cleaned u