kossebau created this revision. kossebau added a reviewer: Calligra-Devel-list. Restricted Application added projects: Kexi, Calligra: 3.0.
REVISION SUMMARY Linking KI18n results in Qt translations being loaded on start. And QXmlStreamReader, used internally by KoXmlDocument, returns translated error messages. So running in a non-en locale still testing the english strings will fail. Checking undocumented error strings is fragile already, so relying on a certain translation context does not make things a lot worse. TEST PLAN Tests no longer fail with Qt translations installed and running in a non-en locale. REPOSITORY rCALLIGRA Calligra BRANCH fixTestXmlReaderTestingTranslatedErrorMessages REVISION DETAIL https://phabricator.kde.org/D2058 AFFECTED FILES libs/odf/tests/TestXmlReader.cpp libs/odf/tests/TestXmlReaderWithoutSpaces.cpp EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kossebau, Calligra-Devel-list Cc: staniek
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
