kossebau accepted this revision. kossebau added a comment. This revision is now accepted and ready to land.
Agree on removal of i18n, not really needed IMHO, let's have translators only spend time on enduser facing strings :) While moving filedialogtester, could you please move it into the subdir tests/, so the normal dir only contains product code? As you just moved the KoFileDialog class files (and updated used export macro), I have not really looked into the code, only the CMakeLists.txt changes. Also not tested, assuming things work as before as kowidgetutils is a public dep of kowidgets :) With filedialogtester moved down to subdir tests/, seems fine to me and good to ship. REVISION DETAIL https://phabricator.kde.org/D360 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: staniek, rempt, kossebau Cc: Calligra-Devel-list _______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
