Being a real fan of the "Bande désinée" and an admirer of Moebius' art, I
wholeheartedly support this.
PierreSt
On Tue, Mar 13, 2012 at 11:30 AM, Boudewijn Rempt wrote:
> Hi,
>
> I would like to add the attached patch to the 2.4 release. It dedicates
> this release of Krita to the memory of Je
done here is to
replace the whole preview with a thumbnail created by the KoStyleThumbnailer
(in the textlayout lib).
That way, the preview is really using the same layout/drawing stuff as the
shapes. Now it is all done specific to this preview.
- Pierre Stirnweiss
On March 26, 2012, 6:52 a.m
I am not now in a position to do a proper review for the moment. However a
couple of questions:
- what is it you are trying to do with these "other" paragraph styles?
- why inserting them is not done through the kotext's styleManager like the
"standard" paragraph styles and directly into the model
But is this to be used only in the styleManager dialog then? What for, the
preview?
On Wed, May 23, 2012 at 2:52 PM, C. Boemann wrote:
> On Wednesday 23 May 2012 14:42:52 Pierre Stirnweiss wrote:
> > I am not now in a position to do a proper review for the moment. However
> a
&
less generic name
and friend the appropriate classes?
On Wed, May 23, 2012 at 3:28 PM, C. Boemann wrote:
> On Wednesday 23 May 2012 15:25:26 Pierre Stirnweiss wrote:
> > But is this to be used only in the styleManager dialog then? What for,
> the
> > preview?
> Yes for the
Something like AddUnvalidatedStyle or AddDraftStyle. I'll post some more if
I think of anything else
On Wed, May 23, 2012 at 3:46 PM, C. Boemann wrote:
> On Wednesday 23 May 2012 15:41:43 Pierre Stirnweiss wrote:
> > And since this list uses the styleModel, I see the use case now
On Mon, Jun 4, 2012 at 2:30 PM, C. Boemann wrote:
> On Monday 04 June 2012 14:21:07 Friedrich W. H. Kossebau wrote:
> > Hi,
> >
> > a problem with the otherwise great text style previews in the style
> > selectors is that they fail if the color of the style is the same as the
> > background in th
ttp://git.reviewboard.kde.org/r/105463/#comment12140>
Won't this create a round-trip problem?
The loaded file haven't got a date. On saving it will have currentDate, or
have I missed something?
- Pierre Stirnweiss
On July 7, 2012, 10:16 a.m., Friedrich W. H
> On July 7, 2012, 4:50 p.m., Pierre Stirnweiss wrote:
> > plugins/variables/DateVariable.cpp, line 126
> > <http://git.reviewboard.kde.org/r/105463/diff/3/?file=71690#file71690line126>
> >
> > Won't this create a round-trip problem?
> > The
Time to involve the whole devel list I think:
Here is roughly where we stand in a discussion (between Inge and me, with
some public) about distraction free mode.
I think it is becoming concrete enough and will be of interest for others
in the ML.
Pierre
On Fri, Sep 7, 2012 at 10:16 AM, Inge Wal
> >
> > There is perhaps a way, that i started to explore for change tracking
> > without much success (but i didn't pursue this very long). It seems
> > possible to specify additional formatting at layout stage (QTextLayout
> > class I think). I don't know how usable this is. Camilla should know m
On Thu, Oct 25, 2012 at 9:39 AM, Inge Wallin wrote:
>This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106983/
>
> Ship it!
>
> Looks good now.
>
> Only thing was that copyright notice is still missing in some files and some
> files still have cod
glitches in handling styles, but these are also
present in the current build.
Thanks,
Pierre Stirnweiss
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel
/#review22533
-------
On Nov. 24, 2012, 2:36 p.m., Pierre Stirnweiss wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde
---
Playing around with it did not show regressions with current state of the
affair. There are a couple of glitches in handling styles, but these are also
present in the current build.
Thanks,
Pierre Stirnweiss
___
calligra-devel mailing list
calligra
--
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107445/#review22611
---
On Nov. 26, 2012, 9:27 p.m., Pierre Stirnweiss wrote:
>
> --
---
Playing around with it did not show regressions with current state of the
affair. There are a couple of glitches in handling styles, but these are also
present in the current build.
Thanks,
Pierre Stirnweiss
___
calligra-devel mailing list
calligra
the
affair. There are a couple of glitches in handling styles, but these are also
present in the current build.
Thanks,
Pierre Stirnweiss
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel
<http://git.reviewboard.kde.org/r/107486/#comment17365>
What is the difference between ActiveAuthorInfo and AuthorInfo? Perhaps a
tad more verbose description.
- Pierre Stirnweiss
On Nov. 27, 2012, 12:14 p.m., C. Boemann
to work, and I have not spotted regressions.
Thanks,
Pierre Stirnweiss
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel
Diff: http://git.reviewboard.kde.org/r/107616/diff/
Testing
---
Thanks,
Pierre Stirnweiss
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel
On Wed, Dec 19, 2012 at 10:03 AM, Boudewijn Rempt wrote:
> **
>
> On Wednesday 19 December 2012 Dec, C. Boemann wrote:
>
> > Hi
>
> >
>
> > In an attempt to to rework the ui, we have run into a problem:
>
> >
>
> > KoCreatePathTool in libs/flake needs some widgets from libs/widgets
>
> >
>
> > ho
On Wed, Dec 19, 2012 at 1:19 PM, C. Boemann wrote:
> On Wednesday 19 December 2012 13:11:51 Jaroslaw Staniek wrote:
> > On 19 December 2012 12:59, C. Boemann wrote:
> > > Yes i'm not attached to alpine in any way. I couldn't come up with a
> > > generic name that describes the library very well
http://git.reviewboard.kde.org/r/107849/diff/
Testing
---
Now it works for me ;)
Thanks,
Pierre Stirnweiss
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel
cursor does not have a selection, the character style was not applied.
Ok to backport?
Diffs
-
libs/kotext/KoTextEditor_format.cpp d1f0694
Diff: http://git.reviewboard.kde.org/r/107878/diff/
Testing
---
Thanks,
Pierre Stirnweiss
natural order now. I could not test regressions where
locale comparison would play a role however. But since KStringHandler's
comparison uses the Qt one, I don't expect a regression there.
Thanks,
Pierre Stirnweiss
___
calligra-devel mailing lis
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108022/#review24325
---
Ship it!
Ship It!
- Pierre Stirnweiss
On Dec. 31, 2012, 12
ext/styles/KoStyleManager.cpp 480fa19
plugins/textshape/dialogs/StylesModel.cpp 0e33084
Diff: http://git.reviewboard.kde.org/r/108051/diff/
Testing
---
Thanks,
Pierre Stirnweiss
___
calligra-devel mailing list
calligra-devel@kde.org
https://ma
/
Testing
---
Played around with the combo. Also fixed some issues spotted by Boemann earlier.
Thanks,
Pierre Stirnweiss
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel
(if we set
one).
Ok to backport?
Diffs
-
libs/kotext/KoTextEditor_format.cpp 7bd345b
Diff: http://git.reviewboard.kde.org/r/108191/diff/
Testing
---
Thanks,
Pierre Stirnweiss
___
calligra-devel mailing list
calligra-deve
and eventually the character style (if we set
one).
Ok to backport?
Diffs
-
libs/kotext/KoTextEditor_format.cpp 7bd345b
Diff: http://git.reviewboard.kde.org/r/108191/diff/
Testing
---
Thanks,
Pierre Stirnweiss
___
calligra-dev
://git.reviewboard.kde.org/r/108199/diff/
Testing
---
Thanks,
Pierre Stirnweiss
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel
---
Thanks,
Pierre Stirnweiss
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel
a style to the caret was not effective when the caret had no selection.
This change correct that bug.
Ok to backport?
Diffs
-
libs/kotext/KoTextEditor_format.cpp 5a35fe8
Diff: http://git.reviewboard.kde.org/r/108379/diff/
Testing
---
Thanks,
Pierre Stirnweiss
---
Thanks,
Pierre Stirnweiss
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel
not apply cleanly for me
> against 2.6 at least.
>
>
> - Friedrich W. H.
>
> On January 16th, 2013, 8:45 p.m. UTC, Pierre Stirnweiss wrote:
> Review request for Calligra and Friedrich W. H. Kossebau.
> By Pierre Stirnweiss.
>
> *Updated Jan. 16, 2013, 8:45 p.m.*
plugins/textshape/dialogs/StylesModel.cpp 80ea48d
Diff: http://git.reviewboard.kde.org/r/108444/diff/
Testing
---
Thanks,
Pierre Stirnweiss
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel
plugins/textshape/dialogs/DockerStylesComboModel.cpp 472f8b4
plugins/textshape/dialogs/StylesModel.cpp a264855
Diff: http://git.reviewboard.kde.org/r/108532/diff/
Testing
---
Thanks,
Pierre Stirnweiss
___
calligra-devel mailing list
calligra
On Wed, Jan 23, 2013 at 8:07 PM, C. Boemann wrote:
> On Wednesday 23 January 2013 18:25:59 Inge Wallin wrote:
> > On Wednesday, January 23, 2013 12:05:43 C. Boemann wrote:
> > > Hi
> > >
> > > I'm worried about our release pace. For 2.6 Words was able to make
> > > exactly 0 new features. Sure we
On Fri, Jan 25, 2013 at 6:16 PM, Yuë Liu wrote:
> We talked about having a testing branch before commit into master
> branch last year. We can restrict commit right to master, let the
> features committed to and tested in testing branch thoroughly. So
> master will always keep stable.
>
>
I don't
ed long paragraphStyleId = (paragraphStyle) ?
> reinterpret_cast(paragraphStyle) : 0L;
>
> paragraphStyleId seems a misnomer now
>
>
> - C.
>
> On March 25th, 2013, 5:28 a.m. UTC, Thorsten Zachmann wrote:
> Review request for Calligra and Pierre Stirnweiss.
> By Thorsten Zachmann.
&g
Hello Elvis,
I am unfortunately kept away from coding by non hobby stuff at the moment.
I have been working for quite a while on a new style manager. The current
style manager is a mix of several partial rewrites on top of each other. I
have started from scratch completely, using a QAbstractModel
101 - 142 of 142 matches
Mail list logo
