On Fri, Dec 23, 2011 at 12:32 PM, Inge Wallin wrote:
> On Thursday, December 22, 2011 20:18:48 Cyrille Berger Skott wrote:
> > On Thursday 22 December 2011, Inge Wallin wrote:
> > > On Thursday, December 22, 2011 17:47:54 Cyrille Berger Skott wrote:
> > > > You can make all the fun you want of Li
Indeed, the change tracking system needs to know about it. And secondly, if
you remove a character from the QTextDocument, Qt will create an undo/redo
command internally. If you do not have a corresponding command on your
application undoStack, you'll be out of sync with QTextDocument internal
und
You either call KoTextEditor->beginEditBlock before doing all the
operations (ie, before deleting the shape and the anchor), and call
textEditor->endEditBlock(),
or alternatively you create a KUndo2Command and call
KoTextEditor->addCommand(yourCommand). I think the second method is better
as it all
t these are actually outside the scope of this widget
and affecting the current widget also.
Thanks,
Pierre Stirnweiss
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel
If not, there is a discrepancy between what the styles apply on a
format and what the style returns as a value:
If I have:
QTextCharFormat format;
style->applyStyle(format);
Then format.property(some hard coded property) returns a value, but
style.value(that same property) is undefined. I don&#x
current widget also.
Thanks,
Pierre Stirnweiss
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel
ill have to do
Have we?, I don't remember if we have.
- Pierre
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103677/#review9761
---
ted at startup), but these are actually outside the scope of this widget
and affecting the current widget also.
Thanks,
Pierre Stirnweiss
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel
> On Jan. 12, 2012, 8:01 a.m., Thorsten Zachmann wrote:
> > plugins/textshape/TextTool.cpp, lines 1803-1810
> > <http://git.reviewboard.kde.org/r/103677/diff/1/?file=46464#file46464line1803>
> >
> > How about intializing charStyle with style?
>
> Pie
sively linked to the comboBox seems to be working
properly. Some defects have been identified (like no paragraph style is
selected at startup), but these are actually outside the scope of this widget
and affecting the current widget also.
Thanks
ape/dialogs/SimpleParagraphWidget.ui, line 121
> > <http://git.reviewboard.kde.org/r/103677/diff/4/?file=46803#file46803line121>
> >
> > please dont remove the special button
> > it's very needed
Idem.
- Pierre
--
> On Jan. 15, 2012, 8:17 p.m., C. Boemann wrote:
> > plugins/textshape/dialogs/SimpleCharacterWidget.cpp, line 131
> > <http://git.reviewboard.kde.org/r/103677/diff/4/?file=46799#file46799line131>
> >
> > = block.charformat
> >
>
> Pierre Stir
t it in the
StylesCombo).
About the merging, what would 3 commits bring? I actually doubt we would be
able to cut this branch in 2-3 self contained (ie compilable and runnable)
commits without quite a tiresome "git add --interactive" exercise. Everything
is intertwined. I have made sure
Oh, you've merged the branch already? Arf, I was looking forward doing this
myself, sort of a good conclusion to a long time spent. Well,...
I've seen also that you changed the textTool to use a blank character style
as a base of the newly created style (if there isn't a base character
style). Isn
: Segmentation fault
[KCrash Handler]
#6 0xb1a18714 in MapShape::marbleWidget (this=0x0) at
/home/pierre/Hacking/source/calligra_new/plugins/mapshape/MapShape.cpp:202
#7 0xb1a1957e in MapTool::createOptionWidget (this=0x8634698) at
/home/pierre/Hacking/source/calligra_new/plugins/mapshape
When I checked out the branch yesterday evening, the
KoTextEditor_format.cpp file was missing. This also meant that I couldn't
test the trick for the insertTable method. It wouldn't compile.
Pierre
On Thu, Feb 23, 2012 at 10:27 AM, C. Boemann wrote:
> Hi all
>
> So the mi
Being a real fan of the "Bande désinée" and an admirer of Moebius' art, I
wholeheartedly support this.
PierreSt
On Tue, Mar 13, 2012 at 11:30 AM, Boudewijn Rempt wrote:
> Hi,
>
> I would like to add the attached patch to the 2.4 release. It dedicates
> this release of Krita to the memory of Je
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104405/#review11845
---
Ship it!
Ship It!
- Pierre Ducroquet
On March 25, 2012, 5
done here is to
replace the whole preview with a thumbnail created by the KoStyleThumbnailer
(in the textlayout lib).
That way, the preview is really using the same layout/drawing stuff as the
shapes. Now it is all done specific to this preview.
- Pierre Stirnweiss
On March 26, 2012, 6:52 a.m
I am not now in a position to do a proper review for the moment. However a
couple of questions:
- what is it you are trying to do with these "other" paragraph styles?
- why inserting them is not done through the kotext's styleManager like the
"standard" paragraph styles and directly into the model
But is this to be used only in the styleManager dialog then? What for, the
preview?
On Wed, May 23, 2012 at 2:52 PM, C. Boemann wrote:
> On Wednesday 23 May 2012 14:42:52 Pierre Stirnweiss wrote:
> > I am not now in a position to do a proper review for the moment. However
> a
&
less generic name
and friend the appropriate classes?
On Wed, May 23, 2012 at 3:28 PM, C. Boemann wrote:
> On Wednesday 23 May 2012 15:25:26 Pierre Stirnweiss wrote:
> > But is this to be used only in the styleManager dialog then? What for,
> the
> > preview?
> Yes for the
Something like AddUnvalidatedStyle or AddDraftStyle. I'll post some more if
I think of anything else
On Wed, May 23, 2012 at 3:46 PM, C. Boemann wrote:
> On Wednesday 23 May 2012 15:41:43 Pierre Stirnweiss wrote:
> > And since this list uses the styleModel, I see the use case now
On Mon, Jun 4, 2012 at 2:30 PM, C. Boemann wrote:
> On Monday 04 June 2012 14:21:07 Friedrich W. H. Kossebau wrote:
> > Hi,
> >
> > a problem with the otherwise great text style previews in the style
> > selectors is that they fail if the color of the style is the same as the
> > background in th
ttp://git.reviewboard.kde.org/r/105463/#comment12140>
Won't this create a round-trip problem?
The loaded file haven't got a date. On saving it will have currentDate, or
have I missed something?
- Pierre Stirnweiss
On July 7, 2012, 10:16 a.m., Friedrich W. H
> On July 7, 2012, 4:50 p.m., Pierre Stirnweiss wrote:
> > plugins/variables/DateVariable.cpp, line 126
> > <http://git.reviewboard.kde.org/r/105463/diff/3/?file=71690#file71690line126>
> >
> > Won't this create a round-trip problem?
> > The
Time to involve the whole devel list I think:
Here is roughly where we stand in a discussion (between Inge and me, with
some public) about distraction free mode.
I think it is becoming concrete enough and will be of interest for others
in the ML.
Pierre
On Fri, Sep 7, 2012 at 10:16 AM, Inge
the maintenance
burden. However I am not sure it really would be that much, I think these
classes are now really mature and won't change that much. However, since I
personally don't have the time to do all this, the decision is not mine.
Pierre
___
On Thu, Oct 25, 2012 at 9:39 AM, Inge Wallin wrote:
>This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106983/
>
> Ship it!
>
> Looks good now.
>
> Only thing was that copyright notice is still missing in some files and some
> files still have cod
glitches in handling styles, but these are also
present in the current build.
Thanks,
Pierre Stirnweiss
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel
eally can't
remember what it was for. It has I think nothing to do with the present
functionality, so I'll remove this.
- Pierre
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107445
---
Playing around with it did not show regressions with current state of the
affair. There are a couple of glitches in handling styles, but these are also
present in the current build.
Thanks,
Pierre Stirnweiss
___
calligra-devel mailing list
calligra
board.kde.org/r/107445/diff/2/?file=96362#file96362line65>
> >
> > really?
Yes, we use the delegate's clickedInItem signal. I had a double emission. I
have not removed the lines completely for safety reasons.
- Pierre
-
---
Playing around with it did not show regressions with current state of the
affair. There are a couple of glitches in handling styles, but these are also
present in the current build.
Thanks,
Pierre Stirnweiss
___
calligra-devel mailing list
calligra
the
affair. There are a couple of glitches in handling styles, but these are also
present in the current build.
Thanks,
Pierre Stirnweiss
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel
<http://git.reviewboard.kde.org/r/107486/#comment17365>
What is the difference between ActiveAuthorInfo and AuthorInfo? Perhaps a
tad more verbose description.
- Pierre Stirnweiss
On Nov. 27, 2012, 12:14 p.m., C. Boemann
to work, and I have not spotted regressions.
Thanks,
Pierre Stirnweiss
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel
Diff: http://git.reviewboard.kde.org/r/107616/diff/
Testing
---
Thanks,
Pierre Stirnweiss
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel
nt. I personally
think this should go into a lib. I would not advocate merging it with
kotext however, because kotext is (AFAICT) and should stay non GUI.
Then there is a part of it which is GUI stuff (even within TextTool.cpp),
this is UI/form factor dependent. I think it should be somehow organi
tinfo/calligra-devel
>
basicflakes then? However, I think we are putting the cart before the
horses there. Shouldn't we first agree on a structure before discussing
labels?
Pierre
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel
http://git.reviewboard.kde.org/r/107849/diff/
Testing
---
Now it works for me ;)
Thanks,
Pierre Stirnweiss
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel
cursor does not have a selection, the character style was not applied.
Ok to backport?
Diffs
-
libs/kotext/KoTextEditor_format.cpp d1f0694
Diff: http://git.reviewboard.kde.org/r/107878/diff/
Testing
---
Thanks,
Pierre Stirnweiss
natural order now. I could not test regressions where
locale comparison would play a role however. But since KStringHandler's
comparison uses the Qt one, I don't expect a regression there.
Thanks,
Pierre Stirnweiss
___
calligra-devel mailing lis
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108022/#review24325
---
Ship it!
Ship It!
- Pierre Stirnweiss
On Dec. 31, 2012, 12
ext/styles/KoStyleManager.cpp 480fa19
plugins/textshape/dialogs/StylesModel.cpp 0e33084
Diff: http://git.reviewboard.kde.org/r/108051/diff/
Testing
---
Thanks,
Pierre Stirnweiss
___
calligra-devel mailing list
calligra-devel@kde.org
https://ma
/
Testing
---
Played around with the combo. Also fixed some issues spotted by Boemann earlier.
Thanks,
Pierre Stirnweiss
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel
(if we set
one).
Ok to backport?
Diffs
-
libs/kotext/KoTextEditor_format.cpp 7bd345b
Diff: http://git.reviewboard.kde.org/r/108191/diff/
Testing
---
Thanks,
Pierre Stirnweiss
___
calligra-devel mailing list
calligra-deve
and eventually the character style (if we set
one).
Ok to backport?
Diffs
-
libs/kotext/KoTextEditor_format.cpp 7bd345b
Diff: http://git.reviewboard.kde.org/r/108191/diff/
Testing
---
Thanks,
Pierre Stirnweiss
___
calligra-dev
://git.reviewboard.kde.org/r/108199/diff/
Testing
---
Thanks,
Pierre Stirnweiss
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel
---
Thanks,
Pierre Stirnweiss
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel
a style to the caret was not effective when the caret had no selection.
This change correct that bug.
Ok to backport?
Diffs
-
libs/kotext/KoTextEditor_format.cpp 5a35fe8
Diff: http://git.reviewboard.kde.org/r/108379/diff/
Testing
---
Thanks,
Pierre Stirnweiss
---
Thanks,
Pierre Stirnweiss
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel
not apply cleanly for me
> against 2.6 at least.
>
>
> - Friedrich W. H.
>
> On January 16th, 2013, 8:45 p.m. UTC, Pierre Stirnweiss wrote:
> Review request for Calligra and Friedrich W. H. Kossebau.
> By Pierre Stirnweiss.
>
> *Updated Jan. 16, 2013, 8:45 p.m.*
plugins/textshape/dialogs/StylesModel.cpp 80ea48d
Diff: http://git.reviewboard.kde.org/r/108444/diff/
Testing
---
Thanks,
Pierre Stirnweiss
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel
plugins/textshape/dialogs/DockerStylesComboModel.cpp 472f8b4
plugins/textshape/dialogs/StylesModel.cpp a264855
Diff: http://git.reviewboard.kde.org/r/108532/diff/
Testing
---
Thanks,
Pierre Stirnweiss
___
calligra-devel mailing list
calligra
ill be able to deliver
> - new interactive anchor ui
> - insertion of hyperlinks
> - restoring the review tool (without changetracking but with ui for
> spellchecking, tagging text with language)
> - new modebox (the sidebar thing) [done]
> - new zoom mode in Words [done]
>
of a testing branch is however how do we ensure that it
gets sufficient testing.
Pierre
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel
environment
and restore my repo from the backup. I'll try to do that during the week.
See you soon,
Pierre
On Mon, Mar 25, 2013 at 11:22 AM, C. Boemann wrote:
>This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109651/
>
> Ship it!
nusedParagraphStyles, along with the associated
> API addUnusedStyle(...) and moveToUsedStyles(...) was added later by
> Gopalakrishna.
>
> The last two are the most recently added, by Pierre, for use in the
> DockerStylesComboModel.
>
> Taking a paragraph style as example, when it is added t
201 - 259 of 259 matches
Mail list logo
