Re: Review Request 125485: Unselect text when the text tool is deactivated.

slide is changed - Camilla Boemann On Oct. 2, 2015, 8:53 p.m., David Faure wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 125485: Unselect text when the text tool is deactivated.

berlin for the qt world summit so no near my home computer, but will take a look when I get a chance - Camilla Boemann On Oct. 3, 2015, 9:56 a.m., David Faure wrote: > > --- > This is an automatically generated e-mail. To rep

Re: Review Request 125509: TextTool: ignore Esc key so that it can be used to switch back to the interaction tool

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125509/#review86330 --- Ship it! Ship It! - Camilla Boemann On Oct. 3, 2015, 5:21

Re: ChangeListLevelCommand bug?

Could look like that yes - unfortunately the guy who were most into this have not been active for over a year so i think the best way to know for sure is to debug it - all i can say is that the layout works so it's either the interaction - but your evidence suggests that is correct or the setu

RE: findings from the plugfest

Thanks -Original Message- From: calligra-devel [mailto:calligra-devel-boun...@kde.org] On Behalf Of Jos van den Oever Sent: 19. november 2015 09:48 To: Calligra Suite developers and users mailing list Subject: findings from the plugfest Hello dear Calligra developers, At the last ODF

RE: KDE ODF TC membership

Yes it's still true -Original Message- From: calligra-devel [mailto:calligra-devel-boun...@kde.org] On Behalf Of Jos van den Oever Sent: 3. december 2015 10:31 To: calligra-devel@kde.org Subject: KDE ODF TC membership Hello all, Since September I represent the Dutch government in the OD

RE: Consistent naming of folders in libs/ & renaming kundo2 -> koundo

Yeah regarding library names the renaming should rather be the other way I don't want that ko everywhere And regarding kundo2 - wasn't it supposed to be a clone of the qt5 so we could get rid of our own version ? -Original Message- From: calligra-devel [mailto:calligra-devel-boun...@kde

Re: Review Request 125485: Unselect text when the text tool is deactivated.

;t want it to be rendered - Camilla Boemann On Oct. 3, 2015, 9:56 a.m., David Faure wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > htt

Re: Calligra and GSoC 2016

On Thursday 03 March 2016 01:08:11 Денис Купляков wrote: > Good evening! > > As you know GSoC 2016 will start soon. And I will be very happy to > participate the third time with Calligra. Sorry, for being out of the deal > for long period of time: I took too much of additional courses in > univers

Re: Review Request 127371: Support selections in Calligra ODT plugin for Okular (main textflow-only for now)

so specific libs/textlayout/KoTextLayoutTableArea.cpp (line 287) <https://git.reviewboard.kde.org/r/127371/#comment63881> because for painting we want to repeat the headers on every page :) - Camilla Boemann On March 18, 2016, 12:56 a.m., Friedrich W.

Re: Review Request 127338: Fix loading documents containing nested tables

have made a more correct fix - it's however not pushed to master yet - so please have some patience - Camilla Boemann On March 11, 2016, 12:08 a.m., Laszlo Pasztor wrote: > > --- > This is an automatically generated e-mail. T

Re: Review Request 124641: Refactoring KoTextEditor::recursivelyVisitSelection() to make it cleaner and easier to understand

l2 in which case it's not a complex selection so it fails please discard request - Camilla Boemann On Aug. 6, 2015, 11:48 a.m., Soma Schliszka wrote: > > --- > This is an automatically generated e-mail. To re

Re: Review Request 127371: Support selections in Calligra ODT plugin for Okular (main textflow-only for now)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127371/#review94025 --- Ship it! Ship It! - Camilla Boemann On March 18, 2016

RE: working on saving to multiple formats

Yes we simply havn't had the manpower to do this - so would appreciate any help -Original Message- From: calligra-devel [mailto:calligra-devel-boun...@kde.org] On Behalf Of Ryein C. Goddard Sent: 16. maj 2016 00:54 To: calligra-devel@kde.org Subject: working on saving to multiple formats

RE: working on saving to multiple formats

You are quite correct in that Words, Sheets and Stage can’t say to anything but ODF formats. The only format besides that is pdf and I think .txt neither of which is what people think of when talking about saving. If it says Words can save to Word then it is to rtf when leaves a lot to be de

RE: Contributing again

Hi and welcome back I think the review policy is as ever, get it reviewed somehow if it touches common areas. We use phabricator as the online tool. So glad to get this mail - I feel motivated to hack this weekend too now - let's try and get this release going :) Best regards Camilla Bo

state of release and release plan

Hi I think it's time we get a release out. We are stuck with not much work going on so inspired by Dag's return let's do a push to get ready. I think we should cut down on the number of applications so we have something manageble left. It's tough but the alternative is that Calligra dies compl

Re: state of release and release plan

ive to fix KReport is to implement a different way to get this > info in Plan. > > Report items Chart and Web has not afaics been ported yet. > > Expects to know more on monday, > Dag > > Camilla Boemann skrev den 2016-07-02 08:17: > > Hi > > > > I think it&

Re: Introduction of a "type mode" and an "unicode mode" of input

Hi I don't understand this either. 1) all text in calligra is unicode 2) we have a dialog that allows you to enter specific charactes from any unicode range 3) yes it is true that the font used to show the text has to support the script. But a few free unicode fonts do exist already On Saturd

Re: Introduction of a "type mode" and an "unicode mode" of input

On Saturday 02 July 2016 21:18:05 Samiur Rahman wrote: > The box should actually say "“Choose character set." Definitely not. We use unicode and nothing else. We want to support the entire world. But we don't ship fonts and we don't provide input methods for other languages. Both tasks fall unde

Re: Introduction of a "type mode" and an "unicode mode" of input

On Sunday 03 July 2016 12:06:40 Jos van den Oever wrote: > On Sunday 03 July 2016 10:54:21 Camilla Boemann wrote: > > I feel that you mean something else like a way to select several "current > > fonts" rather than just a single font. And a way to assign what unicode >

Re: How to number components of Calligra 3

On Sunday 03 July 2016 01:10:52 Jaroslaw Staniek wrote: > How to number components of Calligra 3? I mean apps and libs. Well I wouldn't mind dates or codenames for the public versioning, but versions numbers are also for internal usage, so we know when we make big api/code changes And I see no

RE: Plan status

Have a nice vacation! -Original Message- From: calligra-devel [mailto:calligra-devel-boun...@kde.org] On Behalf Of Dag Sent: 15. juli 2016 14:10 To: calligra-devel@kde.org Subject: Plan status Vacation is going to hit soon, and plan is not ready... It has been a frustrating week with too

RE: Qt version

My build machine (debian) is still 5.6 so until they are at 5.7 I cannot agree to bumping higher than 5.6 -Original Message- From: calligra-devel [mailto:calligra-devel-boun...@kde.org] On Behalf Of Dag Sent: 10. august 2016 14:27 To: calligra-devel@kde.org Subject: Qt version I added a 5

RE: state of release and release plan

Thanks Boud for the offer - much appreciated! Dag let's try and get something out the sooner the better - even if it has some known bugs that are not too serious - it's the only way to create buzz and hopefully draw in more volunteers -Original Message- From: calligra-devel [mailto:calli

Re: Review Request 129420: [calligra] Remove obsolete typedefs, deprecated since Qt 5.7

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129420/#review100915 --- Ship it! Ship It! - Camilla Boemann On Nov. 17, 2016

Re: Review Request 129421: [karbon] Returning of Karbon as maintained product

but make yourself a maintainer by deed before we make you one by name. Deal? And just to emphazise it would be really great to see you work on karbon - it deserves to come to full glory! - Camilla Boemann On Nov. 17, 2016, 8:09 p.m., A

Re: Review Request 129421: [karbon] Returning of Karbon as maintained product

> On Nov. 17, 2016, 10:09 p.m., Camilla Boemann wrote: > > It's great that you want to co maintain - i think you could even apply for > > maintaining without the "co-", but i also think it's a bit premature to > > remove that message. Maintain (be

Re: Review Request 129421: [karbon] Returning of Karbon as maintained product

> On Nov. 17, 2016, 10:09 p.m., Camilla Boemann wrote: > > It's great that you want to co maintain - i think you could even apply for > > maintaining without the "co-", but i also think it's a bit premature to > > remove that message. Maintain (be

Re: Review Request 129435: [shapefiltereffects] Update ConvolveMatrixEffect kernel accordingly to order

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129435/#review100953 --- Ship it! Ship It! - Camilla Boemann On Nov. 19, 2016

Re: Review Request 129421: [karbon] Returning of Karbon as maintained product

> On Nov. 17, 2016, 10:09 p.m., Camilla Boemann wrote: > > It's great that you want to co maintain - i think you could even apply for > > maintaining without the "co-", but i also think it's a bit premature to > > remove that message. Maintain (be

Re: Review Request 129437: [widgets] Make sure destination xml file path exist

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129437/#review100968 --- Ship it! Ship It! - Camilla Boemann On Nov. 20, 2016

Re: Review Request 129438: [karbon] Correct usage of KPageDialog in KarbonConfigureDialog.cpp

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129438/#review100969 --- Ship it! Ship It! - Camilla Boemann On Nov. 20, 2016

Re: Review Request 129421: [karbon] Returning of Karbon as maintained product

> On Nov. 17, 2016, 10:09 p.m., Camilla Boemann wrote: > > It's great that you want to co maintain - i think you could even apply for > > maintaining without the "co-", but i also think it's a bit premature to > > remove that message. Maintain (be

Re: Review Request 129532: [shortcuts] Undo / Redo shortkeys

tps://git.reviewboard.kde.org/r/129532/#comment67757> hmm we shouldn't hardcode these key combinations - Camilla Boemann On Nov. 22, 2016, 7:27 p.m., Anthony Fieroni wrote: > > --- > This is an automatically generated e-mail. To r

Re: Review Request 129532: [shortcuts] Undo / Redo shortkeys

redo - Camilla Boemann On Nov. 22, 2016, 8:30 p.m., Anthony Fieroni wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 129532: [shortcuts] Undo / Redo shortkeys

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129532/#review101087 --- Ship it! Ship It! - Camilla Boemann On Nov. 23, 2016

Re: Review Request 129531: [flake] Serialize / deserialize svg conicalGradient

h but if you think it works then it's good enough for me - Camilla Boemann On Nov. 22, 2016, 9:07 p.m., Anthony Fieroni wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.review

Re: Review Request 129514: [connectionTool] Check dynamic_cast return type

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129514/#review101109 --- Ship it! Ship It! - Camilla Boemann On Nov. 21, 2016

Re: Review Request 129421: [karbon] Returning of Karbon as maintained product

karbon you can just commit without review request - we will review when we see the commit mails - just don't break build or push big stuff without some kind of warning etc - Camilla Boemann On Nov. 26, 2016, 6:12 a.m., Anthony Fieroni

Re: Review Request 129682: calligra: Update Czech Republic to Czechia

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129682/#review101530 --- Ship it! Ship It! - Camilla Boemann On Dec. 20, 2016

RE: 3.0.0.1 tarball + signature

I have prepared a release announcement, but it doesn't say much so maybe someone has suggestions as to what we should highlight? https://www.calligra.org/?p=4837&preview=true -Original Message- From: calligra-devel [mailto:calligra-devel-boun...@kde.org] On Behalf Of Boudewijn Rempt Sent:

RE: 3.0.0.1 tarball + signature

Subject: RE: 3.0.0.1 tarball + signature Camilla Boemann skrev den 2017-01-03 12:59: > I have prepared a release announcement, but it doesn't say much so > maybe someone has suggestions as to what we should highlight? I was thinking something like this for the packagers: A new

RE: 3.0.0.1 tarball + signature

Sure but I did say in my draft that we are porting and that it sets a bright new future – but really for the average user it doesn’t matter much what kind of tools we use – it’s what it means for the user that is important From: calligra-devel [mailto:calligra-devel-boun...@kde.org] On Behalf

Re: Review Request 129782: [calligra] Buildsystem improvements

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129782/#review101845 --- Ship it! Ship It! - Camilla Boemann On Jan. 6, 2017

RE: isn't it time for...

Done -Original Message- From: calligra-devel [mailto:calligra-devel-boun...@kde.org] On Behalf Of Boudewijn Rempt Sent: 14. januar 2017 20:29 To: calligra-devel@kde.org Subject: isn't it time for... A release announcement? -- Boudewijn Rempt | http://www.krita.org, http://www.valdyas.or

RE: Release 3.0.1

Nothing new from my end, so please go ahead -Original Message- From: calligra-devel [mailto:calligra-devel-boun...@kde.org] On Behalf Of Dag Sent: 10. marts 2017 13:03 To: calligra-devel@kde.org Subject: Release 3.0.1 Hi, should we make a bug fix release soon? A few bugs has been fixed,

Re: Review Request 130196: Add a seed parameter to make the qHash used

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130196/#review103464 --- Ship it! Ship It! - Camilla Boemann On July 22, 2017

D6844: clazy fixes for kostore

boemann accepted this revision. boemann added a comment. This revision is now accepted and ready to land. No need to review these very simple changes - just make sure you test before pushing REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D6844 To: vandenoever, #calli

please turn off comments for calligra site

There are way too many spam messages these Days so could someone with admin rights please turn them off or install a captcha or something Also it would be ice if more of us had admin rights Please help out asap

D9537: [kotextlayoutarea] Make percentage line height relative to the default height

boemann added a comment. I have my linux partiotion working again, so I'l take a look this weekend - is there a bug number and a test document somewhere ? REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D9537 To: anthonyfieroni, danders, mecir, boemann Cc: Calligra-De

D9537: [kotextlayoutarea] Make percentage line height relative to the default height

boemann added a comment. Okay I basically believe you are right, but before I accept I ask you to make the corresponding changes in textshape/dialogs/ParagraphIndentSpacing.cpp Where the 120% should be 100% etc Also having tested with Libreoffice I think the correct scale is 1.16

D9537: [kotextlayoutarea] Make percentage line height relative to the default height

boemann added a comment. So now we are just missing the texttool ui changes REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D9537 To: anthonyfieroni, danders, mecir, boemann Cc: Calligra-Devel-list, cochise, vandenoever

D9537: [kotextlayoutarea] Make percentage line height relative to the default height

boemann added a comment. no just: if (percent != 0) height *= percent/100 height *= 1.16; REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D9537 To: anthonyfieroni, danders, mecir, boemann Cc: Calligra-Devel-list, cochise, vandenoever

D9537: [kotextlayoutarea] Make percentage line height relative to the default height

boemann added a comment. in plugins/textshape/dialogs there is a file that handles line height (can't remember which exactly) when converting between the 1x, 2x etc and a percentage it right now aplies the 1.2 but this is wrong: it should just convert 1x as 100%, 2x as 200% The

D9537: [kotextlayoutarea] Make percentage line height relative to the default height

boemann added a comment. yes and line 233-235 in the same file - fix that and we are ready to push REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D9537 To: anthonyfieroni, danders, mecir, boemann Cc: Calligra-Devel-list, cochise, vandenoever

D9537: [kotextlayoutarea] Make percentage line height relative to the default height

boemann added a comment. except that its 1, 1½, 2 and not 1,2,3 then it looks good REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D9537 To: anthonyfieroni, danders, mecir, boemann Cc: Calligra-Devel-list, cochise, vandenoever

D9537: [kotextlayoutarea] Make percentage line height relative to the default height

boemann accepted this revision. boemann added a comment. Thanks REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D9537 To: anthonyfieroni, danders, mecir, boemann Cc: Calligra-Devel-list, cochise, vandenoever

D9537: [kotextlayoutarea] Make percentage line height relative to the default height

boemann added a comment. given that we no multiply with1.16 the values should be: 12*1.16, 24*1.16, no Don't know what the last is supposed to be but it should probably have the same treatment REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D9537 To: anthonyfieron

D15111: [KoUnit] Let's show pixel units

boemann added a comment. What is the purpose of showing pixel units in general - pixels is not really a unit except in very specific cases - I'd saythis is very very wrong What is the size of pixel in your mind anyway? REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.o

D15111: [KoUnit] Let's show pixel units

boemann added a comment. Yes, that is exactly how they could use it but, I think we are doing a disservice by offering such an option- there is no way an author can know the destination resolution and it will only apply to one destination. Besides why would they even need to know - we ar

D15111: [KoUnit] Let's show pixel units

boemann added a comment. The problem here is if they think they can place a line on a specific pixel position - we don't store coords as pixels - so it will not end being rendered to a specific pixel anyway - we will just end up with users not getting what they think they get, even in such

D15111: [KoUnit] Let's show pixel units

boemann added a comment. discard as a general solution - it doesn't make close to any sense for other than karbon when used as a tool to generate pixmaps in the end, and even then as I said it's a bad idea for various reasons REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kd

D15103: Replace deprecated use of QWeakPointer in favor of QPointer

boemann added a comment. I have no fundamentally against it, but I cannot test it right - so if it works 'm all for it REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D15103 To: dcaliste, #calligra:_3.0, leinir, danders, boemann Cc: Calligra-Devel-list, cochise, vande

D15111: [KoUnit] Let's show pixel units

boemann added a comment. And none of that contradicts me saying it's not a general feature we want, but at most for Karbon, and that since we don't store pixel values but rather convert to points the user will not get pixel precise placement anyway REPOSITORY R8 Calligra REVISION DETAIL

D14901: Fix blocklayout unittest after percentage lineheight was fixed in D9537

boemann accepted this revision. boemann added a comment. This revision is now accepted and ready to land. I like what you have done - you seem to understand the concepts, so please commit when you feel like it's working INLINE COMMENTS > TestBlockLayout.cpp:333 > //qDebug() << blockLay

D15403: {Style] Default sheets to white background

boemann added a comment. No Idea about the code, but in general I have no problem with sheets respecting the palette REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D15403 To: anthonyfieroni, danders, boemann Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D15428: [textlayout] Don't enter infinite loop when table is misfit

boemann added inline comments. INLINE COMMENTS > KoTextLayoutNoteArea.cpp:143 > + > +if (blockLayoutLine.isValid()) { > +d->labelYOffset += blockLayoutLine.ascent(); I'm fine with this change > KoTextLayoutTableArea.cpp:464 > +//if we couldn't fit the header rows > +

D15428: [textlayout] Don't enter infinite loop when table is misfit

boemann added a comment. The idea is that if we are at the beginning of a new page we don't get in here (virginpage is true) so we only reset if we are somewhere down on a page meaning we wil have more space to try on next time around But we should reset if the only thing we fitted was th

D15428: [textlayout] Don't enter infinite loop when table is misfit

boemann added a comment. I am more thinking of this place: https://phabricator.kde.org/source/calligra/browse/master/libs/textlayout/KoTextLayoutTableArea.cpp$436 this shouldn't be set if we are doing a headerrow, so please try this: if (cursor->row >= d->headerRows) setV

D15412: [filters] Extend table lifetime

boemann added a comment. No idea either - jaroslaw was the original author so maybe he can take a look REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D15412 To: anthonyfieroni, danders, boemann, #calligra:_3.0 Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D15549: Words: Save anchor info also for page-anchored shapes

boemann added a comment. Bah I can't remember this, but page anchored shapes don't have anchors as such, so I'm wondering what exactly is this writing to file? REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D15549 To: danders, boemann Cc: Calligra-Devel-list, dcalist

D15549: Words: Save anchor info also for page-anchored shapes

boemann accepted this revision. This revision is now accepted and ready to land. REPOSITORY R8 Calligra BRANCH danders_words_anchor REVISION DETAIL https://phabricator.kde.org/D15549 To: danders, boemann Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D15728: Try to avoid segfaults on shape factory not found

boemann accepted this revision. This revision is now accepted and ready to land. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D15728 To: dcaliste, leinir, anthonyfieroni, danders, #calligra:_3.0, boemann Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D15775: Make the item background color and page cache properties available from View component

boemann added a comment. 'm sorry but the background should not be settable - it's a document property at best and in fact paper is mostly white, so shouldn't even be settable REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D15775 To: dcaliste, leinir, danders, antho

D15775: Make the item background color and page cache properties available from View component

boemann added a comment. Ahh well in that case I don't mind and the words code looks clean enough - I'll let someone else review the components REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D15775 To: dcaliste, leinir, danders, anthonyfieroni, #calligra:_3.0 Cc: boe

D16367: EnhancedPathShape: Shape is moved/resized on save/load

boemann added a comment. Yes as i recall that code was made to handle masks being exported correctly for OpenOffice or LO - I'd strongly prefer it not being thrown away like that REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D16367 To: danders, boemann, anthonyfier

D16367: EnhancedPathShape: Shape is moved/resized on save/load

boemann added a comment. As I recall it was one of the files in the huge dataset - there should be a bug on it REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D16367 To: danders, boemann, anthonyfieroni Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D16679: Words: Fix interop problem with LO/OO

boemann accepted this revision. This revision is now accepted and ready to land. REPOSITORY R8 Calligra BRANCH words_pagestyle_danders REVISION DETAIL https://phabricator.kde.org/D16679 To: danders, boemann Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D15428: [textlayout] Don't enter infinite loop when table is misfit

boemann added a comment. Dan I like your diff better - I don't think it's completely there but it's a better starting point On a more conceptual level, what should happen if the design of table is such that headers can't fit on a virgin page? What should we do.? One one hand it should b

D15428: [textlayout] Don't enter infinite loop when table is misfit

boemann added a comment. No you misunderstand. I wasn't talking about you diff - I want to know what it is we are trying to accomplish. in spoken words REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D15428 To: anthonyfieroni, #calligra:_3.0, danders, boemann Cc: Call

D15428: [textlayout] Don't enter infinite loop when table is misfit

boemann added a comment. Still not the description i was looking for. I want to know what the extreme case is and what the resulting document should look like when we give up: A table without header rows and that doesn't fit will be layouted and shown in pieces What I want to know

D15428: [textlayout] Don't enter infinite loop when table is misfit

boemann added a comment. And has anyone been able to produce a smaller 1 page example of the document - we are stumbling blindly here. Do we have an odf snippet of the table that gives the problem? REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D15428 To: anthonyf

D15428: [textlayout] Don't enter infinite loop when table is misfit

boemann added a comment. good investigative work, but I fear those tests are way too simple to dare apply the patch. The table code handles a lot more cases than a simple 2x1 table merged will uncover. I'm a bit surprised of the problems you describe in master - I don't recall any such

D18095: Add new table layout unit tests

boemann added a comment. Looks like a good first start to me - do they pass currently? - if so then i think they should be pushed I'll think about further tests REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D18095 To: danders, boemann, anthonyfieroni Cc: Callig

D18095: Add new table layout unit tests

boemann added a comment. absolutely REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D18095 To: danders, boemann, anthonyfieroni Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D18448: Replaced "distraction free" with "fullscreen" - BUG:378527

boemann accepted this revision. This revision is now accepted and ready to land. REPOSITORY R8 Calligra BRANCH replace-disturbfree-with-fullscreen (branched from master) REVISION DETAIL https://phabricator.kde.org/D18448 To: niccolove, boemann Cc: Calligra-Devel-list, dcaliste, cochise, v

D18466: Fixed calligra crashing when opening remote document

boemann added a comment. Could you please describe what you have done and why REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D18466 To: niccolove Cc: boemann, Calligra-Devel-list, dcaliste, cochise, vandenoever

D18466: Fixed calligra crashing when opening remote document

boemann added a comment. Yes that description helped a lot, and you are doing great. Keep up the good work :) One concern though - how often and when is openDoumentInternal called. I'm a bit afraid that we just add some functionality to a place that might be used for something else REP

D18466: Fixed calligra crashing when opening remote document

boemann added a reviewer: danders. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D18466 To: niccolove, danders Cc: boemann, Calligra-Devel-list, dcaliste, cochise, vandenoever

D18466: Fixed calligra crashing when opening remote document

boemann added a comment. Please check with loading a normal document,. The same concerns now applies to slotLoadCompleted - especially since you have now removed functionality from it. Also please check in all of our applications as some might reimplement virtual methods REPOSITORY R

D18466: Fixed calligra crashing when opening remote document

boemann added a comment. regarding the lambda connection - nice to see that you use the version with a "still alive" argument - but I fear this requires a qt version higher than what we currently support - could you please check REPOSITORY R8 Calligra REVISION DETAIL https://phabricat

D18963: Improve KoModeBox display in horizontal Mode

boemann accepted this revision. boemann added a comment. This revision is now accepted and ready to land. I like it REPOSITORY R8 Calligra BRANCH calligra/3.1 REVISION DETAIL https://phabricator.kde.org/D18963 To: ognarb, #calligra:_3.0, #vdg, boemann Cc: boemann, anthonyfieroni, abet

D18466: Fixed calligra crashing when opening remote document

boemann added a comment. Dan can you please reply - I'm fine with the account but I can't reply to Ben as I am not able to send email REPOSITORY R8 Calligra BRANCH print-remote-files (branched from master) REVISION DETAIL https://phabricator.kde.org/D18466 To: niccolove, danders Cc:

D18843: Activate stencils docker in all apps

boemann accepted this revision. boemann added a comment. This revision is now accepted and ready to land. I definitely don't want this docker default on, but if as you say it's default off then i guess your change is okay - i'll take your word for it REPOSITORY R8 Calligra BRANCH activat

D18989: Remove minor duplicate code and fix related bug

boemann accepted this revision. This revision is now accepted and ready to land. REPOSITORY R8 Calligra BRANCH dev REVISION DETAIL https://phabricator.kde.org/D18989 To: ognarb, #calligra:_3.0, boemann Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D19216: Karbon: Enable multi page capability

boemann added a comment. totally agree about not theme'ing canvas Also a general agreement to do the page app thing as long as it's also supported in svg odg is hardly that much of a reason - it even seems like odf is moving away from odg as much as possible REPOSITORY R8 Calligr

D15428: [textlayout] Don't enter infinite loop when table is misfit

boemann added a comment. no REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D15428 To: anthonyfieroni, #calligra:_3.0, danders, boemann Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D19216: Karbon: Enable multi page capability

boemann added a comment. In D19216#421654 , @rjvbb wrote: > > No, the canvas is part of the document and must never be themed. The canvas background is as much part of your drawing as any line you put on it. > > This hasn't been sitting rig

D22545: Add missing include QDate

boemann accepted this revision. boemann added a comment. This revision is now accepted and ready to land. btw For such small fixes we don't usually require review REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D22545 To: usta, #calligra:_3.0, Calligra-Devel-list, boem

  1   2   3   >