Re: Review Request: Move core parts of KexiDB lib to libcalligradb

2012-07-07 Thread C. Boemann
> On July 7, 2012, 8:36 a.m., C. Boemann wrote: > > building gives me this error > > > > /home/cbo/devel/calligra/kexi/migration/keximigratedata.h:25:27: fatal > > error: db/connection.h: No such file or directory > > Jarosław Staniek wrote: > Plea

Re: Review Request: [calligratests] fixes bad strings "Formula.hidden" and "protected Formula.hidden" for style:cell-protect in Sheets

2012-07-07 Thread C. Boemann
and obvious bug - i'd say ship it and backport - C. Boemann On July 7, 2012, 11:56 a.m., Friedrich W. H. Kossebau wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard

Re: Review Request: Move core parts of KexiDB lib to libcalligradb

2012-07-07 Thread C. Boemann
mes (KoConnection.cpp > > instead of connection.cpp, for instance), getting rid of the namespaces and > > references to Kexi. > > C. Boemann wrote: > Well normally i would agree but this library is on a short life cycle, as > it will be replaced by predicate > > Boudew

Re: Repeating rounding errors with svg:viewBox, svg:d & friends

2012-07-08 Thread C. Boemann
On Sunday 08 July 2012 00:29:28 Friedrich W. H. Kossebau wrote: > Hi, > > is anyone currently looking into improving graph data handling? > > Because things are slightly screwed there IMHO. > > E.g. I was trying to fix EnhancedPathShape::saveOdf(...), which is > currently saving non-integer data

Re: Review Request: Move core parts of KexiDB lib to libcalligradb

2012-07-11 Thread C. Boemann
ned we can ship it. I acknowledge the concerns that it doesn't respect our coding standards, but given it's temporary I would much rather see working hours being put into making the replacement, than make this conform to standards. - C. Boemann On July 7, 2012, 12:34 a.m., Ja

Re: Review Request: Use translated UserBase pages for the Calligra applications

2012-07-12 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105443/#review15715 --- Ship it! Ship It! - C. Boemann On July 4, 2012, 6:07 p.m

RC readiness, not

2012-07-12 Thread C. Boemann
Hi We still have two release blockers, so it would seem we need another week before RC tagging Unless someone magically fixes those tonight.. Boemann ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligr

Re: Review Request: use the global iconloader for KoTemplate::loadPicture(), so calligra icons are found

2012-07-12 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105429/#review15721 --- Ship it! Ship It! - C. Boemann On July 3, 2012, 10:52 p.m

Re: Review Request: [calligratests] fix table cell style code wrongly saving/loading draw:opacity with ODF

2012-07-12 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105444/#review15726 --- Ship it! Ship It! - C. Boemann On July 4, 2012, 7:14 p.m

Re: RC readiness, not

2012-07-12 Thread C. Boemann
On Thursday 12 July 2012 16:46:34 Cyrille Berger Skott wrote: > On Thursday 12 Jul 2012, C. Boemann wrote: > > Hi > > > > We still have two release blockers, so it would seem we need another week > > before RC tagging > > That would be very inconvenient for me.

Re: Review Request: make parsing of fo:clip more strict, but also backward compatible

2012-07-12 Thread C. Boemann
all your extra check probably doens't do any harm - do we have reason to believe they are needed? libs/flake/KoOdfWorkaround.cpp <http://git.reviewboard.kde.org/r/105528/#comment12235> are we sure this will hold - C. Boemann On July 12, 2012, 6:52 p.m., Friedrich W. H. Kos

Re: Review Request: make parsing of fo:clip more strict, but also backward compatible

2012-07-12 Thread C. Boemann
rtain of plugins/pictureshape/PictureShape.cpp <http://git.reviewboard.kde.org/r/105528/#comment12237> does it reall mean 0.0 for right and bottom too? - C. Boemann On July 12, 2012, 7:17 p.m., Friedrich W. H. Kos

Re: Review Request: remove AI as supported mimetype from Karbon desktop files

2012-07-12 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105372/#review15741 --- Ship it! - C. Boemann On June 28, 2012, 7:03 a.m

Re: Review Request: make parsing of fo:clip more strict, but also backward compatible

2012-07-12 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105528/#review15744 --- Ship it! ok i'd say css2 only - C. Boemann On Ju

Re: Review Request: fix/restore thumbnailing for Words

2012-07-12 Thread C. Boemann
On Thursday 12 July 2012 22:44:19 Friedrich W. H. Kossebau wrote: > Am Sonntag, 1. Juli 2012, 07:58:24 schrieb C. Boemann: > > > On July 1, 2012, 4:42 a.m., C. Boemann wrote: > > > > No idea if there is a better solution either, but if it works then > > > > f

Re: Review Request: fixes broken writing of number:text-style

2012-07-12 Thread C. Boemann
- C. Boemann On July 12, 2012, 10:03 p.m., Friedrich W. H. Kossebau wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.

Re: Review Request: replace deprecated KLocale::fragDigits with KLocale::monetaryDecimalNumbers in Calligra Sheets

2012-07-12 Thread C. Boemann
that a similar request for Plan? - C. Boemann On July 10, 2012, 6:18 a.m., Friedrich W. H. Kossebau wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.

Re: Review Request: replace deprecated KLocale::fragDigits with KLocale::monetaryDecimalNumbers in Calligra Sheets

2012-07-12 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105501/#review15761 --- Ship it! Ship It! - C. Boemann On July 10, 2012, 6:18 a.m

Re: Review Request: replace deprecated KLocale::fragDigits with KLocale::monetaryDecimalNumbers in Calligra Sheets

2012-07-12 Thread C. Boemann
> On July 12, 2012, 10:15 p.m., C. Boemann wrote: > > I could have sworn I saw a ship-it by Dag for this, or was that a similar > > request for Plan? > > > > > > Friedrich W. H. Kossebau wrote: > Yes, I splitted between Sheets and Plan, hoping

Re: [calligra] /: Move core parts of KexiDB lib to libcalligradb

2012-07-12 Thread C. Boemann
On Friday 13 July 2012 00:46:30 Jaroslaw Staniek wrote: > On 12 July 2012 16:55, Cyrille Berger Skott wrote: > > Hi, > > > > I get the following error since your commit: > > > > http://my.cdash.org/viewConfigure.php?buildid=363921 > > Isn't it missing ICU or ICU devel? > > > I also don't think

Re: [calligra] /: Move core parts of KexiDB lib to libcalligradb

2012-07-12 Thread C. Boemann
On Friday 13 July 2012 08:45:13 Cyrille Berger Skott wrote: > On Friday 13 Jul 2012, you wrote: > > Flexibility is a +1, but one -1 (besides adding further complexity to > > cmake files) is that these build profiles should only be used for > > custom builds. We don't want stripped-down Word in the

Re: Review Request: fix & improve template generation code

2012-07-13 Thread C. Boemann
should be some spacing between the two Other than that I like it - C. Boemann On July 1, 2012, 11:26 p.m., Friedrich W. H. Kossebau wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewb

Re: Review Request: fixes KWOdfWriter to write tracked changes before declarations (ODF 1.2 spec wants that)

2012-07-13 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105545/#review15770 --- Ship it! sure, thanks - C. Boemann On July 13, 2012, 7:24

Re: [calligra] /: Move core parts of KexiDB lib to libcalligradb

2012-07-13 Thread C. Boemann
On Friday 13 July 2012 10:11:20 Boudewijn Rempt wrote: > On Friday 13 July 2012 Jul, C. Boemann wrote: > > On Friday 13 July 2012 08:45:13 Cyrille Berger Skott wrote: > > > On Friday 13 Jul 2012, you wrote: > > > > Flexibility is a +1, but one -1 (besides adding furth

Re: [calligra] /: Move core parts of KexiDB lib to libcalligradb

2012-07-13 Thread C. Boemann
On Friday 13 July 2012 10:07:28 Boudewijn Rempt wrote: > On Friday 13 July 2012 Jul, Jaroslaw Staniek wrote: > > On 13 July 2012 01:12, C. Boemann wrote: > > > No, it's a hard dependency for Words/kotext, but for CREATIVEONLY I > > > have no objection, though it

Re: Review Request: fix & improve template generation code

2012-07-13 Thread C. Boemann
backport using the old strings though (or check if those strings are not already used) - C. Boemann On July 13, 2012, 12:16 p.m., Friedrich W. H. Kossebau wrote: > > --- > This is an automatically generated e-mail. To reply, visi

Re: RC readiness, not

2012-07-13 Thread C. Boemann
On Friday 13 July 2012 15:54:49 Friedrich W. H. Kossebau wrote: > Am Donnerstag, 12. Juli 2012, 17:06:51 schrieb C. Boemann: > > On Thursday 12 July 2012 16:46:34 Cyrille Berger Skott wrote: > > > On Thursday 12 Jul 2012, C. Boemann wrote: > > > > Hi > > &g

Re: RC readiness, not

2012-07-13 Thread C. Boemann
On Friday 13 July 2012 21:29:50 Cyrille Berger Skott wrote: > On Friday 13 Jul 2012, Thorsten Zachmann wrote: > > > And yes, Words is not considered end-user ready, this why the release > > > has the 2.5 version number and not 3.0. > > > > And we still can fix those bugs commit them to master and

Re: Review Request: Fix some icon names to reference existing icons (2.5 branch)

2012-07-14 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105284/#review15866 --- Anyone having any objections left? - C. Boemann On June 25

Re: Review Request: Fix some icon names to reference existing icons (2.5 branch)

2012-07-15 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105284/#review15872 --- Ship it! Ship It! - C. Boemann On June 25, 2012, 12:59 a.m

Re: Review Request: fix icon of picture tool

2012-07-15 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105581/#review15903 --- Ship it! It has my vote for sure - C. Boemann On July 15

Re: Review Request: Fix loading of embedded svg graphics.

2012-07-16 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105589/#review15947 --- Looks sane to me. I would be all for a backport too - C

Re: Review Request: Save anchors that refer to internal points as anchors and not as bookmarks

2012-07-16 Thread C. Boemann
-to--links are now activated with ctrl+click - C. Boemann On July 16, 2012, 1:51 p.m., Gopalakrishna Bhat wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.

Re: Review Request: Fix bug 301212: Ruler is not shown in mm units

2012-07-17 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105602/#review16027 --- Ship it! Ship It! - C. Boemann On July 17, 2012, 6:54 p.m

Re: Review Request: fix parsing and writing of style:shadow value

2012-07-18 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105606/#review16058 --- looks good to me. tempted to say ship it - C. Boemann On

Re: Review Request: fix parsing of fo:border in KoParagraphStyle

2012-07-18 Thread C. Boemann
- C. Boemann On July 18, 2012, 2:05 a.m., Friedrich W. H. Kossebau wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.

Re: Review Request: Fix loading of embedded svg graphics.

2012-07-18 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105589/#review16060 --- Ship it! Ship It! - C. Boemann On July 18, 2012, 5:15 a.m

Re: Review Request: Show error message to the user on "Export to PDF" failure

2012-07-19 Thread C. Boemann
/KoPrintJob.h <http://git.reviewboard.kde.org/r/105623/#comment12727> maybe explain a bit more, about how to reimplement, purpose of method etc. - C. Boemann On July 19, 2012, 5:15 p.m., Gopalakrishna Bhat wrote: > > ---

Re: Anybody working on text column separators?

2012-07-19 Thread C. Boemann
On Thursday 19 July 2012 17:50:12 Friedrich W. H. Kossebau wrote: > Hi, > > I came across the issue that columns in texts are not yet completely > supported. Is anyone working on that? > > For a start I did a patch (attached) which makes at least the column > separator data survive a roundtrip th

Re: Anybody working on text column separators?

2012-07-19 Thread C. Boemann
On Friday 20 July 2012 07:24:13 C. Boemann wrote: > On Thursday 19 July 2012 17:50:12 Friedrich W. H. Kossebau wrote: > > Hi, > > > > I came across the issue that columns in texts are not yet completely > > supported. Is anyone working on that? > > > > For

Re: Review Request: Show error message to the user on "Export to PDF" failure

2012-07-20 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105623/#review16166 --- Ship it! Ship It! - C. Boemann On July 20, 2012, 4:09 p.m

Re: Review Request: fix KisPaintOpPresetsPopup to use an existing icon for the paintPresetIcon button

2012-07-22 Thread C. Boemann
than reusing another icon - mixing the semantic meaning. it can still be just a copy of that very icon - C. Boemann On July 22, 2012, 3:48 p.m., Friedrich W. H. Kossebau wrote: > > --- > This is an automatically generated e-

Re: [calligra] krita/data/templates: New templates for film workflow

2012-07-22 Thread C. Boemann
On Sunday 22 July 2012 17:50:48 Timothée Giet wrote: > Here are some screenshots showing the issue I'm talking about. > (I could easily reproduce as, I don't know exactly why, it keeps showing > those "1st version" icons on my main install…) because of icon cache just remove it: rm -rf /var/tmp/k

merging the libs-kodocument_split_boud_and_boemann branch

2012-07-23 Thread C. Boemann
Hi all I intend to merge the part+document branch real soon now. It is inevitable that we will have regressions so it's important that we have a long time to catch stuff before the next release. I know this goes against the rule of having a perfect branch before merging, but this branch is so h

Re: How to implement auto-formatting of text (e.g. syntax highlighting of code snippets)?

2012-07-24 Thread C. Boemann
On Tuesday 24 July 2012 03:08:27 Friedrich W. H. Kossebau wrote: > Hi, > > feature, not bug this time :) > > As software developer you often have sourcecode snippets in your documents > or slides. Now, ideally that code snippet has some syntax highlighting > like you are used from your sourcecode

Re: How to implement auto-formatting of text (e.g. syntax highlighting of code snippets)?

2012-07-24 Thread C. Boemann
On Tuesday 24 July 2012 13:30:50 Inge Wallin wrote: > On Tuesday, July 24, 2012 13:12:01 C. Boemann wrote: > > On Tuesday 24 July 2012 03:08:27 Friedrich W. H. Kossebau wrote: > > > Hi, > > > > > > feature, not bug this time :) > > > > > > As

Re: Anybody working on text column separators?

2012-07-25 Thread C. Boemann
On Tuesday 24 July 2012 21:30:12 you wrote: > Another problem for me is the separator: is the style:width of the > added to the gap width, or is the separator drawn onto > the existing gap? > I have not yet completely analysed how LO 3.5 behaves, I find the spec > confusing in any case. > > Where

Re: Review Request: Write recent file list when it is cleared

2012-07-25 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105735/#review16450 --- Ship it! good work! and ok to backport - C. Boemann On

Re: Review Request: fix for losing style:column and style:column-gap on round-trip through Calligra

2012-07-27 Thread C. Boemann
tests that would be preferable, but if not we can ship it as is. - C. Boemann On July 26, 2012, 10:15 a.m., Friedrich W. H. Kossebau wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewb

Re: Review Request: fix for losing style:column and style:column-gap on round-trip through Calligra

2012-07-29 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105736/#review16588 --- Ship it! yes please and 2.5 too - C. Boemann On July 26

Re: Review Request: Add support for table templates

2012-07-31 Thread C. Boemann
t; since we return a style the method should probably be renamed - C. Boemann On July 28, 2012, 4:08 p.m., Gopalakrishna Bhat wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.

Re: Really missing icons in C 2.5

2012-08-03 Thread C. Boemann
On Friday 03 August 2012 06:22:18 Friedrich W. H. Kossebau wrote: > g) Missing Tools > > tool-pagelayout > words/part/pagetool/KWPageToolFactory.cpp:33 > > As the name already tells, a symbol for (the tool for) the basic layout of > a document page/slide > > Seen e.g. in Cal

Re: Review Request: Add support for EPUB 2.0.1

2012-08-04 Thread C. Boemann
this subpart! - C. Boemann On Aug. 4, 2012, 3:11 p.m., Inge Wallin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.

Re: Review Request: Add support for table templates

2012-08-04 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105771/#review16869 --- Ship it! Ship It! - C. Boemann On Aug. 1, 2012, 6:54 p.m

Re: Review Request: Fix for artifacts in the path point handles

2012-08-04 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105834/#review16870 --- i like the fix, and if no one else objects ? - C. Boemann

Re: Review Request: Fix loading of VectorShape and KoUnavailShape.

2012-08-05 Thread C. Boemann
ttp://git.reviewboard.kde.org/r/105873/#comment13219> personally, though your argument makes sense, i think the penalty of less simple code is not worth it but that is just me. - C. Boemann On Aug. 5, 2012, 10:14 a.m., Thorsten Zachmann

Re: Review Request: Fix mixup of canvas and document resource

2012-08-06 Thread C. Boemann
some other tools might no longer get the signals they did before, so ok to commit, but i'd like to hold the backport a day or two - C. Boemann On Aug. 6, 2012, 4:25 p.m., Thorsten Zachmann wrote: > > --- > This is an automa

Re: Release of Calligra 2.5 tonight - Some TODOs

2012-08-10 Thread C. Boemann
On Friday 10 August 2012 13:30:27 Inge Wallin wrote: > Tonight we will announce Calligra 2.5. It should have been yesterday > already but my internet at home had some problems for almost 2 days so I > couldn't do any work on it. But tonight is the night. > > However, I will be offline during early

Re: Review Request: support rendering of separators of text columns

2012-08-10 Thread C. Boemann
m not sure it's not needed, though i can't say where it wouldf be. Scares me though. - C. Boemann On Aug. 10, 2012, 11:52 p.m., Friedrich W. H. Kossebau wrote: > > --- > This is an automatically generated e-mail.

Re: Bump CMake minimum requirement to 2.8.0

2012-08-11 Thread C. Boemann
On Saturday 11 August 2012 10:15:05 Gopalakrishna Bhat wrote: > Hi All, > > Considering that CMake 2.8.0[1] was released 3 years back, I propose that > we update our minimum requirement of cmake to 2.8.0. Even our build > server[2] uses cmake 2.8. > > This bumping is also made important by the fa

Re: Review Request: support rendering of separators of text columns

2012-08-13 Thread C. Boemann
> On Aug. 11, 2012, 12:41 a.m., C. Boemann wrote: > > I like the idea of painting it in the bg shape. I see no reason why it > > should be only a temporary solution. > > > > The size without margin, scares me (mostly with respect to mso files - i > > know wri

Re: Review Request: support rendering of separators of text columns

2012-08-13 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105975/#review17343 --- Ship it! Ship It! - C. Boemann On Aug. 10, 2012, 11:52 p.m

Re: Review Request: support rendering of separators of text columns

2012-08-14 Thread C. Boemann
> On Aug. 11, 2012, 12:41 a.m., C. Boemann wrote: > > I like the idea of painting it in the bg shape. I see no reason why it > > should be only a temporary solution. > > > > The size without margin, scares me (mostly with respect to mso files - i > > know wri

Re: Review Request: rename "import" action to "open as new"

2012-08-14 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106011/#review17375 --- Ship it! It has my vote - C. Boemann On Aug. 14, 2012, 12

Re: icons...

2012-08-14 Thread C. Boemann
On Tuesday 14 August 2012 20:02:41 Friedrich W. H. Kossebau wrote: > Am Montag, 13. August 2012, 20:38:33 schrieb Boudewijn Rempt: > > What I was wondering about with the new icon stuff -- how easy is it to > > extract a list of all the icons we actually use? I mean, currently for > > the windows i

Re: [REVIEW REQUEST] Cleanup of unused or duplicated icons

2012-08-16 Thread C. Boemann
On Thursday 16 August 2012 16:38:55 Dag wrote: > Torsdag den 16. august 2012 16:19:29 Friedrich W. H. Kossebau skrev: > > I would say it is a misinformation, as Calligra depends on kdelibs (4.3), > > so indirectly depends on the Oxygen icon set (from 4.3). And there would > > be lots of "unknown" i

Re: [REVIEW REQUEST] Cleanup of unused or duplicated icons

2012-08-16 Thread C. Boemann
On Thursday 16 August 2012 18:49:22 Friedrich W. H. Kossebau wrote: > Am Donnerstag, 16. August 2012, 18:37:13 schrieb C. Boemann: > > On Thursday 16 August 2012 16:38:55 Dag wrote: > > > Torsdag den 16. august 2012 16:19:29 Friedrich W. H. Kossebau skrev: > >

Re: [REVIEW REQUEST] Cleanup of unused or duplicated icons

2012-08-16 Thread C. Boemann
On Thursday 16 August 2012 19:20:35 Friedrich W. H. Kossebau wrote: > Am Donnerstag, 16. August 2012, 18:55:12 schrieb C. Boemann: > > On Thursday 16 August 2012 18:49:22 Friedrich W. H. Kossebau wrote: > > > Am Donnerstag, 16. August 2012, 18:37:13 schrieb C. Boemann: >

Re: Review Request: remove deprecated and unneeded setting of spacings/margins using KDialog::*Hint()

2012-08-18 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106078/#review17686 --- Ship it! sounds safe enough to me - C. Boemann On Aug. 18

Re: Review Request: use QFormLayout for general document/grid/misc config pages, Karbon interface config page and Sheets Open/Save config page

2012-08-19 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106084/#review17721 --- Ship it! Ship It! - C. Boemann On Aug. 19, 2012, 11:16 a.m

Re: Review Request: add commands for chart operations

2012-08-19 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106070/#review17722 --- >From my point of view it looks good to go. - C. Boemann

Re: warning: overflow in implicit constant conversion in KoShape.cpp

2012-08-19 Thread C. Boemann
On Sunday 19 August 2012 15:40:25 André Wöbbeking wrote: > On Sunday 19 August 2012 11:38:52 Boudewijn Rempt wrote: > > On Saturday 18 August 2012 Aug, André Wöbbeking wrote: > > > P.S.: Please CC me. > > > > Like this? I don't get the warnings myself so I am not sure. > > Don't know whether I ge

Re: calligrawords crashes when building from current git

2012-08-21 Thread C. Boemann
On Tuesday 21 August 2012 20:38:16 Michael Giesler wrote: > Hi, > > I just built the calligra suite as described in > http://community.kde.org/Calligra/Building/Building_Calligra from > up-to-date git. I still could select a template but the application > crashed when clicking "use this template"

Re: calligrawords crashes when building from current git

2012-08-21 Thread C. Boemann
On Tuesday 21 August 2012 20:46:28 Michael Giesler wrote: > Am Dienstag, 21. August 2012, 20:43:54 schrieb C. Boemann: > > On Tuesday 21 August 2012 20:38:16 Michael Giesler wrote: > > > Hi, > > > > > > I just built the calligra suite as described in >

Re: [REVIEW REQUEST] Cleanup of unused or duplicated icons

2012-08-22 Thread C. Boemann
On Wednesday 22 August 2012 21:19:05 Friedrich W. H. Kossebau wrote: > Am Donnerstag, 16. August 2012, 18:55:12 schrieb C. Boemann: > > On Thursday 16 August 2012 18:49:22 Friedrich W. H. Kossebau wrote: > > > Am Donnerstag, 16. August 2012, 18:37:13 schrieb C. Boemann: >

Re: UI idea: Turn the status bar into a docker (or several dockers)

2012-08-23 Thread C. Boemann
On Thursday 23 August 2012 14:31:18 Thomas Pfeiffer wrote: > Hi everyone, > while discussing the best way to implement the word count in the Author UI, > I had an idea for the Calligra UI in general. > Flexibility is one of the key advantages of the Calligra UI. One of the few > UI parts that are c

Re: Review Request: Fix memory leaks

2012-08-24 Thread C. Boemann
ttp://git.reviewboard.kde.org/r/106154/#comment14165> definitely not We just sat it as the default style of the paragraphStyle 10 lines above. Deleting it now would leave a dangling pointer - C. Boemann On Aug. 24, 2012, 4:35 a.m., Thorsten Zachmann

Re: Review Request: Fix memory leaks

2012-08-24 Thread C. Boemann
> On Aug. 24, 2012, 8:14 a.m., C. Boemann wrote: > > libs/textlayout/KoTextShapeData.cpp, line 363 > > <http://git.reviewboard.kde.org/r/106154/diff/1/?file=80614#file80614line363> > > > > definitely not > > > > We just sat it as the

Re: Review Request: Fix memory leaks

2012-08-24 Thread C. Boemann
ttp://git.reviewboard.kde.org/r/106154/#comment14167> i seriously don't get the reason for this change d is a pointer equivalent of d_ptr so why? (except to silence code checkers) - C. Boemann On Aug. 24, 2012, 4:35 a.m., Thorsten Zac

Re: Review Request: Fix memory leaks

2012-08-24 Thread C. Boemann
still good enough - C. Boemann On Aug. 24, 2012, 4:35 a.m., Thorsten Zachmann wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.

Re: Review Request: remove deprecated and unused many-arguments constructor of KoUnitDoubleSpinBox

2012-08-24 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106168/#review17964 --- Ship it! yes it's bad api design - C. Boemann On Au

Re: Review Request: Load fo:margin and fo:padding shorthands before the left/right/top/bottom variants

2012-08-26 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106214/#review18034 --- Ship it! Ship It! - C. Boemann On Aug. 26, 2012, 1:05 p.m

Re: UI idea: Turn the status bar into a docker (or several dockers)

2012-08-29 Thread C. Boemann
On Tuesday 28 August 2012 20:53:11 Thomas Pfeiffer wrote: > On Thursday 23 August 2012 15:05:04 Thomas Pfeiffer wrote: > > On 23.08.2012 14:53, C. Boemann wrote: > > > On Thursday 23 August 2012 14:31:18 Thomas Pfeiffer wrote: > > >> Hi everyone, > > >>

Re: UI idea: Turn the status bar into a docker (or several dockers)

2012-08-29 Thread C. Boemann
them by mistake and rip them > out. Yes I kind of like that. On Wednesday 29 August 2012 11:04:30 Boudewijn Rempt wrote: > On Wed, 29 Aug 2012, C. Boemann wrote: > > Yes it would be possible. > > > > But keep in mind that you cannot move docker without a title bar,

Re: UI idea: Turn the status bar into a docker (or several dockers)

2012-08-31 Thread C. Boemann
On Friday 31 August 2012 10:18:26 Arjen Hiemstra wrote: > On Friday 31 August 2012 09:32:04 Boudewijn Rempt wrote: > > On Thursday 30 August 2012 Aug, Thomas Pfeiffer wrote: > > > I'm starting to think that a general "layout configuration mode" switch > > like in > > > > Amarok may be useful for

Re: UI idea: Turn the status bar into a docker (or several dockers)

2012-08-31 Thread C. Boemann
On Friday 31 August 2012 09:32:04 Boudewijn Rempt wrote: > On Thursday 30 August 2012 Aug, Thomas Pfeiffer wrote: > > I'm starting to think that a general "layout configuration mode" switch > > like in Amarok may be useful for Calligra in general (however it should > > be less hidden then in Amarok

Re: Commence implementation of solution to bug 297623

2012-08-31 Thread C. Boemann
On Friday 31 August 2012 10:48:26 Boudewijn Rempt wrote: > On Friday 31 August 2012 Aug, C. Boemann wrote: > > On Thursday 30 August 2012 00:41:19 JL VT wrote: > > > "Commence implementation of solution to bug 297623" (the bug about our > > > Stroke an

Re: Review Request: Fix the layer docker of karbon to work again after part/document split

2012-08-31 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106210/#review18318 --- Ship it! Looks right to me - C. Boemann On Aug. 26, 2012

Re: Review Request: Better support for hatch background

2012-08-31 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106115/#review18319 --- So is this good enough to ship? - C. Boemann On Aug. 25

Re: Review Request: This increases the flexibility of Statistics Docker Plugin , by allowing it to layout its widgets horizontally when user places it in the bottom area

2012-08-31 Thread C. Boemann
> On Aug. 31, 2012, 6:25 p.m., Thomas Pfeiffer wrote: > > Screenshot: The layout > > > > > > Is it just the screenshot or does the icon have something other than > > the wrench in it near the bottom)? If it does, it's the wrong icon. The one > > I meant only

Re: Review Request: This increases the flexibility of Statistics Docker Plugin , by allowing it to layout its widgets horizontally when user places it in the bottom area

2012-08-31 Thread C. Boemann
thing other > > > than the wrench in it near the bottom)? If it does, it's the wrong > > > icon. The one I meant only has the wrench in it. > > > > C. Boemann wrote: > > it has but it's part of the oxygen style, to show it's a po

Re: Review Request: Add Blob Tool to Calligra

2012-09-01 Thread C. Boemann
--- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106283/ > --- > > (Updated Aug. 30, 2012, 10:59 p.m.) > > > Review request for Calligra, Boudewijn R

Re: Distraction free writing mode

2012-09-10 Thread C. Boemann
On Friday 07 September 2012 11:42:28 Pierre Stirnweiss wrote: > Time to involve the whole devel list I think: > > Here is roughly where we stand in a discussion (between Inge and me, with > some public) about distraction free mode. > I think it is becoming concrete enough and will be of interest f

Re: Distraction free writing mode

2012-09-11 Thread C. Boemann
On Tuesday 11 September 2012 08:56:37 Pierre Stirnweiss wrote: > > > There is perhaps a way, that i started to explore for change tracking > > > without much success (but i didn't pursue this very long). It seems > > > possible to specify additional formatting at layout stage (QTextLayout > > > cla

Re: Autocorrect

2012-09-14 Thread C. Boemann
On Friday 14 September 2012 14:24:15 Yuri Chornoivan wrote: > написане Fri, 14 Sep 2012 14:18:51 +0300, laurent Montel : > > Hi, > > Sorry for cross-posting. > > > > In kmail (4.10) I implemented auto-correction for kmcomposer. So now we > > can autocorrect text when we wrote as in calligraword f

Re: Autocorrect

2012-09-23 Thread C. Boemann
On Monday 24 September 2012 08:18:26 laurent Montel wrote: > Le dimanche 16 septembre 2012 13:01:38 Albert Astals Cid a écrit : > > El Diumenge, 16 de setembre de 2012, a les 09:58:23, laurent Montel va > > > > escriure: > > > Le dimanche 16 septembre 2012 09:25:45 Cyrille Berger Skott a écrit : >

Re: Autocorrect

2012-09-23 Thread C. Boemann
On Monday 24 September 2012 08:18:26 laurent Montel wrote: > Le dimanche 16 septembre 2012 13:01:38 Albert Astals Cid a écrit : > > El Diumenge, 16 de setembre de 2012, a les 09:58:23, laurent Montel va > > > > escriure: > > > Le dimanche 16 septembre 2012 09:25:45 Cyrille Berger Skott a écrit : >

Review Request: changed KoTextBlockData usage

2012-09-24 Thread C. Boemann
usage of Words. And I have several other commits that use it so I'm fairly sure the idea works. Have no tried Stage and in particular the new animation stuff Thanks, C. Boemann ___ calligra-devel mailing list calligra-devel@kde.org https://

Re: Review Request: changed KoTextBlockData usage

2012-09-24 Thread C. Boemann
diff/ Testing --- So far only basic usage of Words. And I have several other commits that use it so I'm fairly sure the idea works. Have no tried Stage and in particular the new animation stuff Thanks, C. Boemann ___ calligra-devel mailing

Re: Review Request: changed KoTextBlockData usage

2012-09-26 Thread C. Boemann
idea works. Have no tried Stage and in particular the new animation stuff Thanks, C. Boemann ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

<    2   3   4   5   6   7   8   9   10   11   >