----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105975/#review17230 -----------------------------------------------------------
I like the idea of painting it in the bg shape. I see no reason why it should be only a temporary solution. The size without margin, scares me (mostly with respect to mso files - i know writer is way too simple, and i read your mail to the odf tc :) ) We need to run a full cs tester session on this. the redundant setting of background you remove. I'm not sure it's not needed, though i can't say where it wouldf be. Scares me though. - C. Boemann On Aug. 10, 2012, 11:52 p.m., Friedrich W. H. Kossebau wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105975/ > ----------------------------------------------------------- > > (Updated Aug. 10, 2012, 11:52 p.m.) > > > Review request for Calligra and C. Boemann. > > > Description > ------- > > I had the idea to render the column separators using the background shapes. > What do you think? Would that be alright at least as a temporary solution? > > Patch also fixes page background ignoring the margins. At least LO/AOO does > not paint the background in the margin. Sadly the attribute > "draw:background-size" is not available for <style:page-layout-properties>, > only for <style:drawing-page-properties>. Filed a complain on the > office-comment mailinglist. > > And patch removes redundant setting of background to frame shapes in > KWTextFrameSet::setPageStyle(...). > > Okay to backport to 2.5? > > > Diffs > ----- > > words/part/frames/KWFrameLayout.cpp d9675b0 > words/part/frames/KWTextFrameSet.cpp 7afa7bf > > Diff: http://git.reviewboard.kde.org/r/105975/diff/ > > > Testing > ------- > > > Thanks, > > Friedrich W. H. Kossebau > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
