----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105284/#review15866 -----------------------------------------------------------
Anyone having any objections left? - C. Boemann On June 25, 2012, 12:59 a.m., Friedrich W. H. Kossebau wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105284/ > ----------------------------------------------------------- > > (Updated June 25, 2012, 12:59 a.m.) > > > Review request for Calligra. > > > Description > ------- > > Fixes all those icon names referencing to non-existing icons for which there > is a proper icon in Oxygen 4.3.5 or coming with Calligra itself (IMHO :)) > > Also removes all arrow icons from plugins/pathshapes/pics, because they are > either not used or can be replaced by draw-arrow-* icons from Oxygen icons. > > Okay to commit both to master and 2.5? > > > Dealt entries from the report of the koIcon script, commented how I propose > to solve it: > > arrow-down-calligra > plugins/pathshapes/enhancedpath/EnhancedPathShapeFactory.cpp:298 > arrow-up-calligra > plugins/pathshapes/enhancedpath/EnhancedPathShapeFactory.cpp:265 > arrow-left-calligra > plugins/pathshapes/enhancedpath/EnhancedPathShapeFactory.cpp:232 > > Use the draw-arrow-* icons from Oxygen. > > star > plugins/pathshapes/star/StarShapeFactory.cpp:40 > > 14_layer_novisible > libs/kopageapp/KoPADocumentModel.cpp:314 > 14_layer_visible > libs/kopageapp/KoPADocumentModel.cpp:314 > > Oxygen from 4.3.5 has layer-visible-on and layer-visible-off icons, so use > them. > > fontsizeup > sheets/ui/CellToolBase.cpp:415 > fontsizedown > sheets/ui/CellToolBase.cpp:421 > > There is also no icon in Kate/KWrite for these setting all text to > lower/upper-case, so for now just use no icon here as well. > > text > plugins/artistictextshape/ArtisticTextShapeFactory.cpp:33 > > Solved by reusing x-shape-text > > open > plugins/pictureshape/PictureTool.cpp:110 > plugins/staging/templateshape/TemplateTool.cpp:90 > plugins/vectorshape/VectorTool.cpp:75 > > Solved by changing to document-open > > > Diffs > ----- > > kexi/plugins/relations/kexirelationhandler.desktop b0c9c0d > libs/kopageapp/KoPADocumentModel.cpp 69feb88 > libs/widgets/pics/ox22-actions-zoom-draw.png PRE-CREATION > libs/widgets/pics/ox22-actions-zoom-select.png PRE-CREATION > plugins/artistictextshape/ArtisticTextShapeFactory.cpp 2438b20 > plugins/pathshapes/enhancedpath/EnhancedPathShapeFactory.cpp d820c43 > plugins/pathshapes/pics/hi22-action-arrow-down.png c7e4dec > plugins/pathshapes/pics/hi22-action-arrow-left-down.png d2443c8 > plugins/pathshapes/pics/hi22-action-arrow-left-up.png 20afbd4 > plugins/pathshapes/pics/hi22-action-arrow-left.png 2aff72f > plugins/pathshapes/pics/hi22-action-arrow-right-down.png f165711 > plugins/pathshapes/pics/hi22-action-arrow-right-up.png f095b9a > plugins/pathshapes/pics/hi22-action-arrow-up.png a1f66da > plugins/pathshapes/pics/ox22-action-arrow-right-calligra.png dbb9e5a > plugins/pathshapes/star/StarShapeFactory.cpp e6a9c6d > plugins/pictureshape/PictureTool.cpp bf15751 > plugins/staging/templateshape/TemplateTool.cpp 6373aa2 > plugins/textshape/pics/ox22-actions-edit-table-cell-merge.png PRE-CREATION > plugins/textshape/pics/ox22-actions-edit-table-cell-split.png PRE-CREATION > plugins/vectorshape/VectorTool.cpp 79742fd > sheets/ui/CellToolBase.cpp 89b79f9 > > Diff: http://git.reviewboard.kde.org/r/105284/diff/ > > > Testing > ------- > > > Thanks, > > Friedrich W. H. Kossebau > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
