Review Request: Cleanup KoDocument

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104992/ --- Review request for Calligra. Description --- This patch combines seve

Re: Review Request: Cleanup KoDocument

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104992/#review13964 --- Ship it! Looks like a good start. The only thing I didn't unde

Re: Review Request: Cleanup KoDocument

> On May 19, 2012, 9:36 a.m., Inge Wallin wrote: > > krita/data/kritarc, line 2 > > > > > > Is this relevant to this patch? yes: krita used the wantExportConfirmation() api to tell kodocument not to whine about data

Re: Review Request: Cleanup KoDocument

> On May 19, 2012, 9:36 a.m., Inge Wallin wrote: > > krita/data/kritarc, line 2 > > > > > > Is this relevant to this patch? > > Boudewijn Rempt wrote: > yes: krita used the wantExportConfirmation() api to tell ko

Re: Review Request: Cleanup KoDocument

> On May 19, 2012, 9:36 a.m., Inge Wallin wrote: > > krita/data/kritarc, line 2 > > > > > > Is this relevant to this patch? > > Boudewijn Rempt wrote: > yes: krita used the wantExportConfirmation() api to tell ko

Review Request: Delayed Search: Give the user a chance to enter the whole word before begining search

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104996/ --- Review request for Calligra. Description --- Diffs - libs/mai

Re: Review Request: Delayed Search: Give the user a chance to enter the whole word before begining search

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104996/ --- (Updated May 19, 2012, 3:45 p.m.) Review request for Calligra. Changes -

Re: Review Request: Delayed Search: Give the user a chance to enter the whole word before begining search

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104996/#review13977 --- I did not yet test it. But from looking at it it seems to look

Re: Review Request: Delayed Search: Give the user a chance to enter the whole word before begining search

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104996/#review13978 --- i'm not sure. wouldn't it be better to be able to abort the sea

Re: Review Request: Delayed Search: Give the user a chance to enter the whole word before begining search

> On May 19, 2012, 4:13 p.m., C. Boemann wrote: > > i'm not sure. wouldn't it be better to be able to abort the search? and > > restart it when the user types the next char Sure it would be better. The problem with this approach is that we use QTextDocument's find method to search the text and

Review Request: Add text:list-id attribute while loading and saving numbered paragraph

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104997/ --- Review request for Calligra and Thorsten Zachmann. Description --- Wh

Re: Review Request: Delayed Search: Give the user a chance to enter the whole word before begining search

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104996/#review13983 --- Ah okay - yes I see the problem. Short of making a thread (whic

Required attributes for text:numbered-paragraph

Hi, When trying to validate the document attached to https://bugs.kde.org/show_bug.cgi?id=299639 , the schema validator throws the following error error: element "text:numbered-paragraph" missing required attributes "text:continue-numbering" and "text:start-value" The ODF spec says that text:con

Re: Review Request: Delayed Search: Give the user a chance to enter the whole word before begining search

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104996/#review13985 --- "The problem with this approach is that we use QTextDocument's

Review Request: Changed KoReport to use QGraphicsView instead of QWidget

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104998/ --- Review request for Calligra, Jarosław Staniek and Dag Andersen. Descriptio

Re: Review Request: Changed KoReport to use QGraphicsView instead of QWidget

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104998/#review13989 --- kexi/plugins/reports/kexireportview.cpp

Re: Review Request: Changed KoReport to use QGraphicsView instead of QWidget

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104998/#review13990 --- Ship it! Good work! Please try to fix the two issues I mention

Re: Review Request: Delayed Search: Give the user a chance to enter the whole word before begining search

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104996/ --- (Updated May 20, 2012, 2:08 a.m.) Review request for Calligra. Changes -

Re: Review Request: Delayed Search: Give the user a chance to enter the whole word before begining search

> On May 19, 2012, 7:09 p.m., Arjen Hiemstra wrote: > > libs/main/KoFindToolbar.cpp, lines 273-274 > > > > > > Since you're using a single shot timer anyway, there is no need to call > > stop(). There might be a s

Re: Review Request: Saving and Loading of Painting Assistants in Krita

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104993/#review13992 --- krita/ui/kis_doc2.h