----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104998/ -----------------------------------------------------------
Review request for Calligra, Jarosław Staniek and Dag Andersen. Description ------- Changed KoReport to use QGraphicsView instead of QWidget Use QGraphicsView and QGraphicsItem for the report page view instead of painting a custom QWidget. This will make it easier to use in QML, and also happens to look nicer. Diffs ----- kexi/plugins/reports/kexireportview.h 952e0dae57ac2c4f86bfcc9da40dbb6ffeda0746 kexi/plugins/reports/kexireportview.cpp ccdf3f91453ca26a00ae8ac3f0976cac7c04c72f libs/koreport/renderer/KoReportPage.h 65bf612d4bb02320a6e757b32fb2ce1e254f44fd libs/koreport/renderer/KoReportPage.cpp e0fafb6a10c07b31bdb03e08bf162f85053ea2ad Diff: http://git.reviewboard.kde.org/r/104998/diff/ Testing ------- Tested in Kexi using existing reports, but breaks the build of Plan as it will need a new report view widget based on QGraphicsView. I will add this later, the same as the Kexi version. Thanks, Adam Pigg
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel