> On May 19, 2012, 4:13 p.m., C. Boemann wrote: > > i'm not sure. wouldn't it be better to be able to abort the search? and > > restart it when the user types the next char
Sure it would be better. The problem with this approach is that we use QTextDocument's find method to search the text and we cannot interrupt when this method is called(can we?) - Gopalakrishna ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104996/#review13978 ----------------------------------------------------------- On May 19, 2012, 3:45 p.m., Gopalakrishna Bhat wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104996/ > ----------------------------------------------------------- > > (Updated May 19, 2012, 3:45 p.m.) > > > Review request for Calligra. > > > Description > ------- > > When we try to search for a text that is most common in a large document the > ui used to hang when the first letter was entered in the search box i.e. hung > until the search for the first letter in the whole document is over. > > Particular scenario that I have in mind: > > 1) Open the ODF 1.2 spec document in Words > 2) Try searching for the word "the" in the document > 3) As soon as the letter 't' is entered in the search field the user has to > wait for the search to complete before he can see the other two letters "he" > appear. > > As a solution to the above scenario, this patch introduces a delay of 1s > after the last key has been keyed before begining the search. > > > Diffs > ----- > > libs/main/KoFindToolbar.h 9c44694 > libs/main/KoFindToolbar.cpp 0199c6a > > Diff: http://git.reviewboard.kde.org/r/104996/diff/ > > > Testing > ------- > > > Thanks, > > Gopalakrishna Bhat > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
