Re: Review Request: read XML in the rigth way. ie. \n has 5 nodes, not 3

2011-08-06 Thread Jaime Torres Amate
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101857/ --- (Updated Aug. 6, 2011, 10:56 a.m.) Review request for Calligra. Summary

Re: Review Request: read XML in the rigth way. ie. \n has 5 nodes, not 3

2011-08-06 Thread Jaime Torres Amate
> On None, Thorsten Zachmann wrote: > > Finally I was able to test the patch. I used cstester and a testset of 1800 > > documents. When testing with the patch about 1000 of the documents changed > > their visual representation. > > > > I found the following problems: > > - bullets are suddenly

Re: Review Request: read XML in the rigth way. ie. \n has 5 nodes, not 3

2011-08-06 Thread Boudewijn Rempt
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101857/#review5430 --- Hm... can you mail me the output of the failing tests? - Boudew

Review Request: Styled separators in KoToolBox

2011-08-06 Thread Peter Simonsson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102233/ --- Review request for Calligra. Summary --- Use the style to draw separa

Re: Review Request: Styled separators in KoToolBox

2011-08-06 Thread Casper Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102233/#review5434 --- has my vote 100% - Casper On Aug. 6, 2011, 2:47 p.m., Peter S

Re: Review Request: Nepomuk backend support for tagging in krita

2011-08-06 Thread Boudewijn Rempt
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102217/#review5437 --- Ship it! Well, it's up to Sven, I think, but from me: ship it!

Re: Review Request: read XML in the rigth way. ie. \n has 5 nodes, not 3

2011-08-06 Thread Sebastian Sauer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101857/#review5440 --- 1. Please test loading with ODT/ODS/ODP files produced with Word

Re: Review Request: read XML in the rigth way. ie. \n has 5 nodes, not 3

2011-08-06 Thread Sebastian Sauer
> On Aug. 6, 2011, 4:35 p.m., Sebastian Sauer wrote: > > 1. Please test loading with ODT/ODS/ODP files produced with > > Words/Tables/Stage. OO.org does save all the content in one line and > > therefore has no additional spaces in front. For me it looks like those > > produced documents would

Re: Review Request: read XML in the rigth way. ie. \n has 5 nodes, not 3

2011-08-06 Thread Sebastian Sauer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101857/#review5443 --- Thinking a bit more in my opinion we should not change how white

Re: Review Request: Nepomuk backend support for tagging in krita

2011-08-06 Thread Sven Langkamp
> On Aug. 6, 2011, 3:23 p.m., Boudewijn Rempt wrote: > > Well, it's up to Sven, I think, but from me: ship it! I can't test this version as it needs KDE 4.6.5 at least, but the last version was good already. - Sven --- This is an autom

Review Request: Clean up the tool options widgets

2011-08-06 Thread Peter Simonsson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102234/ --- Review request for Calligra. Summary --- KarbonCalligraphyOptionWidge

Re: Review Request: Clean up the tool options widgets

2011-08-06 Thread Casper Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102234/#review5453 --- fine with me - Casper On Aug. 6, 2011, 6:23 p.m., Peter Simon

Re: Review Request: read XML in the rigth way. ie. \n has 5 nodes, not 3

2011-08-06 Thread Jan Hambrecht
> On Aug. 6, 2011, 5:04 p.m., Sebastian Sauer wrote: > > Thinking a bit more in my opinion we should not change how whitespaces are > > handled atm if there is no good reason for it (like a performance-boost or > > ...). The "2.10 White Space Handling" section from > > http://www.w3.org/TR/REC

Re: Review Request: GSoC, Stage: Add a tabbar to switch between view modes

2011-08-06 Thread Thorsten Zachmann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102198/#review5462 --- Hello Paul, sorry that it took so long until I tested it. I li

Re: Review Request: Clean up the tool options widgets

2011-08-06 Thread Thorsten Zachmann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102234/#review5463 --- Ship it! Looks good. - Thorsten On Aug. 6, 2011, 6:23 p.m.,

Re: Review Request: Styled separators in KoToolBox

2011-08-06 Thread Thorsten Zachmann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102233/#review5464 --- Ship it! Looks good - Thorsten On Aug. 6, 2011, 2:47 p.m., P

Re: Review Request: Refactor kotext/KoTableCellStyle

2011-08-06 Thread Thorsten Zachmann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102200/#review5465 --- Please close the review request as it is committed already. - T

Re: Review Request: read XML in the rigth way. ie. \n has 5 nodes, not 3

2011-08-06 Thread Thorsten Zachmann
> On Aug. 6, 2011, 5:04 p.m., Sebastian Sauer wrote: > > Thinking a bit more in my opinion we should not change how whitespaces are > > handled atm if there is no good reason for it (like a performance-boost or > > ...). The "2.10 White Space Handling" section from > > http://www.w3.org/TR/REC

Re: Review Request: Styled separators in KoToolBox

2011-08-06 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102233/#review5469 --- This review has been submitted with commit 1608aa60b7a16c6b3614

Re: Review Request: Clean up the tool options widgets

2011-08-06 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102234/#review5468 --- This review has been submitted with commit bcf5d1673e639163c6a6