----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102234/#review5463 -----------------------------------------------------------
Ship it! Looks good. - Thorsten On Aug. 6, 2011, 6:23 p.m., Peter Simonsson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102234/ > ----------------------------------------------------------- > > (Updated Aug. 6, 2011, 6:23 p.m.) > > > Review request for Calligra. > > > Summary > ------- > > KarbonCalligraphyOptionWidget: > KarbonPencilTool: > KoZoomToolWidget: > TreeShapeConfigWidget: > Add stretch to make it look good on big screens > > KoToolBase: > Don't add a generic window title in the default implementation of > createOptionWidgets as it only duplicates what the docker header says > > KoPathTool: > DefaultTool: > Don't first create snapguide widget and set a window title and then create a > new snapguide widget and add that to the list of widgets to return > > KoToolDocker: > Handle empty window titles while creating the layout > > ReviewTool: > Don't try to set a layout on a widget that already has a layout > > > Diffs > ----- > > karbon/plugins/tools/CalligraphyTool/KarbonCalligraphyOptionWidget.cpp > 0ce337d > karbon/plugins/tools/KarbonPencilTool.cpp 86c8fa5 > libs/flake/KoToolBase.cpp 77c039d > libs/flake/tools/KoPathTool.cpp 361324e > libs/flake/tools/KoZoomToolWidget.ui ed3ba73 > libs/main/KoToolDocker.cpp 78c881a > plugins/defaultTools/defaulttool/DefaultTool.cpp f54ddd3 > plugins/textshape/ReviewTool.cpp 8a1c88c > plugins/treeshape/TreeShapeConfigWidget.ui e7e367f > > Diff: http://git.reviewboard.kde.org/r/102234/diff > > > Testing > ------- > > > Thanks, > > Peter > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
