Re: Review Request: Some dead code I do not know how to handle

2011-07-01 Thread Jaime Torres Amate
> On July 1, 2011, 9:51 a.m., Matus Uzak wrote: > > filters/words/msword-odf/wv2/src/ustring.cpp, line 71 > > > > > > According to the corresponding IEEE standard: If x is NAN, then (x == > > x) == false. Can you p

Re: Review Request: Some dead code I do not know how to handle

2011-07-01 Thread Matus Uzak
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101803/#review4290 --- filters/words/msword-odf/wv2/src/ustring.cpp

Re: Review Request: Some dead code I do not know how to handle

2011-06-30 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101803/#review4279 --- This review has been submitted with commit 66c0cb7887445ee99245

Re: Review Request: Some dead code I do not know how to handle

2011-06-30 Thread Cyrille Berger Skott
> On June 30, 2011, 6:38 a.m., Thorsten Zachmann wrote: > > krita/plugins/filters/blur/kis_blur_filter.cpp, line 81 > > > > > > Does that give the same result? > > If not is this chnage correct. Krita guys any id

Re: Review Request: Some dead code I do not know how to handle

2011-06-30 Thread Boudewijn Rempt
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101803/#review4272 --- Ship it! I'm fine with the Krita changes. - Boudewijn On Jun

Re: Review Request: Some dead code I do not know how to handle

2011-06-30 Thread Elvis Stansvik
> On June 30, 2011, 6:38 a.m., Thorsten Zachmann wrote: > > krita/plugins/filters/blur/kis_blur_filter.cpp, line 81 > > > > > > Does that give the same result? > > If not is this chnage correct. Krita guys any id

Re: Review Request: Some dead code I do not know how to handle

2011-06-30 Thread Elvis Stansvik
> On June 30, 2011, 6:38 a.m., Thorsten Zachmann wrote: > > krita/plugins/filters/blur/kis_blur_filter.cpp, line 81 > > > > > > Does that give the same result? > > If not is this chnage correct. Krita guys any id

Re: Review Request: Some dead code I do not know how to handle

2011-06-29 Thread Thorsten Zachmann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101803/#review4269 --- The krita change should be looked at by a krita guy the other ch

Re: Review Request: Some dead code I do not know how to handle

2011-06-29 Thread Sebastian Sauer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101803/#review4267 --- The kotext-part looks great. - Sebastian On June 29, 2011, 8:

Review Request: Some dead code I do not know how to handle

2011-06-29 Thread Jaime Torres Amate
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101803/ --- Review request for Calligra. Summary --- the changes are: (easy) 1. i