Re: Review Request: Fix to insert document information in InfoVariable Plugin

2011-04-19 Thread Boudewijn Rempt
On Tuesday 19 April 2011 Apr, Sri Ram wrote: > > > On April 19, 2011, 6:25 a.m., Thorsten Zachmann wrote: > > > Looks good. Please commit if you have a git account already. If not let > > > me know and I can commit it for you. > > > > > > How about adding support for all types of variable the I

Re: Review Request: Fix to insert document information in InfoVariable Plugin

2011-04-18 Thread Sri Ram
> On April 19, 2011, 6:25 a.m., Thorsten Zachmann wrote: > > Looks good. Please commit if you have a git account already. If not let me > > know and I can commit it for you. > > > > How about adding support for all types of variable the InfoVariable > > supports? Thanks, I don't have git acc

Re: Review Request: Fix to insert document information in InfoVariable Plugin

2011-04-18 Thread Thorsten Zachmann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101146/#review2747 --- Ship it! Looks good. Please commit if you have a git account al

Re: Review Request: Fix to insert document information in InfoVariable Plugin

2011-04-18 Thread Sri Ram
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101146/ --- (Updated April 18, 2011, 8:03 p.m.) Review request for Calligra. Changes

Re: Review Request: Fix to insert document information in InfoVariable Plugin

2011-04-18 Thread Sri Ram
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101146/ --- (Updated April 18, 2011, 7:45 p.m.) Review request for Calligra. Changes

Re: Review Request: Fix to insert document information in InfoVariable Plugin

2011-04-18 Thread Sri Ram
> On April 17, 2011, 11 a.m., Thorsten Zachmann wrote: > > plugins/variables/InfoVariable.cpp, line 111 > > > > > > I think it is much clearer to use the code as it was before as the > > default value will be 0 if

Re: Review Request: Fix to insert document information in InfoVariable Plugin

2011-04-17 Thread Thorsten Zachmann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101146/#review2697 --- plugins/variables/InfoVariable.cpp

Review Request: Fix to insert document information in InfoVariable Plugin

2011-04-17 Thread Sri Ram
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101146/ --- Review request for Calligra. Summary --- Fixing InfoVariable plugin t