> On April 17, 2011, 11 a.m., Thorsten Zachmann wrote: > > plugins/variables/InfoVariable.cpp, line 111 > > <http://git.reviewboard.kde.org/r/101146/diff/1/?file=14673#file14673line111> > > > > I think it is much clearer to use the code as it was before as the > > default value will be 0 if it is not found.
ok, I ll revert it to default. > On April 17, 2011, 11 a.m., Thorsten Zachmann wrote: > > plugins/variables/InfoVariable.cpp, lines 63-76 > > <http://git.reviewboard.kde.org/r/101146/diff/1/?file=14673#file14673line63> > > > > This change is not needed if the values are passed as suggested in the > > factory. As per your suggestion, i will use enum values to make it simple. > On April 17, 2011, 11 a.m., Thorsten Zachmann wrote: > > plugins/variables/InfoVariableFactory.cpp, line 39 > > <http://git.reviewboard.kde.org/r/101146/diff/1/?file=14674#file14674line39> > > > > Please use the value of the enum here: In this case use > > KoInlineObject::AuthorName instead of 1. > > Please add a blank after , > > This is also true for the other variables. I will update this in my patch. - Sri ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101146/#review2697 ----------------------------------------------------------- On April 17, 2011, 10:23 a.m., Sri Ram wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101146/ > ----------------------------------------------------------- > > (Updated April 17, 2011, 10:23 a.m.) > > > Review request for Calligra. > > > Summary > ------- > > Fixing InfoVariable plugin to insert essential document information (Author > Name, Document Title and Document Subject) into documents. > > > Diffs > ----- > > plugins/variables/InfoVariable.cpp 9f3f2eb > plugins/variables/InfoVariableFactory.cpp 6b39af1 > > Diff: http://git.reviewboard.kde.org/r/101146/diff > > > Testing > ------- > > > Thanks, > > Sri > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
