> On April 19, 2011, 6:25 a.m., Thorsten Zachmann wrote: > > Looks good. Please commit if you have a git account already. If not let me > > know and I can commit it for you. > > > > How about adding support for all types of variable the InfoVariable > > supports?
Thanks, I don't have git account. So, you can commit it. I guess it is not good to add all types of InfoVariables like this. So we need to do it in a different way. - Sri ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101146/#review2747 ----------------------------------------------------------- On April 18, 2011, 8:03 p.m., Sri Ram wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101146/ > ----------------------------------------------------------- > > (Updated April 18, 2011, 8:03 p.m.) > > > Review request for Calligra. > > > Summary > ------- > > Fixing InfoVariable plugin to insert essential document information (Author > Name, Document Title and Document Subject) into documents. > > > Diffs > ----- > > plugins/variables/InfoVariable.cpp 9f3f2eb > plugins/variables/InfoVariableFactory.cpp 6b39af1 > > Diff: http://git.reviewboard.kde.org/r/101146/diff > > > Testing > ------- > > > Thanks, > > Sri > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
