Re: Review Request: Bibliography database UI

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105240/#review15381 --- Ship it! Nice work!!! Before merging remove the search option

Re: Review Request: Bibliography database UI

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105240/ --- (Updated June 29, 2012, 9:46 p.m.) Review request for Calligra. Changes

Re: Review Request: Bibliography database UI

> On June 23, 2012, 7:22 p.m., Gopalakrishna Bhat wrote: > > plugins/textshape/dialogs/EditFiltersDialog.cpp, lines 46-60 > > > > > > Instead of hard coding value 62 use insertWidget. If the pre-operator > > is not

Re: Review Request: Bibliography database UI

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105240/ --- (Updated June 24, 2012, 9:51 p.m.) Review request for Calligra. Changes

Re: Review Request: Bibliography database UI

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105240/#review15049 --- I tested your branch today. First of all thanks for the nice wo

Re: Review Request: Bibliography database UI

On 16 June 2012 00:43, Smit Patel wrote: > > > On Thu, Jun 14, 2012 at 9:53 AM, Jaroslaw Staniek wrote: >> >> I didn't read the code, but do you use kexidb for the db creation and >> data access? > > No. >> >> I'm asking because of reuse principle. > > I saw the same thing in LO Base and LO Write

Re: Review Request: Bibliography database UI

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105240/ --- (Updated June 16, 2012, 4:28 p.m.) Review request for Calligra. Changes

Re: Review Request: Bibliography database UI

> On June 13, 2012, 5:44 p.m., Gopalakrishna Bhat wrote: > > plugins/chartshape/TODO, line 73 > > > > > > Are u sure these are ur changes? I didn't change any of these. It must have been my mistake when creating dif

Re: Review Request: Bibliography database UI

I didn't read the code, but do you use kexidb for the db creation and data access? I'm asking because of reuse principle. I can help with that for 2.6. On 14/06/2012, Gopalakrishna Bhat wrote: > > >> On June 13, 2012, 9:50 p.m., C. Boemann wrote: >> > i've not tested it either, but to me it sound

Re: Review Request: Bibliography database UI

> On June 13, 2012, 9:50 p.m., C. Boemann wrote: > > i've not tested it either, but to me it sounds like it's 'just' the basic > > database ui. We still miss any kind of connection to engines. Therefore I > > wonder if it has any values to users right now? And if not then I don't > > think we

Re: Review Request: Bibliography database UI

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105240/#review14710 --- i've not tested it either, but to me it sounds like it's 'just'

Re: Review Request: Bibliography database UI

> On June 13, 2012, 5:44 p.m., Gopalakrishna Bhat wrote: > > plugins/textshape/dialogs/EditFiltersDialog.cpp, line 132 > > > > > > I do not see that u use m_filters anywhere other than the constructor. > > Hence th

Re: Review Request: Bibliography database UI

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105240/#review14699 --- I have not tried out this patch. Will try out this weekend. The

Review Request: Bibliography database UI

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105240/ --- Review request for Calligra. Description --- Bibliography database UI