> On June 23, 2012, 7:22 p.m., Gopalakrishna Bhat wrote: > > plugins/textshape/dialogs/EditFiltersDialog.cpp, lines 46-60 > > <http://git.reviewboard.kde.org/r/105240/diff/2/?file=68049#file68049line46> > > > > Instead of hard coding value 62 use insertWidget. If the pre-operator > > is not there there will be no widget in the first column. > > if (hasPreCondition) { > > m_layout->insertWidget(0, m_preCond); > > } > > > > m_layout->insertWidget(1, m_field); > > ...so on
Yes. But that makes other widget sizes different than usual because of QHBoxLayout. Add spacing will hide widget as well as keep uniform sized widget as on the next filter. > On June 23, 2012, 7:22 p.m., Gopalakrishna Bhat wrote: > > plugins/textshape/dialogs/BibliographyDb.cpp, line 114 > > <http://git.reviewboard.kde.org/r/105240/diff/1/?file=67555#file67555line114> > > > > hmm...I'm not sure you got my comment here. All the columns I see here > > are of type TEXT which should make my comment valid. Feel free to ping me > > on IRC if you want clarification on any of my commments The only attribute "identifier" is "NOT NULL UNIQUE". And id is "INTEGER PRIMARY KEY" > On June 23, 2012, 7:22 p.m., Gopalakrishna Bhat wrote: > > libs/kotext/KoInlineCite.cpp, line 703 > > <http://git.reviewboard.kde.org/r/105240/diff/1/?file=67544#file67544line703> > > > > I did not get what are you refering to when you say that > > KoXmlWriter::addAttribute doesn't accept attribute name in QString? My > > comment was on using loop insted of all these if conditions - Smit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105240/#review15049 ----------------------------------------------------------- On June 24, 2012, 9:51 p.m., Smit Patel wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105240/ > ----------------------------------------------------------- > > (Updated June 24, 2012, 9:51 p.m.) > > > Review request for Calligra. > > > Description > ------- > > Bibliography database UI. > 1) create/load/save/edit table saved in SQLite file > 2) Search in database > 3) Apply custom filters to database > 4) Integrated this UI with existing insert citation for edit/create cite in > database > > > Diffs > ----- > > plugins/textshape/dialogs/BibliographyDatabaseWindow.h PRE-CREATION > plugins/textshape/dialogs/BibliographyDatabaseWindow.cpp PRE-CREATION > plugins/textshape/dialogs/BibliographyDb.h PRE-CREATION > plugins/textshape/dialogs/BibliographyDb.cpp PRE-CREATION > plugins/textshape/dialogs/EditFiltersDialog.h PRE-CREATION > plugins/textshape/dialogs/EditFiltersDialog.cpp PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/105240/diff/ > > > Testing > ------- > > > Thanks, > > Smit Patel > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
