> On June 13, 2012, 5:44 p.m., Gopalakrishna Bhat wrote: > > plugins/chartshape/TODO, line 73 > > <http://git.reviewboard.kde.org/r/105240/diff/1/?file=67547#file67547line73> > > > > Are u sure these are ur changes?
I didn't change any of these. It must have been my mistake when creating diff. I'll keep this in mind whenever I merge this in master. > On June 13, 2012, 5:44 p.m., Gopalakrishna Bhat wrote: > > libs/kotext/KoInlineCite.cpp, line 703 > > <http://git.reviewboard.kde.org/r/105240/diff/1/?file=67544#file67544line703> > > > > Instead of all these if conditions we can use looping here. We can > > discuss about this on IRC KoXmlWriter::addAttribute doesn't accept attribute name in QString. > On June 13, 2012, 5:44 p.m., Gopalakrishna Bhat wrote: > > plugins/textshape/dialogs/BibliographyDb.cpp, line 114 > > <http://git.reviewboard.kde.org/r/105240/diff/1/?file=67555#file67555line114> > > > > Cant we use BibliographyDb::dbFields and build this string through > > looping? ID, Identifier and all other fields have different constraints in database. - Smit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105240/#review14699 ----------------------------------------------------------- On June 13, 2012, 12:12 p.m., Smit Patel wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105240/ > ----------------------------------------------------------- > > (Updated June 13, 2012, 12:12 p.m.) > > > Review request for Calligra. > > > Description > ------- > > Bibliography database UI. > 1) create/load/save/edit table saved in SQLite file > 2) Search in database > 3) Apply custom filters to database > 4) Integrated this UI with existing insert citation for edit/create cite in > database > > > Diffs > ----- > > CMakeLists.txt 33cdabb > libs/kotext/BibliographyGenerator.cpp 15808cb > libs/kotext/KoInlineCite.h df4a2e9 > libs/kotext/KoInlineCite.cpp 6d949da > libs/kotext/KoInlineTextObjectManager.cpp e82664d > libs/kotext/KoTextEditor.cpp b3e16ba > plugins/chartshape/TODO 94efb62 > plugins/textshape/CMakeLists.txt 6253323 > plugins/textshape/ReferencesTool.h 491b933 > plugins/textshape/ReferencesTool.cpp 564b658 > plugins/textshape/dialogs/BibliographyDatabaseWindow.h PRE-CREATION > plugins/textshape/dialogs/BibliographyDatabaseWindow.cpp PRE-CREATION > plugins/textshape/dialogs/BibliographyDatabaseWindow.ui PRE-CREATION > plugins/textshape/dialogs/BibliographyDb.h PRE-CREATION > plugins/textshape/dialogs/BibliographyDb.cpp PRE-CREATION > plugins/textshape/dialogs/CitationInsertionDialog.h f5eac0b6 > plugins/textshape/dialogs/CitationInsertionDialog.cpp 14f9429 > plugins/textshape/dialogs/CitationInsertionDialog.ui 8f10f64 > plugins/textshape/dialogs/EditFiltersDialog.h PRE-CREATION > plugins/textshape/dialogs/EditFiltersDialog.cpp PRE-CREATION > plugins/textshape/dialogs/InsertCitationDialog.h PRE-CREATION > plugins/textshape/dialogs/InsertCitationDialog.cpp PRE-CREATION > plugins/textshape/dialogs/InsertCitationDialog.ui PRE-CREATION > plugins/textshape/dialogs/SimpleCitationBibliographyWidget.cpp 2d1c1de > plugins/textshape/dialogs/SimpleCitationBibliographyWidget.ui 55699bb > > Diff: http://git.reviewboard.kde.org/r/105240/diff/ > > > Testing > ------- > > > Thanks, > > Smit Patel > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
