Re: Review Request: Added Footnotes/Endnotes in References Tool

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102552/#review7861 --- please close this review - C. Boemann On Sept. 24, 2011, 1:28

Re: Review Request: Added Footnotes/Endnotes in References Tool

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102552/#review6858 --- When I add a review in the UI I get a crash with the following b

Re: Review Request: Added Footnotes/Endnotes in References Tool

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102552/#review6857 --- I have run cstester and this is what I have found There as foot

Re: Review Request: Added Footnotes/Endnotes in References Tool

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102552/ --- (Updated Sept. 24, 2011, 1:28 p.m.) Review request for Calligra. Changes

Re: Review Request: Added Footnotes/Endnotes in References Tool

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102552/#review6753 --- When testing with cstester I found that a lot of the test docume

Re: Review Request: Added Footnotes/Endnotes in References Tool

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102552/#review6741 --- libs/kotext/KoInlineNote.cpp

Re: Review Request: Added Footnotes/Endnotes in References Tool

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102552/#review6727 --- I have seen some style issues. Please fix them in all your chang

Re: Review Request: Added Footnotes/Endnotes in References Tool

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102552/ --- (Updated Sept. 22, 2011, 12:29 p.m.) Review request for Calligra. Change

Re: Review Request: Added Footnotes/Endnotes in References Tool

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102552/ --- (Updated Sept. 18, 2011, 7:15 p.m.) Review request for Calligra. Changes

Re: Review Request: Added Footnotes/Endnotes in References Tool

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102552/#review6614 --- libs/kotext/KoInlineNote.h

Re: Review Request: Added Footnotes/Endnotes in References Tool

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102552/ --- (Updated Sept. 18, 2011, 7:02 a.m.) Review request for Calligra. Changes

Re: Review Request: Added Footnotes/Endnotes in References Tool

> On Sept. 9, 2011, 3:25 a.m., Thorsten Zachmann wrote: > > libs/odf/KoOdfStylesReader.cpp, lines 289-305 > > > > > > That part is only called when a style is added which only happens a > > notes-configuration is f

Re: Review Request: Added Footnotes/Endnotes in References Tool

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102552/ --- (Updated Sept. 10, 2011, 8:49 p.m.) Review request for Calligra. Changes

Re: Review Request: Added Footnotes/Endnotes in References Tool

> On Sept. 9, 2011, 3:25 a.m., Thorsten Zachmann wrote: > > libs/odf/KoOdfStylesReader.cpp, lines 289-305 > > > > > > That part is only called when a style is added which only happens a > > notes-configuration is f

Re: Review Request: Added Footnotes/Endnotes in References Tool

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102552/ --- (Updated Sept. 10, 2011, 8:43 p.m.) Review request for Calligra. Changes

Re: Review Request: Added Footnotes/Endnotes in References Tool

> On Sept. 8, 2011, 4:58 a.m., Thorsten Zachmann wrote: > > libs/kotext/KoInlineNote.cpp, line 233 > > > > > > Is there a reason to remove this line here. I think it only makes sure > > that the initial value of th

Re: Review Request: Added Footnotes/Endnotes in References Tool

On Friday 09 September 2011 05:31:03 Thorsten Zachmann wrote: > > On Sept. 8, 2011, 4:58 a.m., Thorsten Zachmann wrote: > > > libs/textlayout/KoTextLayoutEndNotesArea.cpp, line 128 > > > > > ne128> > > > > > > Maybe you

Re: Review Request: Added Footnotes/Endnotes in References Tool

> On Sept. 8, 2011, 4:58 a.m., Thorsten Zachmann wrote: > > libs/textlayout/KoTextLayoutEndNotesArea.cpp, line 128 > > > > > > Maybe you can somewhere define what all these numbers are for > > Brijesh Patel wrote:

Re: Review Request: Added Footnotes/Endnotes in References Tool

> On Sept. 8, 2011, 4:58 a.m., Thorsten Zachmann wrote: > > libs/kotext/KoInlineNote.cpp, lines 164-165 > > > > > > Maybe you can remove the count variable and do the renumbering where a > > new footnote is added t

Re: Review Request: Added Footnotes/Endnotes in References Tool

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102552/#review6344 --- libs/odf/KoOdfStylesReader.cpp

Re: Review Request: Added Footnotes/Endnotes in References Tool

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102552/ --- (Updated Sept. 8, 2011, 3:28 p.m.) Review request for Calligra. Changes

Re: Review Request: Added Footnotes/Endnotes in References Tool

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102552/ --- (Updated Sept. 7, 2011, 5:17 p.m.) Review request for Calligra. Changes

Re: Review Request: Added Footnotes/Endnotes in References Tool

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102552/ --- (Updated Sept. 7, 2011, 4:43 p.m.) Review request for Calligra. Summary

Review Request: Added Footnotes/Endnotes in References Tool

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102552/ --- Review request for Calligra. Summary --- I worked on a project provid