> On Sept. 9, 2011, 3:25 a.m., Thorsten Zachmann wrote: > > libs/odf/KoOdfStylesReader.cpp, lines 289-305 > > <http://git.reviewboard.kde.org/r/102552/diff/2/?file=35552#file35552line289> > > > > That part is only called when a style is added which only happens a > > notes-configuration is found. The code is not executed when there is no > > notes-configuration. Is that what you want?
no,this is called when there is no note-configuration and so it loads the default one using that part - Brijesh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102552/#review6344 ----------------------------------------------------------- On Sept. 10, 2011, 8:43 p.m., Brijesh Patel wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102552/ > ----------------------------------------------------------- > > (Updated Sept. 10, 2011, 8:43 p.m.) > > > Review request for Calligra. > > > Summary > ------- > > I worked on implementation of Footnotes and Endnotes in Calligra Words as > part of my SoK project. > Footnotes/Endnotes can now be inserted,saved,loaded and also be configured > too. > Can somebody review my work and notify me about bugs/crashes? > > > Diffs > ----- > > libs/kotext/KoInlineNote.h 515a2f3 > libs/kotext/KoInlineNote.cpp 89200fd > libs/kotext/KoInlineTextObjectManager.h 44990e9 > libs/kotext/KoInlineTextObjectManager.cpp da8d9ca > libs/kotext/KoTextEditor.h ba28354 > libs/kotext/KoTextEditor.cpp 4d3e5b18 > libs/kotext/opendocument/KoTextLoader.cpp e9d47da > libs/kotext/styles/KoSectionStyle.cpp 2f3a1ad > libs/odf/KoOdfNotesConfiguration.cpp bc26e31 > libs/odf/KoOdfNumberDefinition.cpp d35a07f > libs/odf/KoOdfStylesReader.cpp 5a8324e > libs/textlayout/KoTextLayoutArea.h ea7fd8e > libs/textlayout/KoTextLayoutArea.cpp 504de0c > libs/textlayout/KoTextLayoutEndNotesArea.h 7b0c732 > libs/textlayout/KoTextLayoutEndNotesArea.cpp bb746db > plugins/textshape/CMakeLists.txt 3df7aa5 > plugins/textshape/ReferencesTool.h 40676b2 > plugins/textshape/ReferencesTool.cpp 0bbd38d > plugins/textshape/dialogs/NotesConfigurationDialog.h PRE-CREATION > plugins/textshape/dialogs/NotesConfigurationDialog.cpp PRE-CREATION > plugins/textshape/dialogs/NotesConfigurationDialog.ui PRE-CREATION > plugins/textshape/dialogs/SimpleFootEndNotesWidget.h 1af35a8 > plugins/textshape/dialogs/SimpleFootEndNotesWidget.cpp 374b266 > plugins/textshape/dialogs/SimpleFootEndNotesWidget.ui 77f33e7 > plugins/textshape/pics/settings-icon1_1.png PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/102552/diff > > > Testing > ------- > > > Thanks, > > Brijesh > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
