Re: Review Request 119222: Make labels inline-editable

Yep, you're right, these changes are too heavy. On Sunday, 30 November 2014, Adam Pigg wrote: > This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119222/ > > On November 29th, 2014, 10:59 p.m. UTC, Jarosław Staniek wrote: > > Great job! > > We want it i

Re: Review Request 119222: Make labels inline-editable

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119222/ --- (Updated Nov. 30, 2014, 8:48 a.m.) Status -- This change has been ma

Re: Review Request 119222: Make labels inline-editable

> On Nov. 29, 2014, 10:59 p.m., Jarosław Staniek wrote: > > Great job! > > > > We want it in 2.8 too... Is 2.8 not for bugfixes only? - Adam --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.o

Re: Review Request 119222: Make labels inline-editable

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119222/#review71101 --- Ship it! Great job! We want it in 2.8 too... - Jarosław St

Re: Review Request 119222: Make labels inline-editable

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119222/ --- (Updated Nov. 29, 2014, 10:37 p.m.) Review request for Calligra and Jaros

Re: Review Request 119222: Make labels inline-editable

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119222/ --- (Updated Nov. 29, 2014, 8:45 p.m.) Review request for Calligra and Jarosł

Re: Review Request 119222: Make labels inline-editable

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119222/#review71087 --- libs/koreport/wrtembed/reportscene.cpp

Re: Review Request 119222: Make labels inline-editable

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119222/#review71086 --- Almost there! Mostly notes on certain techniques. libs/korep

Re: Review Request 119222: Make labels inline-editable

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119222/ --- (Updated Nov. 29, 2014, 6:04 p.m.) Review request for Calligra and Jarosł

Re: Review Request 119222: Make labels inline-editable

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119222/ --- (Updated Nov. 28, 2014, 11:03 p.m.) Review request for Calligra and Jaros

Re: Review Request 119222: Make labels inline-editable

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119222/ --- (Updated Nov. 28, 2014, 10:53 p.m.) Review request for Calligra and Jaros

Re: Review Request 119222: Make labels inline-editable

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119222/#review71001 --- Much better, close to final. Thanks! The note in KoReportDesig

Re: Review Request 119222: Make labels inline-editable

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119222/ --- (Updated Nov. 19, 2014, 10:04 p.m.) Review request for Calligra and Jaros

Re: Review Request 119222: Make labels inline-editable

On Nov. 17, 2014, 10:29 p.m., Adam Pigg wrote: > > "DEFECT1 after showing the label is not resized to the size of parent - see > > http://wstaw.org/m/2014/07/10/plasma-desktoppn2275.png"; > > > > Fixed! > > > > "DEFECT2 dashed frame is not needed then (see the same screenshot)" > > > > Fixed!

Re: Review Request 119222: Make labels inline-editable

> On Nov. 13, 2014, 11:36 a.m., Jarosław Staniek wrote: > > libs/koreport/items/label/BoundedTextItem.cpp, line 43 > > > > > > Why QPalette::Background? It's the same as QPalette::Windowm, i.e. > > gray. I gues

Re: Review Request 119222: Make labels inline-editable

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119222/#review70535 --- Much much better! There are hopes to have it in 2.8.7. Notes b

Re: Review Request 119222: Make labels inline-editable

> On July 10, 2014, 10:25 p.m., Jarosław Staniek wrote: > > libs/koreport/items/label/KoReportDesignerItemLabel.cpp, line 189 > > > > > > can be called once, move to init() > > Jarosław Staniek wrote: > It's

Re: Review Request 119222: Make labels inline-editable

> On July 11, 2014, 12:25 a.m., Jarosław Staniek wrote: > > libs/koreport/items/label/KoReportDesignerItemLabel.cpp, line 189 > > > > > > can be called once, move to init() It's good to move it to BoundedTextIte

Re: Review Request 119222: Make labels inline-editable

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119222/ --- (Updated Nov. 14, 2014, 9:07 p.m.) Review request for Calligra and Jarosł

Re: Review Request 119222: Make labels inline-editable

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119222/#review70316 --- libs/koreport/items/label/BoundedTextItem.h

Re: Review Request 119222: Make labels inline-editable

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119222/ --- (Updated Nov. 12, 2014, 10:51 p.m.) Review request for Calligra and Jaros

Re: Review Request 119222: Make labels inline-editable

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119222/#review69859 --- Partial review, not yet clicked through it... libs/koreport/

Re: Review Request 119222: Make labels inline-editable

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119222/ --- (Updated Nov. 3, 2014, 7:49 p.m.) Review request for Calligra and Jarosła

Re: Review Request 119222: Make labels inline-editable

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119222/ --- (Updated Nov. 3, 2014, 9:24 a.m.) Review request for Calligra and Jarosła

Re: Review Request 119222: Make labels inline-editable

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119222/#review68504 --- OK, we need more time to fix it... - Jarosław Staniek On Au

Re: Review Request 119222: Make labels inline-editable

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119222/ --- (Updated Aug. 10, 2014, 7:37 p.m.) Review request for Calligra and Jarosł

Re: Review Request 119222: Make labels inline-editable

> On July 14, 2014, 10:08 p.m., Jarosław Staniek wrote: > > Much cooler! Thanks. > > Noticed: > > - when double clicking it's supereasy to accidentally move the item by a > > few pixels; on displays with even more density it will be even more > > noticeable > > - this time crashes on inserting

Re: Review Request 119222: Make labels inline-editable

> On July 15, 2014, 12:08 a.m., Jarosław Staniek wrote: > > Much cooler! Thanks. > > Noticed: > > - when double clicking it's supereasy to accidentally move the item by a > > few pixels; on displays with even more density it will be even more > > noticeable > > - this time crashes on inserting

Re: Review Request 119222: Make labels inline-editable

> On July 14, 2014, 10:08 p.m., Jarosław Staniek wrote: > > Much cooler! Thanks. > > Noticed: > > - when double clicking it's supereasy to accidentally move the item by a > > few pixels; on displays with even more density it will be even more > > noticeable > > - this time crashes on inserting

Re: Review Request 119222: Make labels inline-editable

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119222/#review62339 --- Much cooler! Thanks. Noticed: - when double clicking it's sup

Re: Review Request 119222: Make labels inline-editable

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119222/ --- (Updated July 14, 2014, 7:11 p.m.) Review request for Calligra and Jarosł

Re: Review Request 119222: Make labels inline-editable

> On July 13, 2014, 6:45 p.m., Kamil Łysik wrote: > > libs/koreport/items/label/KoReportDesignerItemLabel.cpp, line 193 > > > > > > I got build error: adding > > #include > > fixed this. Is this include

Re: Review Request 119222: Make labels inline-editable

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119222/ --- (Updated July 14, 2014, 5:05 p.m.) Review request for Calligra and Jarosł

Re: Review Request 119222: Make labels inline-editable

> On Juli 13, 2014, 6:45 nachm., Kamil Łysik wrote: > > libs/koreport/items/label/KoReportDesignerItemLabel.cpp, line 193 > > > > > > I got build error: adding > > #include > > fixed this. Is this inclu

Re: Review Request 119222: Make labels inline-editable

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119222/#review62258 --- libs/koreport/items/label/KoReportDesignerItemLabel.cpp

Re: Review Request 119222: Make labels inline-editable

On July 10, 2014, 10:25 p.m., Adam Pigg wrote: > > Looks nicely functional already! > > Things to consider: > > - after showing the label is not resized to the size of parent - see > > http://wstaw.org/m/2014/07/10/plasma-desktoppn2275.png > > - dashed frame is not needed then (see the same sc

Re: Review Request 119222: Make labels inline-editable

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119222/#review62109 --- libs/koreport/items/label/KoReportDesignerItemLabel.cpp

Re: Review Request 119222: Make labels inline-editable

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119222/#review62100 --- libs/koreport/items/label/KoReportDesignerItemLabel.cpp