----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119222/#review62339 -----------------------------------------------------------
Much cooler! Thanks. Noticed: - when double clicking it's supereasy to accidentally move the item by a few pixels; on displays with even more density it will be even more noticeable - this time crashes on inserting a new Field item: Thread 1 (Thread 0x7fea16cf0780 (LWP 8479)): [KCrash Handler] #4 0x00007fe9ec6dc6b8 in KoReportItemBase::entityName (this=0x0) at /home/jarek/dev/src/calligra-master2/libs/koreport/common/KoReportItemBase.cpp:107 #5 0x00007fe9ec7278ff in KoReportDesigner::isEntityNameUnique (this=0x1ac43f0, n=..., ignore=0x0) at /home/jarek/dev/src/calligra-master2/libs/koreport/wrtembed/KoReportDesigner.cpp:1118 #6 0x00007fe9ec727771 in KoReportDesigner::suggestEntityName (this=0x1ac43f0, n=...) at /home/jarek/dev/src/calligra-master2/libs/koreport/wrtembed/KoReportDesigner.cpp:1100 #7 0x00007fe9ec731e63 in KoReportDesignerItemLabel::KoReportDesignerItemLabel (this=0x21c0040, d=0x1ac43f0, scene=0x1d4c4f0, pos=...) at /home/jarek/dev/src/calligra-master2/libs/koreport/items/label/KoReportDesignerItemLabel.cpp:62 #8 0x00007fe9ec7341c5 in KoReportLabelPlugin::createDesignerInstance (this=0x173e810, designer=0x1ac43f0, scene=0x1d4c4f0, pos=...) at /home/jarek/dev/src/calligra-master2/libs/koreport/items/label/KoReportLabelPlugin.cpp:52 #9 0x00007fe9ec7267c8 in KoReportDesigner::sectionMouseReleaseEvent (this=0x1ac43f0, v=0x1ac56d0, e=0x7fffb81f1d30) at /home/jarek/dev/src/calligra-master2/libs/koreport/wrtembed/KoReportDesigner.cpp:866 #10 0x00007fe9ec72002f in ReportSceneView::mouseReleaseEvent (this=0x1ac56d0, e=0x7fffb81f1d30) at /home/jarek/dev/src/calligra-master2/libs/koreport/wrtembed/reportsceneview.cpp:64 - the edited text isn't aligned well (horizontally/vertically) - bg/fg color not copied to the edited text - clicking on any area of the label during editing still does not change cursor's position; instead just ends the editing mode - - when in editing mode, if I switch to other report and switch back, the editing mode is apparently still present but the cursor is invisible; it's also impossible to enter text; the only solution is to click on any report's area Later Todos: - escape key shall exit from the edit mode, F2 shall enter it libs/koreport/CMakeLists.txt <https://git.reviewboard.kde.org/r/119222/#comment43305> let's move this to the section where files from items/label/ reside libs/koreport/items/label/BoundedTextItem.h <https://git.reviewboard.kde.org/r/119222/#comment43308> please base this license header on other file libs/koreport/items/label/BoundedTextItem.h <https://git.reviewboard.kde.org/r/119222/#comment43307> one line of explanation what it is would be useful libs/koreport/items/label/BoundedTextItem.h <https://git.reviewboard.kde.org/r/119222/#comment43306> +explicit libs/koreport/items/label/BoundedTextItem.cpp <https://git.reviewboard.kde.org/r/119222/#comment43309> please base this license header on other file - Jarosław Staniek On July 14, 2014, 9:11 p.m., Adam Pigg wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119222/ > ----------------------------------------------------------- > > (Updated July 14, 2014, 9:11 p.m.) > > > Review request for Calligra and Jarosław Staniek. > > > Bugs: 336825 > http://bugs.kde.org/show_bug.cgi?id=336825 > > > Repository: calligra > > > Description > ------- > > Usage: > Insert label > Double click to enter inline-edit mode > -Label text is selected and can be overwritten > Click away from item to exit edit mode > -Item text is updated with editor text > > > Diffs > ----- > > libs/koreport/CMakeLists.txt 26d299c54189f5b402348baa1821f7641a1afd74 > libs/koreport/items/check/KoReportDesignerItemCheck.cpp > 5bebc6c4e10f2243919a0b2668ea3a8ff02ce954 > libs/koreport/items/field/KoReportDesignerItemField.cpp > 0dc9325a1c04dda83bdc7c2a3e4eae5eb500c52f > libs/koreport/items/image/KoReportDesignerItemImage.cpp > 87e46a1ca3ad6dc0a025eeac90dac12e12029691 > libs/koreport/items/label/BoundedTextItem.h PRE-CREATION > libs/koreport/items/label/BoundedTextItem.cpp PRE-CREATION > libs/koreport/items/label/KoReportDesignerItemLabel.h > b2aa78f4bb444fecffc4d01b09901e97204350ee > libs/koreport/items/label/KoReportDesignerItemLabel.cpp > 8974a807b122649a6c6daf61f34c678cb5ec9961 > libs/koreport/items/text/KoReportDesignerItemText.cpp > 51e12d3020104fec4cb8cc473d5499e085dfbf2c > libs/koreport/renderer/KoReportPrintRenderer.cpp > 4018c3b2febbc0dfce9fc528f3f168fa0bc62cbb > libs/koreport/renderer/KoReportScreenRenderer.cpp > d47ce494b957c225ffaf264fe85ea9208165affb > libs/koreport/renderer/odtframe/KoOdtFrameReportCheckBox.cpp > 719e890c53896c9d4a12ad0793f5d9e84e45943f > libs/koreport/wrtembed/KoReportDesigner.cpp > 63152a7d7efb0917534a869df436292616ef0284 > libs/koreport/wrtembed/reportscene.cpp > 2e9c54d29c135c041db75d2a843ea5bd8318e1c1 > > Diff: https://git.reviewboard.kde.org/r/119222/diff/ > > > Testing > ------- > > Inserted label on new report and checked usage > > Loaded existing report and ensured labels are editiable > > > Thanks, > > Adam Pigg > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
