On July 10, 2014, 10:25 p.m., Adam Pigg wrote: > > Looks nicely functional already! > > Things to consider: > > - after showing the label is not resized to the size of parent - see > > http://wstaw.org/m/2014/07/10/plasma-desktoppn2275.png > > - dashed frame is not needed then (see the same screenshot) > > - the font is not copied > > - clicking on any area of the label during editing does not change cursor, > > maybe z-order isn't proper? > > - would be nicve if F2 shortcut also entered into the edit mode > > - when I use the property editor to enter the caption, after clicking > > outside the caption text is reset to the original value; now the only way > > to enter the text is to use the inline editor > > - inserting a new label (or copy-pasting) crashes, exactly 6 times result > > of dynamic_cast<KoReportItemBase*> does not seem to be compared with 0: > > > > #4 0x00007f05e3473440 in KoReportItemBase::entityName (this=0x0) at > > /home/jarek/dev/src/calligra-master2/libs/koreport/common/KoReportItemBase.cpp:107 > > #5 0x00007f05e34beb89 in KoReportDesigner::isEntityNameUnique > > (this=0x2f1bae0, n=..., ignore=0x0) at > > /home/jarek/dev/src/calligra-master2/libs/koreport/wrtembed/KoReportDesigner.cpp:1161 > > #6 0x00007f05e34be535 in KoReportDesigner::suggestEntityName > > (this=0x2f1bae0, n=...) at > > /home/jarek/dev/src/calligra-master2/libs/koreport/wrtembed/KoReportDesigner.cpp:1100 > > #7 0x00007f05e34c8b89 in > > KoReportDesignerItemLabel::KoReportDesignerItemLabel (this=0x3076230, > > d=0x2f1bae0, scene=0x2f3bb90, pos=...) at > > /home/jarek/dev/src/calligra-master2/libs/koreport/items/label/KoReportDesignerItemLabel.cpp:56 > > #8 0x00007f05e34cae89 in KoReportLabelPlugin::createDesignerInstance > > (this=0x2214440, designer=0x2f1bae0, scene=0x2f3bb90, pos=...) at > > /home/jarek/dev/src/calligra-master2/libs/koreport/items/label/KoReportLabelPlugin.cpp:52 > > #9 0x00007f05e34bd58c in KoReportDesigner::sectionMouseReleaseEvent > > (this=0x2f1bae0, v=0x2f37170, e=0x7fffc569b8f0) at > > /home/jarek/dev/src/calligra-master2/libs/koreport/wrtembed/KoReportDesigner.cpp:866 > > #10 0x00007f05e34b6df3 in ReportSceneView::mouseReleaseEvent > > (this=0x2f37170, e=0x7fffc569b8f0) at > > /home/jarek/dev/src/calligra-master2/libs/koreport/wrtembed/reportsceneview.cpp:64
Ive fixed the crash Fixed the text not being updatable in the property editor - Adam ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119222/#review62100 ----------------------------------------------------------- On July 10, 2014, 9:22 p.m., Adam Pigg wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119222/ > ----------------------------------------------------------- > > (Updated July 10, 2014, 9:22 p.m.) > > > Review request for Calligra and Jarosław Staniek. > > > Bugs: 336825 > http://bugs.kde.org/show_bug.cgi?id=336825 > > > Repository: calligra > > > Description > ------- > > Usage: > Insert label > Double click to enter inline-edit mode > -Label text is selected and can be overwritten > Click away from item to exit edit mode > -Item text is updated with editor text > > > Diffs > ----- > > libs/koreport/items/label/KoReportDesignerItemLabel.h > b2aa78f4bb444fecffc4d01b09901e97204350ee > libs/koreport/items/label/KoReportDesignerItemLabel.cpp > 8974a807b122649a6c6daf61f34c678cb5ec9961 > > Diff: https://git.reviewboard.kde.org/r/119222/diff/ > > > Testing > ------- > > Inserted label on new report and checked usage > > Loaded existing report and ensured labels are editiable > > > Thanks, > > Adam Pigg > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
