T10760: Calligra website unwanted blog content

staniek added a comment. Asking Cyrille and Boud... F6754550: image.png TASK DETAIL https://phabricator.kde.org/T10760 To: staniek Cc: staniek, danders, #sysadmin, Calligra-Devel-list, #calligra:_3.0, ongunkanat, sysadmin

D15412: [filters] Extend table lifetime

staniek accepted this revision. staniek added a comment. This revision is now accepted and ready to land. Good job! REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D15412 To: anthonyfieroni, danders, boemann, #calligra:_3.0, staniek Cc: staniek, Calligra-Devel-list, dc

D15412: [filters] Extend table lifetime

staniek added inline comments. INLINE COMMENTS > anthonyfieroni wrote in MsooXmlDrawingReaderTableMethods.h:40 > That isn't a problem, it's initialized at constructor time. I know but original code was not called new KoTable for PptxXmlSlideReader, right? > anthonyfieroni wrote in DocxXmlDocum

D15412: [filters] Extend table lifetime

staniek requested changes to this revision. staniek added a comment. This revision now requires changes to proceed. Thanks, lots of other people also touched this code but I tried this time to review :) I propose to separate the string literal changes. Also I wonder why there's "Context n

D15111: [KoUnit] Let's show pixel units

staniek added a comment. In D15111#317311 , @anthonyfieroni wrote: > @staniek did you want a DPI config spinbox? As in, e.g. GIMP, whenever we work in export-to-bitmap, and there's size other than in pixels, there's also DPI setting. Tha

D15111: [KoUnit] Let's show pixel units

staniek added a comment. In D15111#317263 , @boemann wrote: > we don't store pixel values but rather convert to points the user will not get pixel precise placement anyway Sure we but users who design for pixel size, like me, do that usin

D15111: [KoUnit] Let's show pixel units

staniek added a comment. tl;dr images designed without regards to physical pixels size look well only for large sizes Are we talking about equivalent of this option of Inkscape? F6223325: image.png The Px unit has wide usage. In the bug des

D12839: Get Calligra to compile with Qt 5.11

staniek accepted this revision. This revision is now accepted and ready to land. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D12839 To: nerdopolist, Calligra-Devel-list, #calligra:_3.0, staniek Cc: #calligra:_3.0, cochise, vandenoever

D8310: Port Calligra Gemini for 3.x

staniek accepted this revision. staniek added a comment. This revision is now accepted and ready to land. +1 from me, appeciated the port! - have not run it - have not reviewed the QML part INLINE COMMENTS > CMakeLists.txt:3 > > +add_definitions("-DUNICODE -D_UNICODE") > + Conventio

[Differential] [Commented On] D2577: KoResourcePaths: Fix handling of wildcards in directories and files

staniek added inline comments. INLINE COMMENTS > danders wrote in KoResourcePaths.cpp:43 > I did it to be able to filter out all other debug statements, and I can see > where it originates so I find it much easier to use. I did it to be able to filter out all other debug statements, and I can s

[Maniphest] [Closed] T3755: Kexi API docs missing in the calligra section

staniek closed this task as "Resolved". staniek claimed this task. staniek added a comment. @bcooksley Yep, generalizing the scripts is not practical or safe. Thanks. TASK DETAIL https://phabricator.kde.org/T3755 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreference

[Maniphest] [Commented On] T3755: Kexi API docs missing in the calligra section

staniek added a comment. In https://phabricator.kde.org/T3755#55509, @kossebau wrote: > > @staniek I would recommend to move src/Mainpage.dox to the toplevel dir (and adopting the EXCLUDE entry). Because right now this results in the additional subsection "Kexi" on https:/

[Maniphest] [Commented On] T3755: Kexi API docs missing in the calligra section

staniek added a comment. The domain name is secured and it's KDE's already. TASK DETAIL https://phabricator.kde.org/T3755 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: staniek Cc: kossebau, Calligra-Devel-list, bcooksley, ochurlaud, sysadmin, staniek,

[Maniphest] [Commented On] T3755: Kexi API docs missing in the calligra section

staniek added a comment. Very good, either solution that declutters the API pages would work for me. So the question is where to generate project's docs. Generating from within kexi-project.org comes to my mind, what would be feasible as part of a larger challenge: (finally) moving the s

[Maniphest] [Commented On] T3755: Kexi API docs missing in the calligra section

staniek added a comment. Are we sure? For example KDevelop has kdevplatform https://api.kde.org/extragear-api/kdevelop-apidocs/index.html, just released yesterday, but Calligra does not: https://api.kde.org/bundled-apps-api/calligra-apidocs/ From what I see we're not planning t

[Maniphest] [Commented On] T3755: Kexi API docs missing in the calligra section

staniek added a comment. In https://phabricator.kde.org/T3755#55367, @kossebau wrote: > In https://phabricator.kde.org/T3755#55355, @staniek wrote: > > > > there is not much content right now on the kexi pages > > > > Right if you mean 'special pages' with prose. But there's plenty

[Maniphest] [Commented On] T3755: Kexi API docs missing in the calligra section

staniek added a comment. > No idea about Kexi, does kexi itself install libs with a public API? Nope, everything in this category has been moved to KDb/KProperty/KReport. TASK DETAIL https://phabricator.kde.org/T3755 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailp

[Maniphest] [Commented On] T3755: Kexi API docs missing in the calligra section

staniek added a comment. > A fix would be to remove widget/undo/Mainpage.dox Done, thanks Friedrich. TASK DETAIL https://phabricator.kde.org/T3755 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: staniek Cc: kossebau, Calligra-Devel-list, bcooksley,

[Maniphest] [Commented On] T3755: Kexi API docs missing in the calligra section

staniek added a comment. > there is not much content right now on the kexi pages Right if you mean 'special pages' with prose. But there's plenty of doxygen API docs in the context of classes and functions. TASK DETAIL https://phabricator.kde.org/T3755 EMAIL PREFERENCES https://phab

[Maniphest] [Updated] T3755: Kexi API docs missing in the calligra section

staniek added projects: Calligra: 3.0, Kexi, Kexi: Porting to Qt 5. TASK DETAIL https://phabricator.kde.org/T3755 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: staniek Cc: Calligra-Devel-list, bcooksley, ochurlaud, sysadmin, staniek, blazquez

[Differential] [Requested Changes To] D2577: KoResourcePaths: Fix handling of wildcards in directories and files

staniek requested changes to this revision. staniek added a reviewer: staniek. This revision now requires changes to proceed. REPOSITORY rCALLIGRA Calligra REVISION DETAIL https://phabricator.kde.org/D2577 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

[Differential] [Commented On] D2577: KoResourcePaths: Fix handling of wildcards in directories and files

staniek added a comment. Nice, some early notes. INLINE COMMENTS > KoResourcePaths.cpp:43 > +{ > +static const QLoggingCategory > category("calligra.lib.widgets.koresourcepaths"); > +return category; Can we drop the "ko" legacy here? Or even: do we really need a category per class/

[Differential] [Updated] D2577: KoResourcePaths: Fix handling of wildcards in directories and files

staniek added a reviewer: Calligra-Devel-list. REPOSITORY rCALLIGRA Calligra REVISION DETAIL https://phabricator.kde.org/D2577 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: danders, #calligra:_3.0, Calligra-Devel-list Cc: staniek

[Differential] [Commented On] D1032: Make KUndo2Stack::push return false if the command was merged (and deleted) rather than pushed

staniek added a comment. In https://phabricator.kde.org/D1032#23331, @aspotashev wrote: > Looks good to me. > > P.S. We probably need to share the kundo2 library between Kexi, Krita and Calligra. Thanks Alexander. Yes, this, or we would replace with Qt5 if there's equivalent

[Differential] [Closed] D1032: Make KUndo2Stack::push return false if the command was merged (and deleted) rather than pushed

This revision was automatically updated to reflect the committed changes. Closed by commit rCALLIGRA68ac8207a9cf: Make KUndo2Stack::push return false if the command was merged (and deleted)… (authored by staniek). REPOSITORY rCALLIGRA Calligra CHANGES SINCE LAST UPDATE https://phabricator.kd

Re: Review Request 127347: Fix build with glibc >= 2.23 by using qIsNaN

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127347/#review93426 --- Ship it! Ship It! - Jarosław Staniek On March 12, 2016

Re: Review Request 127347: Fix build with glibc >= 2.23 by using std namespace

tps://git.reviewboard.kde.org/r/127347/#comment63684> I propose that you remove the ifdef completely and also don't use cmath; instead use qIsNaN(). We use it in a few places already. - Jarosław Staniek On March 11, 2016, 10:05 p.m., Heiko B

[Differential] [Updated] D1032: Make KUndo2Stack::push return false if the command was merged (and deleted) rather than pushed

staniek added reviewers: kossebau, rempt, boemann, aspotashev. staniek added a subscriber: Calligra-Devel-list. REPOSITORY rCALLIGRA Calligra REVISION DETAIL https://phabricator.kde.org/D1032 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: staniek, kosse

[Maniphest] [Commented On] T665: Show default (empty) document on startup in document-based Calligra apps

staniek added a comment. I imagine this motto: **Make simple, familiar things easy, awesome complicated things -- possible.** In my opinion for now we're more heading towards the latter what is a major mistake. We have the code, design and all toys. The latter part is possible to have to meet

[Maniphest] [Commented On] T665: Show default (empty) document on startup in document-based Calligra apps

staniek added a comment. In https://phabricator.kde.org/T665#15282, @kossebau wrote: > Would it be a good idea to have UI/UX experts look at this as well? Yes, though it would be unfortunate to repeat this -- "they" apparently did: ​ ​for StarOffice, OO.org, LO , and MS Office at least :) > B

Re: Review Request 126797: Add kexi.git build with deps

x27;s deps Diffs - dependency-data-kf5-minimum 95dad0d dependency-data-kf5-qt5 3856fe3 logical-module-structure 061ca5f Diff: https://git.reviewboard.kde.org/r/126797/diff/ Testing --- no Thanks, Jarosław Staniek ___ calligra-

Re: Review Request 126797: Add kexi.git build with deps

26797/diff/ Testing --- no Thanks, Jarosław Staniek ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

[Maniphest] [Changed Subscribers] T665: Show default (empty) document on startup in document-based Calligra apps

staniek added a subscriber: Calligra-Devel-list. TASK DETAIL https://phabricator.kde.org/T665 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: staniek Cc: Calligra-Devel-list, staniek ___ calligra-devel mailing lis

Re: Review Request 122153: KD Chart

? - Jarosław Staniek On Dec. 3, 2015, 8:58 a.m., Stephen Leibowitz wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 123659: Align lines in tabular view

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123659/#review91167 --- Pushed to 3.0, let's not push to 2.9. - Jarosław St

Re: Review Request 123659: Align lines in tabular view

> On May 7, 2015, 9:51 p.m., Jarosław Staniek wrote: > > Nice, what's this stype? > > Tested this: > > Breeze: off by 1 pixel http://i.imgur.com/NVNExKS.png > > Oxygen: off by 2 pixels > > Cleanlooks, Windows, GTK+: off by 1 pixel > > Bespin: pe

Re: Review Request 123699: Changed a few labels in kexi's forms and reports designers

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123699/#review91165 --- Ship it! Ship It! - Jarosław Staniek On May 9, 2015, 1

Re: Review Request 123699: Changed a few labels in kexi's forms and reports designers

> On May 9, 2015, 8:29 p.m., Jarosław Staniek wrote: > > kexi/plugins/forms/kexiformmanager.cpp, line 394 > > <https://git.reviewboard.kde.org/r/123699/diff/1/?file=367937#file367937line394> > > > > While we're at this, I also recommend to change \"

Re: Review Request 117035: Kexi quickform QML plugin

> On Jan. 15, 2016, 8:59 a.m., Jarosław Staniek wrote: > > The idea is great and valid. > > > > I propose to drop this patch and keep the idea and old code around. QQ1 is > > dead... > > Adam Pigg wrote: > a rewrite is partf my sailfish master plan T

Re: Review Request 117035: Kexi quickform QML plugin

and keep the idea and old code around. QQ1 is dead... - Jarosław Staniek On March 24, 2014, 10:44 p.m., Adam Pigg wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 123941: Get the example to show data

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123941/#review91126 --- Ship it! I think it's pushed already? - Jarosław St

[Differential] [Abandoned] D362: Modularity++: Move find_package() to places where they belong, make other optional

staniek abandoned this revision. staniek added a comment. Abandoning: Kexi moved to kexi.git REPOSITORY rCALLIGRA Calligra REVISION DETAIL https://phabricator.kde.org/D362 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: staniek, kossebau, rempt Cc: and

Re: Review Request 125649: [OS X] install icon resources in app bundles where this doesn't happen automatically

x27;s ported to calligra master (3.0)? Otherwise we'd loose the fixes. - Jarosław Staniek On Oct. 15, 2015, 10:55 p.m., René J.V. Bertin wrote: > > --- > This is an automatically generated e-mail. To re

[Differential] [Commented On] D362: Modularity++: Move find_package() to places where they belong, make other optional

staniek added a comment. So I am keeping this privately for now. @kossebau I am wondering if we can we have equivalent behaviour on top level using calligra_drop_product_on_bad_condition(). REPOSITORY rCALLIGRA Calligra REVISION DETAIL https://phabricator.kde.org/D362 EMAIL PREFERENCES

[Differential] [Closed] D361: KoColorConversionTransformation: msvc can't export static data, change it to inline static methods

This revision was automatically updated to reflect the committed changes. Closed by commit rCALLIGRAa6a6bd25f3ae: KoColorConversionTransformation: msvc can't export static data, change it to… (authored by staniek). REPOSITORY rCALLIGRA Calligra CHANGES SINCE LAST UPDATE https://phabricator.k

[Differential] [Closed] D360: KoFileDialog rather belongs to kowidgetutils than kowidgetsThis way apps can use the class without larger deps of kowidgets

This revision was automatically updated to reflect the committed changes. Closed by commit rCALLIGRA33aa31e168de: KoFileDialog rather belongs to kowidgetutils than kowidgets (authored by staniek). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D360?vs=901&id=908#toc REPOSITORY rCALLIGRA

[Differential] [Updated] D360: KoFileDialog rather belongs to kowidgetutils than kowidgetsThis way apps can use the class without larger deps of kowidgets

staniek marked an inline comment as done. staniek added a comment. In https://phabricator.kde.org/D360#7130, @kossebau wrote: > Not sure I would have moved the main.cpp into the other file, but there is no > policy in Calligra about such utils apps, so if you prefer it like that, keep > it as y

[Differential] [Updated, 2,548 lines] D360: KoFileDialog rather belongs to kowidgetutils than kowidgetsThis way apps can use the class without larger deps of kowidgets

staniek removed rCALLIGRA Calligra as the repository for this revision. staniek updated this revision to Diff 901. staniek added a comment. proper final (?) patch CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D360?vs=900&id=901 REVISION DETAIL https://phabricator.kde.org/D360 AFFEC

[Differential] [Updated, 2,557 lines] D360: KoFileDialog rather belongs to kowidgetutils than kowidgetsThis way apps can use the class without larger deps of kowidgets

staniek updated the summary for this revision. staniek set the repository for this revision to rCALLIGRA Calligra. staniek updated this revision to Diff 900. staniek added a comment. - move to tests/ subdir - remove main.cpp which is too general file, place main() in KoFileDialogTester.cpp - by t

[Differential] [Commented On] D360: KoFileDialog rather belongs to kowidgetutils than kowidgetsThis way apps can use the class without larger deps of kowidgets

staniek added a comment. In https://phabricator.kde.org/D360#7104, @kossebau wrote: > While moving filedialogtester, could you please move it into the subdir > tests/, so the normal dir only contains product code? OK, I wanted to propose that. > As you just moved the KoFileDialog class files

[Differential] [Updated, 2,557 lines] D360: KoFileDialog rather belongs to kowidgetutils than kowidgetsThis way apps can use the class without larger deps of kowidgets

staniek updated the summary for this revision. staniek removed rCALLIGRA Calligra as the repository for this revision. staniek updated this revision to Diff 897. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D360?vs=896&id=897 REVISION DETAIL https://phabricator.kde.org/D360 AFFECTED

[Differential] [Updated, 463 lines] D360: KoFileDialog rather belongs to kowidgetutils than kowidgetsThis way apps can use the class without larger deps of kowidgets

staniek updated this revision to Diff 896. staniek added a comment. - KoFileDialog rather belongs to kowidgetutils than kowidgets Updating D360: KoFileDialog rather belongs to kowidgetutils than kowidgets == This way apps ca

[Differential] [Accepted] D364: Move KoFindToolbar to Words, it's only user

staniek accepted this revision. staniek added a reviewer: staniek. This revision is now accepted and ready to land. REPOSITORY rCALLIGRA Calligra BRANCH moveKoFindToolbar REVISION DETAIL https://phabricator.kde.org/D364 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailp

[Differential] [Commented On] D360: KoFileDialog rather belongs to kowidgetutils than kowidgetsThis way apps can use the class without larger deps of kowidgets

staniek added a comment. In https://phabricator.kde.org/D360#7068, @kossebau wrote: > Issue in any case: this patch misses to also move the test app, > filedialogtester. > > Then I wonder if we could first come up with a definition what the purpose of > kowidgets and kowidgetutils is. And if pe

[Differential] [Commented On] D362: Modularity++: Move find_package() to places where they belong, make other optional

staniek added a comment. In https://phabricator.kde.org/D362#7062, @kossebau wrote: > Hm, moving checking for required packages into the subdirs and thus after > calculating which products can be built or, if internal dep, should be built > breaks the concept of the current productset system. S

[Differential] [Updated] D361: KoColorConversionTransformation: msvc can't export static data, change it to inline static methods

staniek added a reviewer: abrahams. REPOSITORY rCALLIGRA Calligra REVISION DETAIL https://phabricator.kde.org/D361 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: staniek, kossebau, rempt, abrahams Cc: Calligra-Devel-list

[Differential] [Updated] D362: Modularity++: Move find_package() to places where they belong, make other optional

staniek added projects: Calligra: 3.0, Kexi: Porting to Qt 5, Krita: Next. REPOSITORY rCALLIGRA Calligra REVISION DETAIL https://phabricator.kde.org/D362 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: staniek, kossebau, rempt Cc: Calligra-Devel-list, wi

[Differential] [Request, 162 lines] D362: Modularity++: Move find_package() to places where they belong, make other optional

staniek created this revision. staniek added reviewers: kossebau, rempt. staniek added a subscriber: Calligra-Devel-list. REVISION SUMMARY This helps to build single apps without having full KF5, e.g. Windows * X11 -> only try to find on !win32 and !mac * Qt5: ** Sql -> sheets ** X

[Differential] [Updated] D361: KoColorConversionTransformation: msvc can't export static data, change it to inline static methods

staniek added a reviewer: kossebau. staniek added projects: Krita: Next, Calligra: 3.0. REPOSITORY rCALLIGRA Calligra REVISION DETAIL https://phabricator.kde.org/D361 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: staniek, rempt, kossebau Cc: Calligra-D

[Differential] [Request, 301 lines] D361: KoColorConversionTransformation: msvc can't export static data, change it to inline static methods

staniek created this revision. staniek added a reviewer: rempt. staniek added a subscriber: Calligra-Devel-list. REVISION SUMMARY It's the same code performance-wise TEST PLAN build REPOSITORY rCALLIGRA Calligra BRANCH master REVISION DETAIL https://phabricator.kde.org/D361 AFFECTED

[Differential] [Updated] D360: KoFileDialog rather belongs to kowidgetutils than kowidgetsThis way apps can use the class without larger deps of kowidgets

staniek updated the summary for this revision. staniek added reviewers: kossebau, rempt. staniek added a project: Calligra: 3.0. REPOSITORY rCALLIGRA Calligra REVISION DETAIL https://phabricator.kde.org/D360 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To

[Differential] [Request, 1,012 lines] D360: KoFileDialog rather belongs to kowidgetutils than kowidgetsThis way apps can use the class without larger deps of kowidgets

staniek created this revision. staniek added a subscriber: Calligra-Devel-list. TEST PLAN build REPOSITORY rCALLIGRA Calligra BRANCH master REVISION DETAIL https://phabricator.kde.org/D360 AFFECTED FILES libs/widgets/CMakeLists.txt libs/widgets/KoFileDialog.cpp libs/widgets/KoFil

[Differential] [Closed] D120: Kexi: use QCommandLineOptions/Parser for args, move to using QApplication

This revision was automatically updated to reflect the committed changes. Closed by commit rCALLIGRAbd684457a5e7: Kexi: use QCommandLineOptions/Parser for args, move to using QApplication (authored by staniek). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D120?vs=266&id=688#toc REPOSITO

[Differential] [Accepted] D183: Add library export definitions

staniek accepted this revision. staniek added a comment. yes, good to go REPOSITORY rCALLIGRA Calligra REVISION DETAIL https://phabricator.kde.org/D183 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: abrahams, dkazakov, rempt, kossebau, staniek Cc: Cal

[Differential] [Accepted] D183: Add library export definitions

staniek accepted this revision. staniek added a comment. Thanks! REPOSITORY rCALLIGRA Calligra REVISION DETAIL https://phabricator.kde.org/D183 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: abrahams, dkazakov, rempt, kossebau, staniek Cc: Calligra-De

[Differential] [Commented On] D183: Add library export definitions

staniek added a comment. Yes, a simple macro CalligraAddTestExportMacro.cmake having calligra_add_test_export_macro(libbasename) macro could be added to calligra/cmake/modules/. Feel free to add a task for developing it together with the rest of the patch. REPOSITORY rCALLIGRA Calligra REV

[Differential] [Commented On] D183: Add library export definitions

staniek added a comment. Like skipping the changes for kexi/, I propose to split the final patch: skip the proper changes in krita/ and in whatever dirs keeps krita touch for calligra/2.9 (pigment, some libs/?). And then commit the non-kexi/non-krita things. Regarding the exporting extra symbo

[Differential] [Commented On] D183: Add library export definitions

staniek added a comment. I've ported quite a few libs to Qt5 and cmake, DEFINE_SYMBOL is not needed at all. If this is a way to avoid merge conflicts... well this becoming complex workaround on its own :) If this was for 2.9 I would't care. In 3.x there shouldn't exist any *_export.h files if

[Differential] [Changed Subscribers] D183: Add library export definitions

staniek added a subscriber: Calligra-Devel-list. staniek changed the visibility of this Differential Revision from "Public (No Login Required)" to "All Users". REPOSITORY rCALLIGRA Calligra REVISION DETAIL https://phabricator.kde.org/D183 EMAIL PREFERENCES https://phabricator.kde.org/sett

[Differential] [Abandoned] D120: Kexi: use QCommandLineOptions/Parser for args, move to using QApplication

staniek abandoned this revision. staniek added a comment. Integrated, WIP. REPOSITORY rCALLIGRA Calligra REVISION DETAIL https://phabricator.kde.org/D120 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: staniek, kossebau, piggz Cc: Calligra-Devel-list,

[Differential] [Planned Changes To] D120: Kexi: use QCommandLineOptions/Parser for args, move to using QApplication

staniek planned changes to this revision. REPOSITORY rCALLIGRA Calligra REVISION DETAIL https://phabricator.kde.org/D120 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: staniek, kossebau, piggz Cc: Calligra-Devel-list, staniek ___

[Differential] [Closed] D126: Modernize version macros for the 3.0 series: use 2.99.89 for the 3.0.0 Pre-Alpha

This revision was automatically updated to reflect the committed changes. Closed by commit rCALLIGRA1f5e838b7e20: Modernize version macros for the 3.0 series: use 2.99.89 for the 3.0.0 Alpha (authored by staniek). REPOSITORY rCALLIGRA Calligra CHANGES SINCE LAST UPDATE https://phabricator.kd

[Differential] [Updated, 94 lines] D126: Modernize version macros for the 3.0 series: use 2.99.89 for the 3.0.0 Pre-Alpha

staniek updated this revision to Diff 287. staniek marked 4 inline comments as done. staniek added a comment. Addressed the notes related to comments. REPOSITORY rCALLIGRA Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D126?vs=286&id=287 REVISION DETAIL https://phabricato

[Differential] [Updated, 94 lines] D126: Modernize version macros for the 3.0 series: use 2.99.89 for the 3.0.0 Pre-Alpha

staniek updated the summary for this revision. staniek updated this revision to Diff 286. staniek added a comment. No Pre-Alpha anymore, just Alpha, both are the same in fact. Add explanation of the magic number 15. REPOSITORY rCALLIGRA Calligra CHANGES SINCE LAST UPDATE https://phabricato

[Differential] [Commented On] D126: Modernize version macros for the 3.0 series: use 2.99.89 for the 3.0.0 Pre-Alpha

staniek added a comment. Ping? Can I assume this improvement can go to frameworks? REPOSITORY rCALLIGRA Calligra REVISION DETAIL https://phabricator.kde.org/D126 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: staniek, Calligra-Devel-list Cc: staniek _

[Differential] [Commented On] D125: Implement a relative zooming shortcuts

staniek added a subscriber: staniek. staniek added a comment. I'd like to discuss one thing. Do we want to have the Calligra-Devel-list as Reviewers for app-specific reviews? My opinion is as follows. I am not sure if even adding it to Subscribers is a right default approach. I tend to add Cal

[Differential] [Updated] D126: Modernize version macros for the 3.0 series: use 2.99.89 for the 3.0.0 Pre-Alpha

staniek updated the summary for this revision. REPOSITORY rCALLIGRA Calligra REVISION DETAIL https://phabricator.kde.org/D126 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: staniek, Calligra-Devel-list Cc: staniek ___

[Differential] [Updated] D126: Modernize version macros for the 3.0 series: use 2.99.89 for the 3.0.0 Pre-Alpha

staniek updated the test plan for this revision. staniek added a reviewer: Calligra-Devel-list. staniek added projects: Krita: Next, Kexi: Porting to Qt 5. REPOSITORY rCALLIGRA Calligra REVISION DETAIL https://phabricator.kde.org/D126 EMAIL PREFERENCES https://phabricator.kde.org/settings/

[Differential] [Updated] D120: Kexi: use QCommandLineOptions/Parser for args, move to using QApplication

staniek updated the summary for this revision. staniek updated the test plan for this revision. staniek added a subscriber: Calligra-Devel. staniek added a project: Kexi: Porting to Qt 5. REPOSITORY rCALLIGRA Calligra REVISION DETAIL https://phabricator.kde.org/D120 EMAIL PREFERENCES https

[Differential] [Abandoned] D113: convert-kicon.pl on calligra/frameworks

staniek abandoned this revision. staniek added a comment. I moved to kexi-frameworks-kexi branch with this kind of change and won't touch non-kexi stuff. REPOSITORY rCALLIGRA Calligra REVISION DETAIL https://phabricator.kde.org/D113 EMAIL PREFERENCES https://phabricator.kde.org/settings

[Differential] [Commented On] D113: convert-kicon.pl on calligra/frameworks

staniek added a comment. In https://phabricator.kde.org/D113#2028, @rempt wrote: > Erm, what does this patch fix for you? As far as I can see, icons (mostly) > already work in the frameworks branch, so I'm not really happy with > introducting another big patch that changes a lot of lines just f

[Differential] [Request, 204 lines] D113: convert-kicon.pl on calligra/frameworks

staniek created this revision. staniek added a reviewer: rempt. staniek added a subscriber: Calligra-Devel. staniek set the repository for this revision to rCALLIGRA Calligra. staniek added a project: Kexi: Porting to Qt 5. REVISION SUMMARY Apply convert-kicon.pl on calligra/frameworks. Isn't it

Re: Review Request 123952: Consistency: use ILIKE/NOT ILIKE operator instead of LIKE for PostgreSQL

259776fc90b Diff: https://git.reviewboard.kde.org/r/123952/diff/ Testing --- Queries work now for pgsql as for sqlite/mysql Thanks, Jarosław Staniek ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Review Request 123952: Consistency: use ILIKE/NOT ILIKE operator instead of LIKE for PostgreSQL

ab6fedb libs/db/parser/parser_p.cpp 5f11f4ea8ce947bf3e4e9dfd97e5f259776fc90b Diff: https://git.reviewboard.kde.org/r/123952/diff/ Testing --- Queries work now for pgsql as for sqlite/mysql Thanks, Jarosław Staniek ___ calligra-devel mailing list cal

Re: Review Request 123942: Keep pointer to related Connection object in query so it can be used to find related tables

/r/123942/diff/ Testing --- Queries work as expected, changes only relate to the conn pointer Thanks, Jarosław Staniek ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Review Request 123942: Keep pointer to related Connection object in query so it can be used to find related tables

libs/db/queryschema_p.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/123942/diff/ Testing --- Queries work as expected, changes only relate to the conn pointer Thanks, Jarosław Staniek ___ calligra-devel mailing list calligra-devel

Re: Review Request 123941: Get the example to show data

. KReportView.h, KReportExampleData.h etc. One day we'll fix all the files (obviously before a stable release), and will remove the o in KoFoo's. - Jarosław Staniek On May 30, 2015, 12:49 a.m., Adam Pigg wrote: > > --- > This

Re: Review Request 123927: Kreport fixes

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123927/#review80936 --- Ship it! Cupercool, we're back on track. - Jarosław St

Re: Review Request 123699: Changed a few labels in kexi's forms and reports designers

> On May 9, 2015, 8:29 p.m., Jarosław Staniek wrote: > > Good. > > > > Translatable string changes are frozen in 2.9 unfortunately, the junior > > jobs were defined when it was possible to change them. > > I'd like to ask for applying kexi/plugins/* chang

Re: Review Request 123732: Replace obsolete QStyleOption::init()

> On May 15, 2015, 12:11 a.m., Jarosław Staniek wrote: > > Ship It! Ping @Roman. - Jarosław --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123732/#re

Re: Review Request 123307: KoProperty -> KProperty everywhere in Calligra

tps://git.reviewboard.kde.org/r/123307/diff/ Testing --- no, just 'careful' search+replace Thanks, Jarosław Staniek ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request 123498: Fixes to KoReport maps plugin

kreport please add #ifdef KREPORT_SCRIPTING when needed. Please also adapt #123496. - Jarosław Staniek On May 17, 2015, 5:45 p.m., Adam Pigg wrote: > > --- > This is an automatically generated e-mail. To reply, visit

Re: Review Request 123498: Fixes to KoReport maps plugin

ranch for KReport. Please note that we did not enable the map plugin in KReport. Do you want to take this task? - Jarosław Staniek On April 25, 2015, 7:17 p.m., Adam Pigg wrote: > > --- > This is an automatically generated e-mail. T

Re: Review Request 123498: Fixes to KoReport maps plugin

tps://git.reviewboard.kde.org/r/123498/#comment55175> please prepend m_ plugins/reporting/maps/KoReportItemMaps.cpp (line 195) <https://git.reviewboard.kde.org/r/123498/#comment55176> -> realItemData() ? - Jarosław Staniek On April 25, 2015, 7:17 p.m.,

Re: Review Request 123732: Replace obsolete QStyleOption::init()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123732/#review80366 --- Ship it! Ship It! - Jarosław Staniek On May 12, 2015, 5

Re: Review Request 123732: Replace obsolete QStyleOption::init()

located +/- using: ack-grep -w "[a-z].init\([a-z ]" - Jarosław Staniek On May 12, 2015, 3:01 p.m., Roman Shtemberko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.review

Re: Review Request 123651: Kexi: Improvements for reports internal source combobox

) <https://git.reviewboard.kde.org/r/123651/#comment55015> -> sourceSelector - Jarosław Staniek On May 10, 2015, 5:33 p.m., Kamil Łysik wrote: > > --- > This is an automatically generated e-mail. To rep

Re: Review Request 123699: Changed a few labels in kexi's forms and reports designers

kexi/plugins/forms/kexiformmanager.cpp (line 394) <https://git.reviewboard.kde.org/r/123699/#comment54975> While we're at this, I also recommend to change \"%1\" to %1. More info at https://techbase.kde.org/Development/Tutorials/Localization/i18n_Semantics.

Re: Review Request 123651: Kexi: Improvements for reports internal source combobox

naming convention: we use human language where possible) kexi/plugins/reports/kexisourceselector.h (line 39) <https://git.reviewboard.kde.org/r/123651/#comment54973> missing ''explicit'' keyword - Jarosł

Re: Review Request 123651: Kexi: Improvements for reports internal source combobox

d.kde.org/r/123651/#comment54958> 'competition' ? kexi/widget/KexiDataSourceComboBox.cpp (line 312) <https://git.reviewboard.kde.org/r/123651/#comment54960> coding style: always use { } - Jarosław Staniek On May 8, 2015, 10:50 p.m., Kamil Łysik wrote: &

  1   2   3   4   5   6   7   8   9   10   >