Re: Review Request: fixes Karbon using icon "effectimages" which is only installed by kipi plugins

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105671/#review16238 --- Ship it! I am ok with backporting too. - Jan Hambrecht On

Re: Review Request: Fix loading of embedded svg graphics.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105589/#review16064 --- Ship it! Ship It! - Jan Hambrecht On July 18, 2012, 5:15

Re: Review Request: Fix loading of embedded svg graphics.

e the mimetype by content into the KoOdfLoadingContext::mimeTypeForPath method? Then all code using that function can benefit from a more robust mimetype handling. Otherwise it looks ok to me too. - Jan Hambrecht On July 16, 2012, 10:19 a.m., Thorsten Zachmann

Re: Review Request: remove spacing around canvas in Karbon

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104745/#review12960 --- Ship it! Ship It! - Jan Hambrecht On April 26, 2012, 8:08

Re: ClipPath and loading and saving

On 26.04.2012 10:52, C. Boemann wrote: On Monday 23 April 2012 19:53:55 C. Boemann wrote: Hi I'm working on tight text runaround, and it turns out that LO/OO saves the outline in a contour-polygon element child of frame No I have also looked and Jan created KoClipPath sometime last year, but I

Re: Review Request: Recreate the XFig import filter

big improvement having a working filter instead of a disabled one. - Jan Hambrecht On March 17, 2012, 11:43 a.m., Friedrich W. H. Kossebau wrote: > > --- > This is an automatically generated e-mail. To reply, visi

Re: XFig import filter revived in branch filters-karbon-xfig-recreate2012

On 05.03.2012 01:50, Friedrich W. H. Kossebau wrote: Hi, I just pushed an inital rewrite of the XFig import filter as a branch filters-karbon-xfig-recreate2012 on the main repo. The filter already converts a big part of the xfig 3.2 format to ODG in its current state. Work left to do: *

Re: Review Request: Fixes multi-line artistic text being saved with wrong coordinates for second and following lines

change and use the 3 lines from the else block to save the text position and transformation. Hope you don't mind after coming up with a working fix. - Jan Hambrecht On Feb. 29, 2012, 3:50 a.m., Friedrich W. H. Kossebau wrote: > >

Re: Review Request: s/Karbon14/Karbon/g for all translated strings

> On Feb. 29, 2012, 9:11 p.m., Jan Hambrecht wrote: > > Sure ask them and hopefully it is too much work for them. Well _not_ too much work, of course. - Jan --- This is an automatically generated e-mail. To reply, vi

Re: Review Request: s/Karbon14/Karbon/g for all translated strings

them. - Jan Hambrecht On Feb. 29, 2012, 7:36 p.m., Friedrich W. H. Kossebau wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.

Re: Review Request: s/Karbon14/Karbon/g for all untranslated strings

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104122/#review11034 --- Ship it! Please go ahead. - Jan Hambrecht On Feb. 29, 2012

Re: Review Request: Added Microsoft Visio and Works import filters, updated WordPerfect Document/Graphics import filters

generate svg. - Jan Hambrecht On Feb. 19, 2012, 2:42 a.m., Yue Liu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.

Re: Review Request: Add config option to make grid shown behind the shapes in kopageapp

visible option. If you decide to paint the grid behind shapes for flow/stage, then just do that. With your patch all applications using the grid config page would have that option present in their configuration dialog, even if they are not using that flag in any way. - Jan Hambrecht On Dec. 21

Re: some code warnings

On Monday 05 December 2011 13:01:12 Jaime wrote: > Hi, > > Searching for dead code, I've seen some code that I do not know how > to handle (not included in this list code that has a //todo or > similar).. > > In case they are intended, please add a comment with a todo or fixme > or whatever (or

Re: Review Request: Add markers (arrows and other stuff put at the end of a line)

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103152/#review8402 --- Ship it! Ship It! - Jan Hambrecht On Nov. 20, 2011, 7:09

Re: Review Request: Add markers (arrows and other stuff put at the end of a line)

> On Nov. 19, 2011, 12:14 a.m., Jan Hambrecht wrote: > > libs/flake/KoMarkerCollection.h, line 32 > > <http://git.reviewboard.kde.org/r/103152/diff/2/?file=41215#file41215line32> > > > > I would have expected the marker collection to be derived from > >

Re: Review Request: Add markers (arrows and other stuff put at the end of a line)

> On Nov. 19, 2011, 12:14 a.m., Jan Hambrecht wrote: > > Apart from the comments below I noticed that there is quite a lot of > > documentation missing. Forgot to say: Great work! - Jan --- This is an automatically g

Re: Review Request: Add markers (arrows and other stuff put at the end of a line)

to be eadier to digest? libs/flake/KoPathShape.cpp <http://git.reviewboard.kde.org/r/103152/#comment7102> I think there should be a strong warning in the documentation of this method that is does change internal data while bein

Re: Review Request: Add PDF support to KOConverter

ttp://git.reviewboard.kde.org/r/102837/#comment6363> I think you should check for a null pointer before defererencing. - Jan Hambrecht On Oct. 12, 2011, 2:21 p.m., Dan Leinir Turthra Jensen wrote: > > --- > This is an automatically generated e

Re: Review Request: Rectangular and square gradient support

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102780/#review7230 --- Ship it! Loks ok to me. - Jan Hambrecht On Oct. 10, 2011, 1

Re: Review Request: Pass KoCanvasBase in shape paint methods (just like for paintDecoration)

only argument to the paint functions. - Jan Hambrecht On Oct. 9, 2011, 5:10 p.m., C. Boemann wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.

Re: Review Request: make it possible to read properties from different property types.

ould be good to check for an empty string here. - Jan Hambrecht On Sept. 29, 2011, 1:28 p.m., Thorsten Zachmann wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.revi

Re: Review Request: Fix regression in size of shape groups with a lot of shapes

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102645/#review6744 --- Ship it! All in all I think you can commit. However while looki

Re: Review Request: Store anchor info directly in shapes through a simple userdata like set of methods in KoShape

> On Sept. 19, 2011, 8:34 p.m., Jan Hambrecht wrote: > > Is there any reason why you are not using > > KoShape::setApplicationData/KoShape::applicationData? > > C. Boemann wrote: > yes it already used for kotextshapedata in text shapes I only found places where a

Re: Review Request: Store anchor info directly in shapes through a simple userdata like set of methods in KoShape

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102666/#review6641 --- Is there any reason why you are not using KoShape::setApplicati

Re: Review Request: Fix regression in size of shape groups with a lot of shapes

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102645/#review6618 --- First I think in general it would be nice to have. I have two th

Re: Review Request: Fix regression of group shape size

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102633/ --- (Updated Sept. 16, 2011, 4:52 p.m.) Review request for Calligra. Changes

Re: Review Request: Add frame preview support (aka PNG/SVG Previews)

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102512/#review6578 --- Ship it! I have nothing more to complain about. So if ctester a

Re: Review Request: Add frame preview support (aka PNG/SVG Previews)

> On Sept. 16, 2011, 12:33 p.m., Jan Hambrecht wrote: > > libs/flake/KoShapeRegistry.cpp, line 169 > > <http://git.reviewboard.kde.org/r/102512/diff/5/?file=36175#file36175line169> > > > > Excessive whitespace, please remove. > > Inge Wallin wrote

Re: Review Request: Add frame preview support (aka PNG/SVG Previews)

> On Sept. 16, 2011, 12:33 p.m., Jan Hambrecht wrote: > > libs/flake/KoShapeRegistry.cpp, line 169 > > <http://git.reviewboard.kde.org/r/102512/diff/5/?file=36175#file36175line169> > > > > Excessive whitespace, please remove. > > Inge Wallin wrote

Re: Review Request: Add frame preview support (aka PNG/SVG Previews)

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102512/#review6566 --- libs/flake/KoShapeRegistry.cpp

Re: Review Request: Create text box when double click in default tool

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102629/#review6563 --- I would suggest adding such application specific code to your ap

Review Request: Fix regression of group shape size

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102633/ --- Review request for Calligra. Summary --- There was a regression intro

Re: Review Request: Make it possible to get a all draw styles of a defined type.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102562/#review6419 --- Ship it! Please changes the small additional thing I commented

Re: Review Request: Make it possible to get a all draw styles of a defined type.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102562/#review6418 --- Ship it! Please changes the small additional thing I commented

Re: Review Request: Make it possible to get a all draw styles of a defined type.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102562/#review6371 --- libs/odf/KoOdfStylesReader.h

Re: Review Request: Add frame preview support (aka PNG/SVG Previews)

> On Sept. 2, 2011, 7:53 p.m., Jan Hambrecht wrote: > > libs/flake/KoShapeRegistry.cpp, lines 241-247 > > <http://git.reviewboard.kde.org/r/102512/diff/3/?file=33369#file33369line241> > > > > I suppose this part can be removed now. > > Dan Leinir Turth

Re: Review Request: Add frame preview support (aka PNG/SVG Previews)

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102512/#review6246 --- libs/flake/KoShapeRegistry.cpp

Re: Review Request: Add frame preview support (aka PNG/SVG Previews)

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102512/#review6221 --- It would make it easier to review if you would diff against a mo

Re: Review Request: Add svg support to the flake library

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102315/ --- (Updated Aug. 23, 2011, 7:07 p.m.) Review request for Calligra. Changes

Re: User interface issues

On 23.08.2011 10:43, Boudewijn Rempt wrote: * Selecting a shape is quite difficult. Depending on the active tool, a click can select a shape, manipulate a shape or do nothing. One proposal is to show a border on hover that when clicked will always select the shape and that will allow basic ma

Re: Review Request: Add svg support to the flake library

y to fix that. > > > > 2. Merging the two functions from SvgSerializable into KoShape. If we want > > to do that we would depend on the svg classes and separating them from > > flake would no longre be possible. > > > > I'm all for it as it would make the

Re: Review Request: Add svg support to the flake library

On Sunday 21 August 2011 16:13:13 Boudewijn Rempt wrote: > On Sunday 21 August 2011 Aug, Jan Hambrecht wrote: > > > Does the VectorShape load svg content? > > > > There are actually 2 shapes advertizing themselves as reading anything > > having a mimetype start

Re: Review Request: Add svg support to the flake library

into KoShape. - Jan --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102315/#review5866 --- On Aug. 20, 2011, 11:05 a.m., Jan H

Re: [calligra] /: basic support for group shadow and shadow after filter effect

On Sunday 21 August 2011 10:34:02 Yue Liu wrote: > Git commit 8cfdbbd52503fcdacc38becd746c9e8d421fb639 by Yue Liu. > Committed on 20/04/2011 at 17:01. > Pushed by liu into branch 'master'. > > basic support for group shadow and shadow after filter effect Yue, I wonder what makes you decide to com

Review Request: Remove class KoPointGroup from flake

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102389/ --- Review request for Calligra. Summary --- The class KoPointGroup is no

Re: Review Request: Add svg support to the flake library

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102315/ --- (Updated Aug. 20, 2011, 11:05 a.m.) Review request for Calligra. Changes

Re: Review Request: read XML in the rigth way. ie. \n has 5 nodes, not 3

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101857/#review5803 --- If you fix the things I commented on, I think it can go in. li

Re: Review Request: read XML in the rigth way. ie. \n has 5 nodes, not 3

> On Aug. 16, 2011, 5:45 p.m., Jan Hambrecht wrote: > > Instead of passing a new bool parameter to all these methods of > > KoXmlReader, I would prefer having a single function > > setWhitespaceStrippingEnabled. This sets an internal flag which can be used > >

Re: Review Request: read XML in the rigth way. ie. \n has 5 nodes, not 3

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101857/#review5767 --- libs/odf/KoXmlReader.cpp

Re: Review Request: read XML in the rigth way. ie. \n has 5 nodes, not 3

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101857/#review5747 --- Instead of passing a new bool parameter to all these methods of

Re: Review Request: Add svg support to the flake library

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102315/ --- (Updated Aug. 13, 2011, 4:53 p.m.) Review request for Calligra. Changes

Review Request: Add svg support to the flake library

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102315/ --- Review request for Calligra. Summary --- This patch adds support for

Re: Review Request: read XML in the rigth way. ie. \n has 5 nodes, not 3

> On Aug. 6, 2011, 5:04 p.m., Sebastian Sauer wrote: > > Thinking a bit more in my opinion we should not change how whitespaces are > > handled atm if there is no good reason for it (like a performance-boost or > > ...). The "2.10 White Space Handling" section from > > http://www.w3.org/TR/REC

Re: Review Request: Added support for drawing the shadow for a shape group, fixed shadow blur zooming bug.

> On Aug. 3, 2011, 4:55 p.m., Jan Hambrecht wrote: > > libs/flake/KoShapeGroup.cpp, lines 63-76 > > <http://git.reviewboard.kde.org/r/102072/diff/4/?file=30652#file30652line63> > > > > A group shape can also have filter effects applied, so that mu

Re: Review Request: Added support for drawing the shadow for a shape group, fixed shadow blur zooming bug.

> On Aug. 3, 2011, 4:55 p.m., Jan Hambrecht wrote: > > libs/flake/KoShapeShadow.cpp, lines 358-361 > > <http://git.reviewboard.kde.org/r/102072/diff/4/?file=30654#file30654line358> > > > > Where is the number 3 comming from. Shouldn't d->blur be the e

Re: Review Request: Added support for drawing the shadow for a shape group, fixed shadow blur zooming bug.

> On Aug. 3, 2011, 7:40 a.m., Boudewijn Rempt wrote: > > I think the fix to set the size of the group shape simply to zero is wrong. The filter effects can be applied to a group and these need a proper size of a shape to work correctly. - Jan ---

Re: Review Request: Added support for drawing the shadow for a shape group, fixed shadow blur zooming bug.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102072/#review5357 --- libs/flake/KoShapeShadow.cpp

Re: Review Request: Added support for drawing the shadow for a shape group, fixed shadow blur zooming bug.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102072/#review5355 --- libs/flake/KoShapeGroup.cpp

Re: Review Request: Added support for drawing the shadow for a shape group, fixed shadow blur zooming bug.

> On July 31, 2011, 9:37 p.m., Jan Hambrecht wrote: > > I just tested your code, looks good so far. Regarding the painting > > artifacts while moving, I think these are caused by not taking the blur > > radius into account when calculating the insets of the shado

Re: Review Request: Added support for drawing the shadow for a shape group, fixed shadow blur zooming bug.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102072/#review5288 --- I just tested your code, looks good so far. Regarding the painti

Re: Review Request: Added support for drawing the shadow for a shape group, fixed shadow blur zooming bug.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102072/#review5127 --- libs/flake/KoShapeGroup.cpp

Re: Review Request: Cleanup documentation and help calls

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102056/#review5011 --- Ship it! I am ok with the Karbon related changes. - Jan On J

Re: enhanced-shape and A,W command definitions

On 18.07.2011 17:43, Lukast dev wrote: > Similar problem is with T and U > > T > Draws a segment of an ellipse. The ellipse is specified by the > center(x, y), the size(w, h) and the start-angle t0 in degrees and > end-angle t1 in degrees. > > U > The same as the “T” command, except that a implied

Re: Review Request: Take tool actions from the actioncollection instead of disable them

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101937/#review4711 --- Ship it! I am ok with it now. - Jan On July 13, 2011, 7:52 p

Re: Review Request: Take tool actions from the actioncollection instead of disable them

> On July 13, 2011, 6:43 p.m., Jan Hambrecht wrote: > > Wouldn't that mean that only the actions of the currently active tool can > > be configured? And I did not find anything related to the toolmanager in > > the backtrace of the bug you mentioned. > > Sven L

Re: Review Request: Take tool actions from the actioncollection instead of disable them

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101937/#review4704 --- Wouldn't that mean that only the actions of the currently active

Re: Review Request: nofill and nostroke support in enhanced path from odf

wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101873/ > --- > > (Updated July 12, 2011, 3:59 p.m.) > > > Review request for Calligra,

Re: Review Request: nofill and nostroke support in enhanced path from odf

- > > (Updated July 12, 2011, 3:59 p.m.) > > > Review request for Calligra, Jan Hambrecht and Thorsten Zachmann. > > > Summary > --- > > This patch implements S and F commands in draw:enhanced-path. So far there > were n

Re: Review Request: read XML in the rigth way. ie. \n has 5 nodes, not 3

> On July 5, 2011, 5:18 p.m., Thorsten Zachmann wrote: > > For me that looks quite wrong. The tests you changed should work even if > > there is a space at the beginning of the line. That is definitely something > > that needs very deep testing fotr that I need some time to see it does not > >

Re: Switching shapes and tools: is it broken?

On 21.06.2011 10:47, Dag Andersen wrote: > Mandag 20 juni 2011 22:37:10 skrev ja...@gmx.net: >> On Monday 20 June 2011 15:31:28 Dag Andersen wrote: >>> Mandag 20 juni 2011 15:20:27 skrev du: On 20.06.2011 13:02, Dag Andersen wrote: > Mandag 20 juni 2011 11:37:13 skrev du: >> On 20.06.2

Re: Switching shapes and tools: is it broken?

On 20.06.2011 10:34, Dag Andersen wrote: > Before the weekend I fixed a crash in ArtisticTextShape and, as Jan Hambrect > pointed out, I unvittingly removed the functionallity to go direct between > shapes. So I thought I'd find out how this *should* be implemented before I > tried to put it back,

Review Request: Fix conflicting tool actions

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101468/ --- Review request for Calligra. Summary --- At them moment there is a pr

Re: Review Request: Allow enhancedpath to draw full circle with one command

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101150/#review2753 --- Ship it! Seems sensible to do. - Jan On April 18, 2011, 8:59

Re: Review Request: Share handle radius and grab sensitivity via the document resource

ed to determine if the handle is hit. - Jan --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100938/#review2183 ------- On Ma

Review Request: Share handle radius and grab sensitivity via the document resource

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100938/ --- Review request for Calligra. Summary --- This patch changes the scope

Re: Review Request: Paste shapes at cursor position

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100891/ --- (Updated March 20, 2011, 8:49 p.m.) Review request for Calligra. Changes

Re: Review Request: Paste shapes at cursor position

his is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100891/#review2054 --- On March 19, 2011, 8:30 p.m., Jan Hambrecht wrote: > > -

Re: Review Request: Paste shapes at cursor position

-mail. To reply, visit: http://git.reviewboard.kde.org/r/100891/#review2057 ------- On March 19, 2011, 8:30 p.m., Jan Hambrecht wrote: > > --- > This is an automa

Review Request: Paste shapes at cursor position

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100891/ --- Review request for Calligra. Summary --- Patch provides an alternativ

Re: Review Request: Support for svg like clipping for shapes

sit: http://git.reviewboard.kde.org/r/100809/#review1925 --- On March 13, 2011, 12:23 a.m., Jan Hambrecht wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.

Re: Review Request: Support for svg like clipping for shapes

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100809/ --- (Updated March 13, 2011, 12:23 a.m.) Review request for Calligra. Change

Review Request: Support for svg like clipping for shapes

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100809/ --- Review request for Calligra. Summary --- This patch implements clippi

Re: Review Request: Complete support for ODF glue points

To reply, visit: http://git.reviewboard.kde.org/r/100447/#review1099 ----------- On Jan. 27, 2011, 11:08 p.m., Jan Hambrecht wrote: > > --- > This is an automaticall

Re: Review Request: Complete support for ODF glue points

7/diff/1/?file=7624#file7624line279> > > > > there should be a blank after the if Ok - Jan --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100447/#review1085 --- On Jan. 27

Re: Review Request: Complete support for ODF glue points

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100447/ --- (Updated Jan. 27, 2011, 11:08 p.m.) Review request for Calligra. Changes

Re: Review Request: Complete support for ODF glue points

s is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100447/#review1087 ----------- On Jan. 26, 2011, 10:48 p.m., Jan Hambrecht wrote: > > --- &

Review Request: Complete support for ODF glue points

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100447/ --- Review request for Calligra. Summary --- This patch properly implemen

Re: kplato compile problem on windows

On 24.01.2011 08:57, Pierre Stirnweiss wrote: > As some of may know, I am trying to get Calligra to compile on Windows > MSVC2010. I have encountered a couple of problems, which were easy > enough to solve (with the help of SaroEngels). > The one I am facing now is apparently way more complicated:

Review Request: Force no backgound on connection shapes

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100259/ --- Review request for Calligra. Summary --- This patch removes the backg

Re: Review Request: Few fixes to pathshape/enhancedpath

> On 2010-12-27 23:16:49, Jan Hambrecht wrote: > > plugins/pathshapes/enhancedpath/EnhancedPathCommand.cpp, line 103 > > <http://git.reviewboard.kde.org/r/100254/diff/1/?file=5715#file5715line103> > > > > The ODF specification does really lack in that secti

Re: Review Request: Few fixes to pathshape/enhancedpath

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100254/#review641 --- plugins/pathshapes/enhancedpath/EnhancedPathCommand.cpp