----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101937/#review4711 -----------------------------------------------------------
Ship it! I am ok with it now. - Jan On July 13, 2011, 7:52 p.m., Sven Langkamp wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101937/ > ----------------------------------------------------------- > > (Updated July 13, 2011, 7:52 p.m.) > > > Review request for Calligra. > > > Summary > ------- > > Currently all tool actions are added at start and then disabled and enabled. > Bug 276150 shows a problem with that: The actions that are colliding with the > actions of the new active tool are disabled on activation and enabled at > deactivation. This causes a bug when the first tools activate tool actions > for non active tools. > > The patch solves the problem by adding the action on tool activation and > takeing it from the action collection on deactivation. > > > This addresses bug 276150. > http://bugs.kde.org/show_bug.cgi?id=276150 > > > Diffs > ----- > > libs/flake/KoToolManager.cpp 1807fc4 > > Diff: http://git.reviewboard.kde.org/r/101937/diff > > > Testing > ------- > > Works with steps from bug 276150 > > > Thanks, > > Sven > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
