----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102072/#review5355 -----------------------------------------------------------
libs/flake/KoShapeGroup.cpp <http://git.reviewboard.kde.org/r/102072/#comment4838> A group shape can also have filter effects applied, so that must be taken into account too. And I think that now the group shape has a proper boundingRect() function, the size() function should return a correct size too. libs/flake/KoShapeShadow.h <http://git.reviewboard.kde.org/r/102072/#comment4840> Not needed anymore. libs/flake/KoShapeShadow.h <http://git.reviewboard.kde.org/r/102072/#comment4841> Not needed anymore libs/flake/KoShapeShadow.h <http://git.reviewboard.kde.org/r/102072/#comment4842> Not needed anymore. libs/flake/KoShapeShadow.cpp <http://git.reviewboard.kde.org/r/102072/#comment4839> Where is the number 3 comming from. Shouldn't d->blur be the exact blur radius? - Jan On Aug. 3, 2011, 7:20 a.m., Yue Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102072/ > ----------------------------------------------------------- > > (Updated Aug. 3, 2011, 7:20 a.m.) > > > Review request for Calligra. > > > Summary > ------- > > Added support for drawing the shadow for a shape group, fixed shadow blur > zooming bug. > > > Diffs > ----- > > libs/flake/KoShapeContainer.cpp e7585ec > libs/flake/KoShapeGroup.h 5ccd574 > libs/flake/KoShapeGroup.cpp aaa58b4 > libs/flake/KoShapeShadow.h 07c760c > libs/flake/KoShapeShadow.cpp 5485b19 > libs/flake/tests/TestShapeGroupCommand.cpp 397c17b > libs/widgets/KoShadowConfigWidget.cpp 1a41042 > plugins/dockers/shadowdocker/ShadowDocker.cpp ef53fae > > Diff: http://git.reviewboard.kde.org/r/102072/diff > > > Testing > ------- > > http://my.cdash.org/viewTest.php?onlydelta&buildid=212010 > > > Screenshots > ----------- > > groupshadow / shape shadow > http://git.reviewboard.kde.org/r/102072/s/210/ > > > Thanks, > > Yue > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
