Re: More qt5 port notes

2015-06-08 Thread Arjen Hiemstra
On Monday 08 June 2015 17:43:24 Boudewijn Rempt wrote: > I also talked about the opengl canvas problems with kwin maintainer Martin > Graesslin. He was pretty clear that Qt's undocumented qglfunctions thing > is rather badly designed, and he said to use libepoxy instead of either > that or our glew

Re: Review Request 120890: Supporting changes for Calligra Gemini

2014-11-01 Thread Arjen Hiemstra
these components, meaning these are a temporary solution at best. - Arjen Hiemstra On Oct. 31, 2014, 11:36 a.m., Dan Leinir Turthra Jensen wrote: > > --- > This is an automatically generated e-mail. To reply, visit

Re: Review Request 120890: Supporting changes for Calligra Gemini

2014-11-01 Thread Arjen Hiemstra
> On Oct. 29, 2014, 6:49 p.m., Friedrich W. H. Kossebau wrote: > > words/part/frames/KWCopyShape.cpp, line 170 > > > > > > Hm, I prefer the parameter names being written and marked with > > Q_UNUSED. Here both s

Re: Review Request 112883: Workaround for flickering in OpenGL 2 canvas on AMD graphic cards

2013-09-22 Thread Arjen Hiemstra
3d graphics, I'm not really surprised things like this are needed. - Arjen Hiemstra On Sept. 22, 2013, 11:01 a.m., Sven Langkamp wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.re

Review Request 112827: Move the View Mode button from KisPaintOpPresetsChooserPopup to KoResourceItemChooser

2013-09-19 Thread Arjen Hiemstra
Attachments After the change http://git.reviewboard.kde.org/media/uploaded/files/2013/09/19/viewmodebutton_after.png Before the change http://git.reviewboard.kde.org/media/uploaded/files/2013/09/19/viewmodebutton_before.png Thanks, Arjen Hiemstra

Re: Calligra 3.0 for Qt 5.1?

2013-07-30 Thread Arjen Hiemstra
On Monday 29 July 2013 20:44:03 Boudewijn Rempt wrote: > * check whether an autosave document belongs to another open instance of an > application * remote slideshow management for Stage > * IPC for the kioslaves. I need to check, though, there used to be an effort > to make kioslaves run in-proces

Re: Review Request 111391: Make the canvas input configurable

2013-07-04 Thread Arjen Hiemstra
://git.reviewboard.kde.org/media/uploaded/files/2013/07/04/dialog1.png Edit Profiles Dialog http://git.reviewboard.kde.org/media/uploaded/files/2013/07/04/dialog2.png Thanks, Arjen Hiemstra ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org

Review Request 111391: Make the canvas input configurable

2013-07-04 Thread Arjen Hiemstra
.png Thanks, Arjen Hiemstra ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request 109393: a new library for traversing odf files and a new export filter

2013-03-23 Thread Arjen Hiemstra
basics are good to go. - Arjen Hiemstra On March 20, 2013, 8:35 p.m., Inge Wallin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.review

Review Request 109149: Increase size of QPixmapCache to prevent flickering and infinte redraw in PictureShape

2013-02-25 Thread Arjen Hiemstra
/ Testing --- Build and run. Tested the pictureshape and it no longer flickers when overlapping. Thanks, Arjen Hiemstra ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request 109071: Add a PRODUCTSET build config parameter (values ACTIVE, CREATIVE, DESKTOP, ALL)

2013-02-25 Thread Arjen Hiemstra
ceivable that someone wants to build it without building Flow or Stage. libs/CMakeLists.txt <http://git.reviewboard.kde.org/r/109071/#comment20981> Is this a separate library from KoReport? If so, see the comment above. If not, can we change the todo to move it to somewhere part of K

Review Request 109140: Prevent infinte recursion in PictureShape/SelectionRect due to floating-point errors

2013-02-25 Thread Arjen Hiemstra
point errors before recursing. Diffs - plugins/pictureshape/SelectionRect.cpp c3a9a2d Diff: http://git.reviewboard.kde.org/r/109140/diff/ Testing --- Compiled and run. Cropping on image rect still works. Thanks, Arjen Hiemstra ___ cal

Re: Review Request 108861: Improved Table handling for the HTML export filter

2013-02-11 Thread Arjen Hiemstra
ke what it looks like in Words. Thanks, Arjen Hiemstra ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request 108861: Improved Table handling for the HTML export filter

2013-02-11 Thread Arjen Hiemstra
visit: http://git.reviewboard.kde.org/r/108861/#review26999 ------- On Feb. 8, 2013, 4:34 p.m., Arjen Hiemstra wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/108861/ >

Review Request 108861: Improved Table handling for the HTML export filter

2013-02-08 Thread Arjen Hiemstra
more like what it looks like in Words. Thanks, Arjen Hiemstra ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request 108569: Flake ConfigWidgets and user friendly interface

2013-01-24 Thread Arjen Hiemstra
like to see a cleanup of this as a follow up though, since you are already busy with other parts of this UI. Please consider the comments for that follow-up. - Arjen Hiemstra On Jan. 24, 2013, 2:12 p.m., Jean-Nicolas Artaud wrote: > >

Re: Re: UI idea: Turn the status bar into a docker (or several dockers)

2012-08-31 Thread Arjen Hiemstra
On Friday 31 August 2012 09:32:04 Boudewijn Rempt wrote: > On Thursday 30 August 2012 Aug, Thomas Pfeiffer wrote: > > > I'm starting to think that a general "layout configuration mode" switch like in > > Amarok may be useful for Calligra in general (however it should be less hidden > > then in

Re: Review Request: Introduce Author into the Calligra family

2012-08-19 Thread Arjen Hiemstra
ged in. Might want to check which of them are really necessary and remove those that are not. words/part/author/author_readonly.rc <http://git.reviewboard.kde.org/r/106064/#comment13867> Does it need a read only UI? To me that does not make much sense. Also, version again. -

Re: Review Request: Fix for text input in Krita text shapes

2012-07-24 Thread Arjen Hiemstra
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105625/#review16307 --- Ship it! Ship It! - Arjen Hiemstra On July 24, 2012, 3:43

Re: Review Request: Fix for text input in Krita text shapes

2012-07-24 Thread Arjen Hiemstra
w. Anyway, looks fine to me, just a few minor comments. - Arjen Hiemstra On July 19, 2012, 6:55 p.m., Sven Langkamp wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.review

Re: Review Request: Fix for text input in Krita text shapes

2012-07-24 Thread Arjen Hiemstra
krita/ui/input/kis_input_manager.cpp <http://git.reviewboard.kde.org/r/105625/#comment12800> The setter here is a little superfluous considering you're changing a private variable anyway. - Arjen Hiemstra On July 19, 2012, 6:

Re: Review Request: Implement the basics of the Canvas Interaction proposal

2012-06-15 Thread Arjen Hiemstra
wing using this code. The basic concept works very well and most of the actions are fairly intuitive, but the recognition code needs improvement. Thanks, Arjen Hiemstra ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailma

Re: Review Request: Implement the basics of the Canvas Interaction proposal

2012-06-14 Thread Arjen Hiemstra
c concept works very well and most of the actions are fairly intuitive, but the recognition code needs improvement. Thanks, Arjen Hiemstra ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request: Implement the basics of the Canvas Interaction proposal

2012-06-14 Thread Arjen Hiemstra
very well and most of the actions are fairly intuitive, but the recognition code needs improvement. Thanks, Arjen Hiemstra ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request: Implement the basics of the Canvas Interaction proposal

2012-06-14 Thread Arjen Hiemstra
ks very well and most of the actions are fairly intuitive, but the recognition code needs improvement. Thanks, Arjen Hiemstra ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Review Request: Implement the basics of the Canvas Interaction proposal

2012-06-14 Thread Arjen Hiemstra
. Thanks, Arjen Hiemstra ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request: Delayed Search: Give the user a chance to enter the whole word before begining search

2012-05-21 Thread Arjen Hiemstra
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104996/#review14022 --- Ship it! Seems to be fine now. - Arjen Hiemstra On May 20

Re: Calligra sprint in Randa?

2012-05-21 Thread Arjen Hiemstra
On Monday 21 May 2012 02:07:21 Inge Wallin wrote: > I have been asked by Mario Fux (unormal) about whether the Calligra > community is interested in participating in a big sprint in september. You > can see the relevant doodle here: http://www.doodle.com/svghf38ibdg6k9dv . > > This will be held i

Re: Review Request: Delayed Search: Give the user a chance to enter the whole word before begining search

2012-05-19 Thread Arjen Hiemstra
Timer instead of a direct object. QObject based classes should generally be constructed on the heap. libs/main/KoFindToolbar.cpp <http://git.reviewboard.kde.org/r/104996/#comment11092> Since you're using a single shot timer anyway, there is no need to call stop(). -

Re: Preparing MWC

2012-02-16 Thread Arjen Hiemstra
On Thursday 16 February 2012 12:37:58 Alex Fiestas wrote: > > I know, I was wondering if there is any update I don't have installed > and I should > There's a PR1.2 beta for the N950, which is the most recent version as far as I know. ___ calligra-deve

Re: removing module specifiers from includes

2012-02-06 Thread Arjen Hiemstra
On Monday 06 Feb 2012 15:13:01 Boudewijn Rempt wrote: > Hi, > > I've got a patch ready that changes all style includes to > . The reason is that with Qt5, QtGui will split into QtGui and > QtWidgets. > > The module specifiers actually only lead to churn, and there is no > discernable advantage t

Re: Review Request: Enable search from cursor position in the backend

2011-09-16 Thread Arjen Hiemstra
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102617/#review6565 --- Ship it! As discussed on IRC. - Arjen On Sept. 16, 2011, 10:

Re: Review Request: Enable search from cursor position in the backend

2011-09-16 Thread Arjen Hiemstra
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102617/#review6564 --- Ship it! As discussed on IRC. - Arjen On Sept. 16, 2011, 10:

Re: Features changelog for Calligra 2.4 Beta

2011-09-12 Thread Arjen Hiemstra
On Sunday 11 September 2011 16:24:02 C. Boemann wrote: > > Calligra sees a new wordprocessor named Words. Though it has a heritage from > KOffice's KWord it can in many ways be seen as a completly new appliction. > We still have not addressed the user interface, and know we are not yet > near what

Re: Bugs with patches (remove close toolbar-button)

2011-06-21 Thread Arjen Hiemstra
On Tuesday 21 June 2011 09:55:15 Boudewijn Rempt wrote: > > I like the idea of a view lock; especially if it would also lock the > height/width/position of the dockers. If it just removes the close button, > I don't see much value for it, at least not in krita. The problem with this is that this

Re: reviewrequest

2011-06-09 Thread Arjen Hiemstra
On Monday 06 June 2011 13:31:55 Boudewijn Rempt wrote: > > Another note: some of our code uses namespaces, we started to use > > Calligra namespace too. How about removing Ko prefix and have Calligra > > for public libs, and optionally {appname} for apps (if app maintainer > > agrees)? > > Well, I

Review Request: Add an initial implementation of KoFind to Tables

2011-05-05 Thread Arjen Hiemstra
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101295/ --- Review request for Calligra and Marijn Kruisselbrink. Summary --- Thi

Re: Review Request: Refactor of KoFind to a general interface for searching

2011-04-07 Thread Arjen Hiemstra
did not really consider it important to use a UI file for what essentially amounts to some widgets next to each other. I can change it to make use of one, though. - Arjen --- This is an automatically generated e-mail. To reply, visit: http

Review Request: Refactor of KoFind to a general interface for searching

2011-04-07 Thread Arjen Hiemstra
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101045/ --- Review request for Calligra, Marijn Kruisselbrink, Boudewijn Rempt, Thorsten

Re: Review Request: Fix for Reducing the various hardcoded zoomlevel based on usability feedback from Anna

2011-04-05 Thread Arjen Hiemstra
> On April 4, 2011, 6:31 a.m., Casper Boemann wrote: > > I think the 100% should staty. That is what Anna-lisa said too > > > > Also I'm not either for or against it, but the options in the widget in the > > bottom corner is removed too with this patch > > Suresh Chande wrote: > by "but th

Re: breaking unittests is BAD

2011-03-07 Thread Arjen Hiemstra
On Monday 07 March 2011 06:40:15 Boudewijn Rempt wrote: > 183 - libs-widgets-zoomhandler_test (Failed) > > Arjen: you were going to fix this test -- please do that today! > Yeah, I fixed it today though I'm not entirely happy with the solution. There is a zoomcontroller_test where I wan

Re: Review Request: Limit zooming to a minimum and maximum zoom value

2011-02-09 Thread Arjen Hiemstra
at the dropdown supplies instead. - Arjen --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100613/#review1319 ------- On Fe

Review Request: Limit zooming to a minimum and maximum zoom value

2011-02-08 Thread Arjen Hiemstra
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100613/ --- Review request for Calligra. Summary --- This bug fixes an issue with

Introducing myself

2011-01-14 Thread Arjen Hiemstra
Hello People, My name is Arjen Hiemstra. With this mail I would like to introduce myself to the rest of the Calligra community. I started working for KO GmbH this month and so I will also be involved in Calligra development. I started contributing to KDE in September 2009, when I joined the