> On April 4, 2011, 6:31 a.m., Casper Boemann wrote: > > I think the 100% should staty. That is what Anna-lisa said too > > > > Also I'm not either for or against it, but the options in the widget in the > > bottom corner is removed too with this patch > > Suresh Chande wrote: > by "but the options in the widget in the bottom corner is removed too > with this patch" I guess you are talking about the slider for zooming, right > ?. There was a discussion to add the slider into the zoom. i am not entirely > comfortable as this is not totally according the UI Experience where a slider > exists inside a drop-down menu.
What Casper means is the different zoom levels in the combobox in the bottom left corner. I personally think those should stay, so instead of modifying the zoom action, which provides those zoom levels, you might want to look at the code where these zoom levels are added to the menu. - Arjen ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101022/#review2372 ----------------------------------------------------------- On April 3, 2011, 9:12 p.m., Suresh Chande wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101022/ > ----------------------------------------------------------- > > (Updated April 3, 2011, 9:12 p.m.) > > > Review request for Calligra, Marijn Kruisselbrink, Thorsten Zachmann, and > Casper Boemann. > > > Summary > ------- > > Ok Here comes my first fix.. > > Here is my fix I made to the zoom levels based on discussion and agreement at > the Calligra sprint that we do not want to have 33, 57 and 127 etc % zoom > levels . This fix removes the different zoom levels but leaves fit to width > and fit to page. > > See testing done, Any suggestion how this should be it be fixed for Tables ? > > > Diffs > ----- > > libs/widgets/KoZoomAction.cpp 488652c > > Diff: http://git.reviewboard.kde.org/r/101022/diff > > > Testing > ------- > > This was tested in the Words and Stage application and it functions according > to expected outcome. I tested the Tables it seems as Tables does not have Fit > to Width or Fit to Page the menu is currently empty. > > > Thanks, > > Suresh > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
