> On Feb. 8, 2013, 7:32 p.m., Inge Wallin wrote: > > filters/words/epub/OdtHtmlConverter.cpp, line 481 > > <http://git.reviewboard.kde.org/r/108861/diff/2/?file=113258#file113258line481> > > > > If you want to make full support for tables, you need to implement this > > FIXME as well.
Yeah, I saw that FIXME. However, from what I could find, "handleInsideElementsTag" handles most of what can be considered an HTML "block-level" element so the FIXME only seems relevant in that the method is not named properly. In addition, I was mostly trying to fix the <table-rows> element support, the styling kinda slipped in because it was a fairly obvious fix. - Arjen ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108861/#review26999 ----------------------------------------------------------- On Feb. 8, 2013, 4:34 p.m., Arjen Hiemstra wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/108861/ > ----------------------------------------------------------- > > (Updated Feb. 8, 2013, 4:34 p.m.) > > > Review request for Calligra. > > > Description > ------- > > This changes the HTML filter to more properly handle ODF tables. It now > handles <table:table-header-rows> and <table:table-rows> elements, styling is > applied properly and rowspan is supported. > > Probably the biggest behavioural change is that style names are now filtered > for illegal characters, currently specifically "." which was used in the > table styles. > > > Diffs > ----- > > filters/words/epub/OdtHtmlConverter.h dd753aa > filters/words/epub/OdtHtmlConverter.cpp 6564cd3 > > Diff: http://git.reviewboard.kde.org/r/108861/diff/ > > > Testing > ------- > > Exported both a simple table with no headers and a more complex table with > headers. Both now look much more like what it looks like in Words. > > > Thanks, > > Arjen Hiemstra > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
