D24943: Better charset, unicode and image support for RTF files

davidllewellynjones accepted this revision. davidllewellynjones added a comment. This looks like a nice and useful collection of changes to me. REPOSITORY R8 Calligra BRANCH unicode REVISION DETAIL https://phabricator.kde.org/D24943 To: pvuorela, davidllewellynjones Cc: denexter, davi

D24943: Better charset, unicode and image support for RTF files

pvuorela updated this revision to Diff 68972. pvuorela added a comment. Update image size reading conditions REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24943?vs=6&id=68972 BRANCH unicode REVISION DETAIL https://phabricator.kde.org/D24943 AFFEC

D24943: Better charset, unicode and image support for RTF files

pvuorela marked an inline comment as done. pvuorela added inline comments. INLINE COMMENTS > davidllewellynjones wrote in PictDestination.cpp:101 > The logic is confusing me here I'm afraid. If there's no `\picwgoal` control > word, then `m_goalWidth` will default to 0 and the code above will be

D24943: Better charset, unicode and image support for RTF files

davidllewellynjones added inline comments. INLINE COMMENTS > PictDestination.cpp:101 > +} > +} > + The logic is confusing me here I'm afraid. If there's no `\picwgoal` control word, then `m_goalWidth` will default to 0 and the code above will be skipped. The image w

D24761: Asign correct column width when importing XLS file

davidllewellynjones updated this revision to Diff 68959. davidllewellynjones added a comment. Thanks here also @dcaliste. This is all a bit confusing I agree and deserves some explanation. I've added in something along the lines you suggested, which I think helps (your insight that the scalin

D25008: Add XLSX spreadsheets import optimisations for small/readonly devices

davidllewellynjones updated this revision to Diff 68954. davidllewellynjones added a comment. Thanks @dcaliste, this is an excellent suggestion and much better naming. I've updated the diff to make the changes you suggested. - MSOOXML_IMPORT_READ_ONLY -> MSOOXML_IMPORT_BY_VALUES - MSOOX

calligraplan release

Hi, release planned of calligraplan 3.2.0: Thursday, 2019-11-07. String- and featurefreeze in effect from: Thursday, 2019-10-31. Beta release (3.1.90) on friday, 2019-11-01. --- Cheers, Dag

D25037: Don't drop number styling information from xlsx cell formats which start with a currency symbol.

denexter updated this revision to Diff 68949. denexter added a comment. Removed whitespace changes. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25037?vs=68948&id=68949 REVISION DETAIL https://phabricator.kde.org/D25037 AFFECTED FILES filters/libmso/NumberFormatParser.cpp To

D25037: Don't drop number styling information from xlsx cell formats which start with a currency symbol.

denexter created this revision. denexter added a reviewer: pvuorela. Herald added a project: Calligra: 3.0. Herald added a subscriber: Calligra-Devel-list. denexter requested review of this revision. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D25037 AFFECTED FILES f

D25036: Don't double format spreadsheet currency values with custom format strings.

denexter added a reviewer: pvuorela. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D25036 To: denexter, pvuorela Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D25036: Don't double format spreadsheet currency values with custom format strings.

denexter created this revision. Herald added a project: Calligra: 3.0. Herald added a subscriber: Calligra-Devel-list. denexter requested review of this revision. REVISION SUMMARY If there is a format string for a currency value only format the number and let the format string append or prepend