davidllewellynjones added inline comments. INLINE COMMENTS
> PictDestination.cpp:101 > + } > + } > + The logic is confusing me here I'm afraid. If there's no `\picwgoal` control word, then `m_goalWidth` will default to 0 and the code above will be skipped. The image width will then be set to 0 on line 104: `m_imageFormat.setWidth( 0 );`. Similarly for height. Is this correct? It feels like it might make more sense for the conditions to be reversed. > denexter wrote in PictDestination.cpp:54 > I think picw and pich are source sizes and somewhat meaningless since that > information is encoded in the image. The goal size and scale combine to give > the display size. Thanks for the explanation, that makes sense. Probably these control words are more important for WMFs and the like. > pvuorela wrote in PictDestination.cpp:110 > Yea, could change these too. Though have been pondering of just feeding the > whole rtf-qt through astyle to get consistent formatting and whitespace. I think it needs it, but I appreciate that's not really related to this change. REPOSITORY R8 Calligra BRANCH unicode REVISION DETAIL https://phabricator.kde.org/D24943 To: pvuorela, davidllewellynjones Cc: denexter, davidllewellynjones, Calligra-Devel-list, dcaliste, cochise, vandenoever
