davidllewellynjones updated this revision to Diff 68954. davidllewellynjones added a comment.
Thanks @dcaliste, this is an excellent suggestion and much better naming. I've updated the diff to make the changes you suggested. - MSOOXML_IMPORT_READ_ONLY -> MSOOXML_IMPORT_BY_VALUES - MSOOXML::readonlySpreadsheet() -> MSOOXML::byValuesSpreadsheet() REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25008?vs=68885&id=68954 REVISION DETAIL https://phabricator.kde.org/D25008 AFFECTED FILES CMakeLists.txt filters/libmsooxml/MsooXmlGlobal.cpp filters/libmsooxml/MsooXmlGlobal.h filters/sheets/xlsx/XlsxXmlWorksheetReader.cpp filters/sheets/xlsx/XlsxXmlWorksheetReader_p.h To: davidllewellynjones, #calligra:_3.0, pvuorela, dcaliste Cc: Calligra-Devel-list, davidllewellynjones, dcaliste, cochise, vandenoever
