Telling packagers about runtime deps (was: Re: Calligra licensing and copyright bits)

2014-11-01 Thread Friedrich W. H. Kossebau
Am Freitag, 24. Oktober 2014, 12:22:33 schrieb Boudewijn Rempt: > In general, it's probably a good idea for linux distributions to make Krita > depend on argyll and openicc's profile packages. (I'm not sure if those are > separate in Debian, I'm an opensuse user). For my windows builds, I'll just >

Re: Calligra licensing and copyright bits

2014-11-01 Thread Raúl Sánchez Siles
Hi: I've reformatted and updated the section Jaroslaw created in the wiki [0] [0] https://community.kde.org/Calligra/Libs#Detected_issues_reported_by_Debian There you can see each reported point resolution up to know. Feel free to review and correct it when needed. I'll summarise what'

Re: Review Request 120634: Added possibility of painting kexi report rect elements in all directions

2014-11-01 Thread Wojciech Kosowicz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120634/ --- (Updated Nov. 1, 2014, 11:41 p.m.) Status -- This change has been ma

Review Request 120940: Added parsing of hashtag comments inside imported csv in kexi

2014-11-01 Thread Wojciech Kosowicz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120940/ --- Review request for Calligra, Adam Pigg and Jarosław Staniek. Repository:

Re: Review Request 120634: Added possibility of painting kexi report rect elements in all directions

2014-11-01 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120634/#review69659 --- libs/koreport/wrtembed/KoReportDesignerItemRectBase.cpp

Re: Review Request 120634: Added possibility of painting kexi report rect elements in all directions

2014-11-01 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120634/#review69657 --- Ship it! Other than the minor for, good work, please push to

Re: Review Request 120890: Supporting changes for Calligra Gemini

2014-11-01 Thread Friedrich W. H. Kossebau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120890/#review69655 --- And another round of mostly code-style nitpicks. >From my lit

Re: Review Request 120890: Supporting changes for Calligra Gemini

2014-11-01 Thread Dan Leinir Turthra Jensen
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120890/ --- (Updated Nov. 1, 2014, 5:48 p.m.) Review request for Calligra. Changes

Re: Review Request 120890: Supporting changes for Calligra Gemini

2014-11-01 Thread Dan Leinir Turthra Jensen
> On Nov. 1, 2014, 2:30 p.m., Arjen Hiemstra wrote: > > Please do note that the QtQuick components here are a proof of concept and > > never really got much further than that. There are also Qt5 components > > which have a much better API and overall work much better. I intend to > > merge tho

Re: Review Request 120890: Supporting changes for Calligra Gemini

2014-11-01 Thread Dan Leinir Turthra Jensen
> On Nov. 1, 2014, 6:03 a.m., Thorsten Zachmann wrote: > > qtquick/CQCanvasControllerItem.cpp, line 210 > > > > > > Shouldn't it test that the maximum zoom is bigger then the minimum zoom? it should - and vice v

Re: Review Request 120634: Added possibility of painting kexi report rect elements in all directions

2014-11-01 Thread Wojciech Kosowicz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120634/ --- (Updated Nov. 1, 2014, 5:10 p.m.) Review request for Calligra, Michal Pot

Re: Review Request 120733: Pass more data between layout and RootAreaProvider

2014-11-01 Thread Pierre Ducroquet
> On Oct. 30, 2014, 10 p.m., Camilla Boemann wrote: > > Okay I have had time to look it through and i like how you have merged the > > two chunks of very similar code > > > > Very good work > > > > I only have one small apidox request plus I hope you have run cs tester on > > this, and otherw

Re: Review Request 120890: Supporting changes for Calligra Gemini

2014-11-01 Thread Arjen Hiemstra
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120890/#review69646 --- Please do note that the QtQuick components here are a proof of

Re: Review Request 120890: Supporting changes for Calligra Gemini

2014-11-01 Thread Arjen Hiemstra
> On Oct. 29, 2014, 6:49 p.m., Friedrich W. H. Kossebau wrote: > > words/part/frames/KWCopyShape.cpp, line 170 > > > > > > Hm, I prefer the parameter names being written and marked with > > Q_UNUSED. Here both s

Re: Review Request 120890: Supporting changes for Calligra Gemini

2014-11-01 Thread Dan Leinir Turthra Jensen
> On Nov. 1, 2014, 6:03 a.m., Thorsten Zachmann wrote: > > libs/flake/KoCanvasController.h, line 141 > > > > > > Please move implementation to cpp file. I'd put it there to ensure it was explicit, but of course

Review Request 120935: Add 'Value' property to report items which can contain static data if not bound to a field

2014-11-01 Thread Adam Pigg
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120935/ --- Review request for Calligra, Friedrich W. H. Kossebau and Jarosław Staniek.

Re: Review Request 120875: Krita - Fix proposal for brush speed sensor

2014-11-01 Thread Damien de Lemeny
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120875/ --- (Updated Nov. 1, 2014, 7:44 a.m.) Status -- This change has been dis