----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120935/ -----------------------------------------------------------
Review request for Calligra, Friedrich W. H. Kossebau and Jarosław Staniek. Repository: calligra Description ------- Added a new property to the following report items: check field text barcode Renamed image property 'Static Image' to Value but left saving/loading the same for compatibility. Added a method to KoReportDesignerItemRectBase to store a string used for rendering data in the report designer. Report designer shows the static data if used Includes a bug fix in KRSize which meant recursion was possible Includes a small fix to Text item which caused an infinite loop. Diffs ----- plugins/reporting/barcode/KoReportItemBarcode.cpp 7c6df3928b95277927bac3ad76fb7e6b87c7a3d0 plugins/reporting/barcode/KoReportDesignerItemBarcode.cpp 43acbd067b9f41a7ef36ceedfc9578bbd8cd84b8 plugins/reporting/barcode/KoReportItemBarcode.h f0e7f609e33f3e4a8dc7f84bddedf73e6f236541 libs/koreport/common/krsize.h cc319c0542977e4fa722f337ef0a020fdff2f2c8 libs/koreport/common/krsize.cpp f8c0d7b71fc2bc04c7b72b2c67d70b6564d8c5b4 libs/koreport/items/check/KoReportDesignerItemCheck.cpp ac628616b52b4769232a55af07a51bea9fd80c0a libs/koreport/items/check/KoReportItemCheck.h dcbe271a623b143c6159b00cb5b82ea5cdfcca29 libs/koreport/items/check/KoReportItemCheck.cpp 5bc4318d1906df63917f871c78e00442b8ca92e4 libs/koreport/items/field/KoReportDesignerItemField.cpp f386f9b99c9584f1122fbee542fb708bf5121f16 libs/koreport/items/field/KoReportItemField.h 31cc02526672a57211c8594643f66cd46766d4a4 libs/koreport/items/field/KoReportItemField.cpp d34ec1f9ac2aeb05374a1dca1704244bb27335ee libs/koreport/items/image/KoReportDesignerItemImage.cpp b129299e160c65d1d9f6ed691800e1d6095a5364 libs/koreport/items/image/KoReportItemImage.cpp 65d26cce3c29cb42eb8dc541063a4a52ab3bd6de libs/koreport/items/text/KoReportDesignerItemText.h 3d79fbf7c14493e66e320a76266369f92a5af446 libs/koreport/items/text/KoReportDesignerItemText.cpp 7af69c4840bd910a7a8ee158d2c89d5f9096ed2a libs/koreport/items/text/KoReportItemText.h a43e7f8775bb456c297253eb246d6140a2a86c11 libs/koreport/items/text/KoReportItemText.cpp 20b157593bc4f35c1206e064bb097accacae5dcb libs/koreport/wrtembed/KoReportDesignerItemBase.h 5d43131a78c4697bf511f18103825bcf8bad8657 libs/koreport/wrtembed/KoReportDesignerItemRectBase.cpp 73b7a7073bc5f2fe22266c21ef854fcd13df7854 Diff: https://git.reviewboard.kde.org/r/120935/diff/ Testing ------- Loading/saving each item type Testing each type with: value set, value not set and data source set, data source set and value set Items display correctly in designer Thanks, Adam Pigg
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel