----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120890/#review69655 -----------------------------------------------------------
And another round of mostly code-style nitpicks. >From my little testing of the branch, there were not visible regressions, and >Calligra Gemini at least for the Words part seemed usable. For the 2.9 release >perhaps the Stage part should be disabled I guess, given that the Touch mode >is still only in demo state. Though ideally someone (won't be me sadly) should >get excited about that and perhaps also just make the still-only-demo-mockup >things disabled for the release, so StageTouch could at least be used for >giving presentations (I assume that with a second screen attached the second >screen is hardcoded for the actual slide output?). So my vote as non-maintainer of Stage&Words (thus no Ship it) is that this works good enough to live already in master and gets further polishing and improvements there. active/src/MainWindow.cpp <https://git.reviewboard.kde.org/r/120890/#comment48790> Why this addition? From what I can see Active does not yet use the QtQuick plugins, so this is not (yet) needed. libs/flake/KoToolManager.cpp <https://git.reviewboard.kde.org/r/120890/#comment48791> stamp("please add brackets") libs/kopageapp/KoPADocumentModel.cpp <https://git.reviewboard.kde.org/r/120890/#comment48792> stamp("please add brackets") libs/main/KoView.cpp <https://git.reviewboard.kde.org/r/120890/#comment48793> why the "this->"? left-over when `parent` was named `parentWidget`? libs/main/gemini/ViewModeSwitchEvent.h <https://git.reviewboard.kde.org/r/120890/#comment48794> Please add an explanation why the magic "+10" is used, not obvious to me. qtquick/CMakeLists.txt <https://git.reviewboard.kde.org/r/120890/#comment48795> Why is CMAKE_INSTALL_LIBDIR used here? (And where is it actually from? Could not find a doc about it yet). See also https://git.reviewboard.kde.org/r/120933/ , which proposes to use LIB_INSTALL_DIR instead for the Krita counter parts. qtquick/CQCanvasBase.cpp <https://git.reviewboard.kde.org/r/120890/#comment48796> Hm, qreal usually is passed by value, not const ref, as float/double are small enough so an indirection by pointer/reference is more expensive. qtquick/CQLinkArea.h <https://git.reviewboard.kde.org/r/120890/#comment48798> LINKLAYER does not match LinkArea yet qtquick/CQLinkArea.h <https://git.reviewboard.kde.org/r/120890/#comment48797> * const d qtquick/CQPresentationView.h <https://git.reviewboard.kde.org/r/120890/#comment48799> Q_SLOTS qtquick/CQPresentationView.h <https://git.reviewboard.kde.org/r/120890/#comment48800> Q_SLOTS qtquick/CQSpreadsheetListModel.h <https://git.reviewboard.kde.org/r/120890/#comment48801> explicit qtquick/CQTextDocumentCanvas.cpp <https://git.reviewboard.kde.org/r/120890/#comment48802> -> `deepShapeFind(const QList<KoShape*>& shapes) const` qtquick/CQTextDocumentNotesModel.h <https://git.reviewboard.kde.org/r/120890/#comment48803> Think the usual ``` Q_SIGNALS: void countChanged(); ``` makes this signal easier to see. Not only for consistency. words/part/dockers/KWStatisticsWidget.cpp <https://git.reviewboard.kde.org/r/120890/#comment48804> Don't be so generous with trailing whitespaces ;) words/part/dockers/KWStatisticsWidget.cpp <https://git.reviewboard.kde.org/r/120890/#comment48805> please brackets around - Friedrich W. H. Kossebau On Nov. 1, 2014, 5:48 nachm., Dan Leinir Turthra Jensen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120890/ > ----------------------------------------------------------- > > (Updated Nov. 1, 2014, 5:48 nachm.) > > > Review request for Calligra. > > > Repository: calligra > > > Description > ------- > > The many changes in this patch are all the ones found in the Calligra Gemini > branch. It includes the addition of the Qt Quick compinents created a while > ago by Arjen and Shantanu, as well as a number of changes which improves the > writing performance and experience in Words, especially when dealing with > very large documents. It further extends the template system with support for > variations. > > It does not include the gemini subdirectory itself (and as such to compile > this you would need to check out the branch itself, rather than apply this > patch), the reason being the large amount of data found in this subdirectory > took the patch from the current 233KiB to a nice, solid 55MiB. So, i thought > this would be more useful. > > > Diffs > ----- > > words/part/dockers/KWStatisticsWidget.cpp 63d0384 > words/part/frames/KWCopyShape.cpp 744f292 > words/part/pagetool/KWPageTool.cpp 7935390 > words/templates/Wordprocessing/A4.desktop 8a35eaf > words/templates/Wordprocessing/CMakeLists.txt 88b73fa > words/templates/Wordprocessing/ColorfulA4.desktop 04caf8e > words/templates/Wordprocessing/ColorfulLetter.desktop ce38ab5 > words/templates/Wordprocessing/FaxA4.desktop 2b43998 > words/templates/Wordprocessing/FaxLetter.desktop fc1c161 > words/templates/Wordprocessing/ProfessionalA4.desktop 7c84f34 > words/templates/Wordprocessing/ProfessionalLetter.desktop 5f8b94f > words/templates/Wordprocessing/a4.png PRE-CREATION > words/templates/Wordprocessing/colorful.png PRE-CREATION > words/templates/Wordprocessing/fax.png PRE-CREATION > words/templates/Wordprocessing/professional.png PRE-CREATION > stage/templates/odf/strange_far_hills.png PRE-CREATION > words/part/KWCanvasBase.cpp 0d2d28f > words/part/KWCanvasItem.cpp cfdae98 > words/part/KWGui.cpp 65aedf7 > words/part/KWPageStyle.h a3bf58b > words/part/KWView.h f21f8e3 > words/part/KWView.cpp 1285d21 > words/part/commands/KWShapeCreateCommand.h eb268f8 > words/part/dockers/KWNavigationWidget.cpp 1bb54e0 > words/part/dockers/KWStatisticsWidget.h eac4d44 > stage/templates/odf/skyline_morning.desktop ec4140d > stage/templates/odf/skyline_morning.png PRE-CREATION > stage/templates/odf/skyline_morning_wide.desktop d3337ae > stage/templates/odf/skyline_morning_wide.png PRE-CREATION > stage/templates/odf/skyline_night.desktop 28e3a18 > stage/templates/odf/skyline_night.png PRE-CREATION > stage/templates/odf/skyline_night_wide.desktop e188171 > stage/templates/odf/skyline_night_wide.png PRE-CREATION > stage/templates/odf/strange_far_hills.desktop 1a17807 > stage/templates/odf/hisc-action-cohere-magenta.svgz PRE-CREATION > stage/templates/odf/hisc-action-cohere-red.svgz PRE-CREATION > stage/templates/odf/kde_events.desktop afa4534 > stage/templates/odf/kde_events.png PRE-CREATION > stage/templates/odf/rounded_square.desktop 85015a2 > stage/templates/odf/rounded_square.png PRE-CREATION > stage/templates/odf/simple_waves.desktop dd2bd96 > stage/templates/odf/simple_waves.png PRE-CREATION > stage/templates/odf/skyline_monotone.desktop 0c9dd68 > stage/templates/odf/skyline_monotone.png PRE-CREATION > stage/templates/odf/skyline_monotone_wide.desktop 152c719 > stage/templates/odf/skyline_monotone_wide.png PRE-CREATION > stage/templates/odf/hisc-action-cohere-gold.svgz PRE-CREATION > stage/templates/odf/flood_light.desktop 23adbb2 > stage/templates/odf/flood_light.png PRE-CREATION > stage/templates/odf/hisc-action-cohere-blue.svgz PRE-CREATION > qtquick/CQCanvasController.cpp PRE-CREATION > qtquick/CQCanvasControllerItem.h PRE-CREATION > qtquick/CQCanvasControllerItem.cpp PRE-CREATION > qtquick/CQTextDocumentModel.cpp PRE-CREATION > qtquick/CQTextDocumentNotesModel.h PRE-CREATION > qtquick/CQTextDocumentNotesModel.cpp PRE-CREATION > qtquick/CQTextToCModel.h PRE-CREATION > qtquick/CQTextToCModel.cpp PRE-CREATION > qtquick/CQThumbnailItem.h PRE-CREATION > qtquick/CQThumbnailItem.cpp PRE-CREATION > qtquick/CalligraQtQuickComponentsPlugin.h PRE-CREATION > qtquick/CalligraQtQuickComponentsPlugin.cpp PRE-CREATION > qtquick/qmldir PRE-CREATION > stage/part/KPrView.h b4bab24 > stage/part/KPrView.cpp 1edd8e8 > stage/part/animations/KPrAnimTransitionFilter.cpp 3347fe1 > stage/part/animations/KPrAnimateColor.cpp 59a5e0e > stage/part/animations/KPrAnimateTransform.cpp 914047e > stage/templates/common_desktop/emptyLandscapeWide.desktop c5f8f8a > stage/templates/odf/CMakeLists.txt f7db7d0 > stage/templates/odf/blue_orange_vector.desktop 31dae09 > stage/templates/odf/blue_orange_vector.png PRE-CREATION > stage/templates/odf/burning_desire.desktop ac79022 > stage/templates/odf/burning_desire.png PRE-CREATION > stage/templates/odf/business.desktop d552db3 > stage/templates/odf/business.png PRE-CREATION > stage/templates/odf/cohere-blue.desktop PRE-CREATION > stage/templates/odf/cohere-blue.otp PRE-CREATION > stage/templates/odf/cohere-blue.png PRE-CREATION > stage/templates/odf/cohere-gold.desktop PRE-CREATION > stage/templates/odf/cohere-gold.otp PRE-CREATION > stage/templates/odf/cohere-gold.png PRE-CREATION > stage/templates/odf/cohere-magenta.desktop PRE-CREATION > stage/templates/odf/cohere-magenta.otp PRE-CREATION > stage/templates/odf/cohere-magenta.png PRE-CREATION > stage/templates/odf/cohere-red.desktop PRE-CREATION > stage/templates/odf/cohere-red.otp PRE-CREATION > stage/templates/odf/cohere-red.png PRE-CREATION > stage/templates/odf/curious_penguin.desktop 429e7c9 > stage/templates/odf/curious_penguin.png PRE-CREATION > qtquick/CQImageProvider.h PRE-CREATION > qtquick/CQImageProvider.cpp PRE-CREATION > qtquick/CQLinkArea.h PRE-CREATION > qtquick/CQLinkArea.cpp PRE-CREATION > qtquick/CQPluginLoaderProxy.h PRE-CREATION > qtquick/CQPluginLoaderProxy.cpp PRE-CREATION > qtquick/CQPresentationCanvas.h PRE-CREATION > qtquick/CQPresentationCanvas.cpp PRE-CREATION > qtquick/CQPresentationModel.h PRE-CREATION > qtquick/CQPresentationModel.cpp PRE-CREATION > qtquick/CQPresentationView.h PRE-CREATION > qtquick/CQPresentationView.cpp PRE-CREATION > qtquick/CQSpreadsheetCanvas.h PRE-CREATION > qtquick/CQSpreadsheetCanvas.cpp PRE-CREATION > qtquick/CQSpreadsheetListModel.h PRE-CREATION > qtquick/CQSpreadsheetListModel.cpp PRE-CREATION > qtquick/CQTextDocumentCanvas.h PRE-CREATION > qtquick/CQTextDocumentCanvas.cpp PRE-CREATION > qtquick/CQTextDocumentModel.h PRE-CREATION > CMakeLists.txt fa00fdd > CalligraProducts.cmake c2ef8ac > active/main.cpp 7e4c888 > active/qml/Test.qml PRE-CREATION > active/src/CASpreadsheetHandler.cpp e8cebff > active/src/CATextDocumentModel.cpp 4e72581 > active/src/MainWindow.cpp c378881 > cmake/modules/FindLibgit2.cmake PRE-CREATION > cmake/modules/FindLibqgit2.cmake PRE-CREATION > filters/words/docx/export/DocxFile.cpp d67e41f > filters/words/msword-odf/wv2/src/utilities.cpp 4be8c38 > krita/sketch/KisSketchView.cpp 5cb9172 > krita/sketch/SketchDeclarativeView.cpp e352fc9 > libs/flake/KoCanvasController.h 804a1e4 > libs/flake/KoCanvasController.cpp 5190f62 > libs/flake/KoToolManager.h ac17dd0 > libs/flake/KoToolManager.cpp 5d4da91 > libs/kopageapp/KoPADocumentModel.cpp 22bd75a > libs/kopageapp/tools/backgroundTool/KoPABackgroundToolFactory.cpp f442b84 > libs/main/KoApplication.cpp b20c0e9 > libs/main/KoDocument.h c3936a9 > libs/main/KoDocumentSectionDelegate.cpp 81c53c0 > libs/main/KoMainWindow.cpp 8db43f8 > libs/main/KoPart.cpp 04b8d25 > libs/main/KoTemplate.h f96099c > libs/main/KoTemplate.cpp f1d3bd9 > libs/main/KoTemplateCreateDia.cpp 72573cc > libs/main/KoTemplateGroup.cpp ab35dd1 > libs/main/KoTemplateTree.cpp 8f864b4 > libs/main/KoView.cpp 4770dcc > libs/main/gemini/ViewModeSwitchEvent.h PRE-CREATION > libs/odf/KoEncryptedStore.cpp 53c75b6 > libs/widgets/KoZoomAction.h c5f69b0 > plugins/defaultTools/defaulttool/SelectionDecorator.h 83e715e > plugins/defaultTools/defaulttool/SelectionDecorator.cpp 3e16cfa > qtquick/CMakeLists.txt PRE-CREATION > qtquick/CQCanvasBase.h PRE-CREATION > qtquick/CQCanvasBase.cpp PRE-CREATION > qtquick/CQCanvasController.h PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/120890/diff/ > > > Testing > ------- > > * Compiles and shipped to users on Windows (through the Calligra Gemini > packages) > * Used every day for writing in a production environment (for producing my > novel and recent short story) > > > Thanks, > > Dan Leinir Turthra Jensen > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
