Re: Review Request 120274: Add Qsort comparator (for Strings) which uses Collator.

2014-09-18 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120274/#review66867 --- Works great! Minor fixes needed. libs/db/CMakeLists.txt

Re: Review Request 119962: Add running desktop info to the feedback agent, automatize bug reporting

2014-09-18 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119962/ --- (Updated Sept. 18, 2014, 9:44 p.m.) Status -- This change has been m

Review Request 120274: Add Qsort comparator (for Strings) which uses Collator.

2014-09-18 Thread Michal Poteralski
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120274/ --- Review request for Calligra, Andrius da Costa Ribas, Oleg Kukharchuk, Adam

Re: Review Request 120250: Don't infinitely loop when backtracking keepWithNext with a page break

2014-09-18 Thread Pierre
On Thursday, September 18, 2014 07:48:41 PM Camilla Boemann wrote: > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120250/#review66864 > --

Re: Review Request 120250: Don't infinitely loop when backtracking keepWithNext with a page break

2014-09-18 Thread Pierre Ducroquet
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120250/ --- (Updated Sept. 18, 2014, 7:57 p.m.) Status -- This change has been m

Re: Review Request 120250: Don't infinitely loop when backtracking keepWithNext with a page break

2014-09-18 Thread Camilla Boemann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120250/#review66864 --- Ship it! Cool and a much simpler patch than I had feared - gr

Re: Review Request 120250: Don't infinitely loop when backtracking keepWithNext with a page break

2014-09-18 Thread Pierre Ducroquet
> On Sept. 18, 2014, 7:06 p.m., Camilla Boemann wrote: > > as far as I see it this code will always backtrack one block too much - can > > you please check > > > > But it correctly doesn't back track at all if all blocks have keep with next Thanks, the new diff fixes that, my bad. - Pierre

Re: Review Request 120272: Support the scrollwheel in KexiRecordNavigator

2014-09-18 Thread Friedrich W. H. Kossebau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120272/ --- (Updated Sept. 18, 2014, 7:40 nachm.) Review request for Calligra and Jar

Re: Review Request 120250: Don't infinitely loop when backtracking keepWithNext with a page break

2014-09-18 Thread Pierre Ducroquet
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120250/ --- (Updated Sept. 18, 2014, 7:41 p.m.) Review request for Calligra. Change

Review Request 120272: Support the scrollwheel in KexiRecordNavigator

2014-09-18 Thread Friedrich W. H. Kossebau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120272/ --- Review request for Calligra and Jarosław Staniek. Repository: calligra

Re: Review Request 120250: Don't infinitely loop when backtracking keepWithNext with a page break

2014-09-18 Thread Camilla Boemann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120250/#review66862 --- as far as I see it this code will always backtrack one block t

Re: Review Request 120084: Re-add support for "Configure Shortcuts" function

2014-09-18 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120084/#review66859 --- No chances to add it for 2.8.6 - not all shortcuts are saved p

Re: Review Request 120251: Smaller buttons for navigator, no longer left-aligned icons

2014-09-18 Thread Friedrich W. H. Kossebau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120251/ --- (Updated Sept. 18, 2014, 6:40 p.m.) Status -- This change has been m

Re: Review Request 120250: Don't infinitely loop when backtracking keepWithNext with a page break

2014-09-18 Thread Pierre Ducroquet
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120250/ --- (Updated Sept. 18, 2014, 6:01 p.m.) Review request for Calligra. Change

Re: Review Request 120250: Don't infinitely loop when backtracking keepWithNext with a page break

2014-09-18 Thread Pierre Ducroquet
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120250/ --- (Updated Sept. 18, 2014, 5:59 p.m.) Review request for Calligra. Change

Re: Review Request 119962: Add running desktop info to the feedback agent, automatize bug reporting

2014-09-18 Thread Adam Pigg
> On Sept. 18, 2014, 5:52 p.m., Adam Pigg wrote: > > Ship It! remember comments as discussed - Adam --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119962/#review66851 --

Re: Review Request 119962: Add running desktop info to the feedback agent, automatize bug reporting

2014-09-18 Thread Adam Pigg
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119962/#review66851 --- Ship it! Ship It! - Adam Pigg On Aug. 27, 2014, 11:51 p.m.

Re: Are we ready for 2.8.6?

2014-09-18 Thread Boudewijn Rempt
Nice, it'll be a birthday release for me :-) On Thu, 18 Sep 2014, Cyrille Berger wrote: On 2014-09-15 09:59, Jaroslaw Staniek wrote: Updated: https://community.kde.org/Calligra/Schedules/2.8/Release_Plan#2.8.6 Tagging September 20 Release September 24 @Cyrille, others, please confirm it st

Re: Review Request 120263: Add donations info to Kexi's status bar

2014-09-18 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120263/ --- (Updated Sept. 18, 2014, 7:04 p.m.) Review request for Calligra, Andrius

Re: Are we ready for 2.8.6?

2014-09-18 Thread Cyrille Berger
On 2014-09-15 09:59, Jaroslaw Staniek wrote: Updated: https://community.kde.org/Calligra/Schedules/2.8/Release_Plan#2.8.6 Tagging September 20 Release September 24 @Cyrille, others, please confirm it still fits your plans. I confirm. -- Cyrille Berger Skott _

Re: Review Request 120251: Smaller buttons for navigator, no longer left-aligned icons

2014-09-18 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120251/#review66816 --- Thanks, good catch. One thing though is the reason why the but

Review Request 120263: Add donations info to Kexi's status bar

2014-09-18 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120263/ --- Review request for Calligra, Andrius da Costa Ribas, Oleg Kukharchuk, Adam

Re: Review Request 120250: Change blockLayout return to be more explicit

2014-09-18 Thread Camilla Boemann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120250/#review66808 --- So in general I guess it's nice to have an enum as return, but