> On Sept. 18, 2014, 7:06 p.m., Camilla Boemann wrote: > > as far as I see it this code will always backtrack one block too much - can > > you please check > > > > But it correctly doesn't back track at all if all blocks have keep with next
Thanks, the new diff fixes that, my bad. - Pierre ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120250/#review66862 ----------------------------------------------------------- On Sept. 18, 2014, 7:41 p.m., Pierre Ducroquet wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120250/ > ----------------------------------------------------------- > > (Updated Sept. 18, 2014, 7:41 p.m.) > > > Review request for Calligra. > > > Bugs: 306000 > http://bugs.kde.org/show_bug.cgi?id=306000 > > > Repository: calligra > > > Description > ------- > > The backtrack code can infinitely loop when encounteering a page break in a > long keepWithNext block. > > With that patch, we still have a difference between us and LibreOffice 4.3 : > they decide to just skip the page break when it is in a keep with next block. > > > Diffs > ----- > > libs/textlayout/KoTextLayoutArea.cpp c74dbd4 > > Diff: https://git.reviewboard.kde.org/r/120250/diff/ > > > Testing > ------- > > Checked with the document from bug report 306000 : layouting the document now > works and does not end up in an infinite loop. > > > Thanks, > > Pierre Ducroquet > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
