----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120251/#review66816 -----------------------------------------------------------
Thanks, good catch. One thing though is the reason why the buttons are wide: we're trying to make them accessible with current DPIs. After your proposed change they shrink from 30 to 22 pixels with my default Oxygen style. Of course I agree on the icon placement fix, so what remains to be done is bringing the width back to reasonable value. If you don't have better idea, I recommend just adding this, what gives us our 30 pixels back: toolButton->setMinimumWidth(toolButton->sizeHint().width() + 2*3); - Jarosław Staniek On Sept. 17, 2014, 10:29 p.m., Friedrich W. H. Kossebau wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120251/ > ----------------------------------------------------------- > > (Updated Sept. 17, 2014, 10:29 p.m.) > > > Review request for Calligra and Jarosław Staniek. > > > Repository: calligra > > > Description > ------- > > The buttons in the navigator always looked strange to me, so wide and with > the buttons left aligned. > > Looking into the code I found this is due to the buttons being set to > Qt::ToolButtonTextBesideIcon by default, resulting in the icons left aligned > and with wider size(hint). > > Setting the style explicitely to Qt::ToolButtonIconOnly "fixes" this for me. > Unless this is wanted behaviour? > > > Diffs > ----- > > kexi/widget/utils/kexirecordnavigator.cpp bbe524b > > Diff: https://git.reviewboard.kde.org/r/120251/diff/ > > > Testing > ------- > > > File Attachments > ---------------- > > Buttons before > > https://git.reviewboard.kde.org/media/uploaded/files/2014/09/17/41f2157f-63c3-4db9-be92-f82392008ea0__ButtonsBefore.png > Buttons after > > https://git.reviewboard.kde.org/media/uploaded/files/2014/09/17/cd2f240f-bb32-48e5-b05a-83c6c055bf3f__ButtonsAfter.png > > > Thanks, > > Friedrich W. H. Kossebau > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
