Review Request 118067: cpp with jni (kexi)

2014-05-09 Thread harshita mistry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118067/ --- Review request for Calligra and Jarosław Staniek. Repository: calligra

Re: Review Request 118046: Fix crash introduced in reports after porting forms to Qt4

2014-05-09 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118046/ --- (Updated May 9, 2014, 11:25 p.m.) Status -- This change has been mar

Re: Review Request 118046: Fix crash introduced in reports after porting forms to Qt4

2014-05-09 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118046/#review57660 --- This review has been submitted with commit 1cff375660e7d42df3

Re: Review Request 116054: Remove some irritating warnings

2014-05-09 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116054/#review57659 --- This review has been submitted with commit b8efb56d95402bf00b

Re: Review Request 118056: Removing non-direct children of kexiwindow from to be deleted list

2014-05-09 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118056/#review57654 --- Please try to keep the Branch field filled - here it's calligr

Re: Review Request 118056: Removing non-direct children of kexiwindow from to be deleted list

2014-05-09 Thread Wojciech Kosowicz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118056/ --- (Updated May 9, 2014, 10:08 p.m.) Status -- This change has been mar

Re: Review Request 118056: Removing non-direct children of kexiwindow from to be deleted list

2014-05-09 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118056/#review57658 --- This review has been submitted with commit 6c8b194ff273f945f9

Re: Review Request 117803: Added toUpper for a word to be checked if is KexiSql keyword

2014-05-09 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117803/#review57657 --- This review has been submitted with commit 28ec311b2f9b4df069

Re: Review Request 117803: Added toUpper for a word to be checked if is KexiSql keyword

2014-05-09 Thread Wojciech Kosowicz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117803/ --- (Updated May 9, 2014, 10:04 p.m.) Review request for Calligra and Jarosła

Re: Review Request 117803: Added toUpper for a word to be checked if is KexiSql keyword

2014-05-09 Thread Wojciech Kosowicz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117803/ --- (Updated May 9, 2014, 10:04 p.m.) Status -- This change has been mar

Re: Review Request 117803: Update list of reserved keywords for sqlite in Kexi

2014-05-09 Thread Wojciech Kosowicz
> On May 9, 2014, 9:52 p.m., Jarosław Staniek wrote: > > It appears that this review should have title like "Added toUpper for a > > word to be checked if is KexiSql keyword" as it's bound to commit > > de07f92717012158b83ca0 to master. Please update to avoid confusion. > > > > Also you forgo

Re: Review Request 117803: Update list of reserved keywords for sqlite in Kexi

2014-05-09 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117803/#review57653 --- It appears that this review should have title like "Added toUp

Re: Review Request 117955: Updated list of kexiSql keywords (kexi)

2014-05-09 Thread Wojciech Kosowicz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117955/ --- (Updated May 9, 2014, 6:55 p.m.) Status -- This change has been mark

Re: Review Request 117953: Updated list of postgresql keywords from postgresql-9.3.4 (kexi)

2014-05-09 Thread Wojciech Kosowicz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117953/ --- (Updated May 9, 2014, 6:55 p.m.) Status -- This change has been mark

Re: Review Request 117956: Updated list of sqlite keywords from sqlite3080403 (kexi)

2014-05-09 Thread Wojciech Kosowicz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117956/ --- (Updated May 9, 2014, 6:56 p.m.) Status -- This change has been mark

Re: Review Request 117950: Updated list of mysql keywords from mysql-5.6.17 (kexi)

2014-05-09 Thread Wojciech Kosowicz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117950/ --- (Updated May 9, 2014, 6:55 p.m.) Status -- This change has been mark

Re: Review Request 118044: odb file reader(kexi)

2014-05-09 Thread Jaroslaw Staniek
Yes please. Great to see it! On Friday, 9 May 2014, Harshi Mistry wrote: > hello Jaroslaw, > > I have made a sample hello world program with jni. In this program, cpp program calls the java program. I am adding this to migration/odb. Should I submit a new patch for review? > > Harshita > > > On 8

Re: Review Request 118044: odb file reader(kexi)

2014-05-09 Thread Harshi Mistry
hello Jaroslaw, I have made a sample hello world program with jni. In this program, cpp program calls the java program. I am adding this to migration/odb. Should I submit a new patch for review? Harshita On 8 May 2014 13:12, harshita mistry wrote: >This is an automatically generated e-mai

Re: Review Request 117956: Updated list of sqlite keywords from sqlite3080403 (kexi)

2014-05-09 Thread Jaroslaw Staniek
Good question. Changes I requested in the script today do not affect these generated files so I propose to push them. On Friday, 9 May 2014, Wojciech Kosowicz wrote: > This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117956/ > > On May 9th, 2014, 2:16

Re: Review Request 118056: Removing non-direct children of kexiwindow from to be deleted list

2014-05-09 Thread Wojciech Kosowicz
> On May 9, 2014, 2:09 p.m., Jarosław Staniek wrote: > > Good find! Works for me. Please push both to calligra/2.8 and master with > > FIXED-IN:2.8.3 and BUG:334234 lines. > > > > PS: Why to add the patch as an attachment? Thanks :) I added attachment by mistake : ) - Wojciech ---

Re: Review Request 117956: Updated list of sqlite keywords from sqlite3080403 (kexi)

2014-05-09 Thread Wojciech Kosowicz
> On May 9, 2014, 2:16 p.m., Jarosław Staniek wrote: > > Good work! Please push both to calligra/2.8 and master. > > Wojciech Kosowicz wrote: > Thanks, before pushing I have a question regarding code formatting. I > noticed that in the previous edition there were used 4 spaces. Now there's

Re: Review Request 117966: Updated script for generating databases keywords in Kexi

2014-05-09 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117966/#review57641 --- Added explanation how to move choice of the filenames to the c

Re: Review Request 117956: Updated list of sqlite keywords from sqlite3080403 (kexi)

2014-05-09 Thread Wojciech Kosowicz
> On May 9, 2014, 2:16 p.m., Jarosław Staniek wrote: > > Good work! Please push both to calligra/2.8 and master. Thanks, before pushing I have a question regarding code formatting. I noticed that in the previous edition there were used 4 spaces. Now there's 2 tabs. I have not modified any part

Re: Review Request 117950: Updated list of mysql keywords from mysql-5.6.17 (kexi)

2014-05-09 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117950/#review57640 --- Ship it! Good work! Please push both to calligra/2.8 and mast

Re: Review Request 117953: Updated list of postgresql keywords from postgresql-9.3.4 (kexi)

2014-05-09 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117953/#review57639 --- Ship it! Good work! Please push both to calligra/2.8 and mast

Re: Review Request 117956: Updated list of sqlite keywords from sqlite3080403 (kexi)

2014-05-09 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117956/#review57638 --- Ship it! Good work! Please push both to calligra/2.8 and mast

Re: Review Request 117955: Updated list of kexiSql keywords (kexi)

2014-05-09 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117955/#review57637 --- Ship it! Good work! Please push both to calligra/2.8 and mast

Re: Review Request 118056: Removing non-direct children of kexiwindow from to be deleted list

2014-05-09 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118056/#review57636 --- Ship it! Good find! Works for me. Please push both to calligr