> On May 9, 2014, 2:16 p.m., Jarosław Staniek wrote: > > Good work! Please push both to calligra/2.8 and master.
Thanks, before pushing I have a question regarding code formatting. I noticed that in the previous edition there were used 4 spaces. Now there's 2 tabs. I have not modified any part of the script regarding coding style. Still I want to ensure that is okay to push the way it is. So, is it okay? - Wojciech ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117956/#review57638 ----------------------------------------------------------- On May 8, 2014, 1:04 p.m., Wojciech Kosowicz wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117956/ > ----------------------------------------------------------- > > (Updated May 8, 2014, 1:04 p.m.) > > > Review request for Calligra and Jarosław Staniek. > > > Repository: calligra > > > Description > ------- > > I downloaded sqlite3080403 sources and using script sql_keywords got a > generated list of specific sqlite keywords. There are new words in > consideration to the previous version. sql_keywords I had to modify as it > does not work in it current form (after finishing all changes for all the > three databases I will upload modified version to review). > > > Diffs > ----- > > libs/db/drivers/sqlite/sqlitekeywords.cpp 735f446 > > Diff: https://git.reviewboard.kde.org/r/117956/diff/ > > > Testing > ------- > > > Thanks, > > Wojciech Kosowicz > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
