-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118056/#review57658
-----------------------------------------------------------


This review has been submitted with commit 
6c8b194ff273f945f99fe014f170c9c6257f672a by Jaroslaw Staniek on behalf of 
Wojciech Kosowicz to branch calligra/2.8.

- Commit Hook


On May 8, 2014, 8:44 p.m., Wojciech Kosowicz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118056/
> -----------------------------------------------------------
> 
> (Updated May 8, 2014, 8:44 p.m.)
> 
> 
> Review request for Calligra and Jarosław Staniek.
> 
> 
> Bugs: 334234
>     http://bugs.kde.org/show_bug.cgi?id=334234
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> The findChildren method returned all the children even those non-direct When 
> deleting view it propagates from parent to children. Therefore situation 
> occured when view was first indirectly deleted and them directly. This checks 
> for the non-direct childs and deletes from the list
> 
> 
> Diffs
> -----
> 
>   kexi/core/KexiWindow.cpp bcb552a 
> 
> Diff: https://git.reviewboard.kde.org/r/118056/diff/
> 
> 
> Testing
> -------
> 
> Query designer should no longer crash
> 
> 
> File Attachments
> ----------------
> 
> 0001-Removing-non-direct-children-of-kexiwindow-from-to-b.patch
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/05/08/e32e0428-6e85-4898-a425-ba12a1e4c7fc__0001-Removing-non-direct-children-of-kexiwindow-from-to-b.patch
> 
> 
> Thanks,
> 
> Wojciech Kosowicz
> 
>

_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Reply via email to