Re: Review Request 108698: separate the rdf code into its own library

2013-02-02 Thread Thorsten Zachmann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108698/#review26563 --- Nice work. Looks good to me. krita/plugins/formats/qml/qml_e

Re: Review Request 108725: Fix for unsetting the canvas, new approach

2013-02-02 Thread Sven Langkamp
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108725/ --- (Updated Feb. 3, 2013, 4:35 a.m.) Review request for Calligra. Changes -

Re: Review Request 108708: fix possibly broken rect size calculation in Krita blur filters

2013-02-02 Thread Friedrich W. H. Kossebau
> On Feb. 2, 2013, 9:44 p.m., Boudewijn Rempt wrote: > > Yeah... If msvc warns about it, but I do think it's silly :-). Anyway, I > > still need to test, but I'm sure it's fine, it doesn't alter what we meant > > with the code. I was surprised as well, but really operator-() on an unsigned int

Re: Review Request 108709: in KisPlainColorSource equally distribute mix factor between values [0..255]

2013-02-02 Thread Friedrich W. H. Kossebau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108709/ --- (Updated Feb. 3, 2013, 1:12 a.m.) Review request for Calligra, Cyrille Ber

Re: Review Request 108726: Fix width of Words statistics docker after opening a document

2013-02-02 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108726/#review26559 --- Ship it! but awaiting the other patch as you point out yoursel

Review Request 108726: Fix width of Words statistics docker after opening a document

2013-02-02 Thread Sven Langkamp
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108726/ --- Review request for Calligra. Description --- Currently the statistics

Direct fundraising

2013-02-02 Thread Jaroslaw Staniek
Hi, It's clear we'd be able to extend certain activities with more resources. I am especially thinking about resources from someone who is for any reason not interested in KDE Workspaces but *is* in the office suite or calligra's associated software frameworks. I am aware how much the "I am not int

Re: Review Request 108677: Add support for hyperlinks in kexi buttons

2013-02-02 Thread Jarosław Staniek
> On Feb. 1, 2013, 11:36 p.m., Jarosław Staniek wrote: > > kexi/kexiutils/KexiPushButton.cpp, line 84 > > > > > > Shouldn't we add here: > > if (executable) { KRun::run(); } > > Oleg Kukharchuk wrote: >

Review Request 108725: Fix for unsetting the canvas, new approach

2013-02-02 Thread Sven Langkamp
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108725/ --- Review request for Calligra. Description --- The patch fixes the unse

Re: Review Request 108708: fix possibly broken rect size calculation in Krita blur filters

2013-02-02 Thread Boudewijn Rempt
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108708/#review26549 --- Ship it! Yeah... If msvc warns about it, but I do think it's s

Re: Review Request 108709: in KisPlainColorSource equally distribute mix factor between values [0..255]

2013-02-02 Thread Boudewijn Rempt
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108709/#review26548 --- It looks good to me... But it's not my code: Cyrille wrote this

Re: Review Request 108710: in KisGenericColorSpace unhide non-overriden method from KoColorSpace

2013-02-02 Thread Boudewijn Rempt
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108710/#review26547 --- Hm... This class was used in some places previously, like the t

Re: Review Request 108677: Add support for hyperlinks in kexi buttons

2013-02-02 Thread Oleg Kukharchuk
> On Feb. 1, 2013, 11:36 p.m., Jarosław Staniek wrote: > > kexi/kexiutils/KexiPushButton.cpp, line 84 > > > > > > Shouldn't we add here: > > if (executable) { KRun::run(); } You think KRun::runUrl(url, typ