----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108710/#review26547 -----------------------------------------------------------
Hm... This class was used in some places previously, like the tonemapping plugin. It's still used (sort of) in some code in the krita2-plugins repo, but those aren't being built at the moment, as far as I know. - Boudewijn Rempt On Feb. 2, 2013, 4:21 a.m., Friedrich W. H. Kossebau wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/108710/ > ----------------------------------------------------------- > > (Updated Feb. 2, 2013, 4:21 a.m.) > > > Review request for Calligra and Boudewijn Rempt. > > > Description > ------- > > The class KisGenericColorSpace has two methods which do not exactly match the > signatures of methods with the same name in the base-class KoColorSpace: > convertToQImage(...) and convertPixelsTo(...). Both miss the additional > parameter "KoColorConversionTransformation::ConversionFlags conversionFlags". > > So if that is on purpose, both overriden methods from KoColorSpace should be > added with "using" in the private or protected section of > KisGenericColorSpace, to unhide them and thus get rid of compiler warnings. > > But I wonder if KisGenericColorSpace is used at all: grepping for it only > showed KisGenericColorSpaceTest to use it. Perhaps time for removal of the > whole class then? Or is it for 3rd-party users of the Krita libs? > > > Diffs > ----- > > krita/image/kis_generic_colorspace.h 011477a > > Diff: http://git.reviewboard.kde.org/r/108710/diff/ > > > Testing > ------- > > > Thanks, > > Friedrich W. H. Kossebau > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
