Re: Review Request 108459: Refactor in KoText

2013-01-20 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108459/ --- (Updated Jan. 21, 2013, 5:34 a.m.) Review request for Calligra and Thorste

Re: Review Request 108478: fix for a broken algorithm type comparison in MsooXmlDiagramReader_p.cpp

2013-01-20 Thread Sebastian Sauer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108478/#review25877 --- Ship it! Ship It! - Sebastian Sauer On Jan. 18, 2013, 9:55

Re: Review Request 108509: Fix 313576: Use the doc of the correct part

2013-01-20 Thread Boudewijn Rempt
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108509/#review25867 --- Ship it! Looks good to me as well. About your question... I th

Re: Review Request 108510: split out _data() method for TestBlockLayout::testTabs()

2013-01-20 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108510/#review25866 --- This review has been submitted with commit 8cd663eb6974d934aad

Re: Review Request 108509: Fix 313576: Use the doc of the correct part

2013-01-20 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108509/#review25864 --- looks okay to me, boud? - C. Boemann On Jan. 20, 2013, 5:50

Re: Review Request 108510: split out _data() method for TestBlockLayout::testTabs()

2013-01-20 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108510/#review25863 --- Ship it! Ship It! - C. Boemann On Jan. 20, 2013, 5:50 p.m.,

Review Request 108510: split out _data() method for TestBlockLayout::testTabs()

2013-01-20 Thread Friedrich W. H. Kossebau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108510/ --- Review request for Calligra and C. Boemann. Description --- When inve

Review Request 108509: Fix 313576: Use the doc of the correct part

2013-01-20 Thread Gopalakrishna Bhat
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108509/ --- Review request for Calligra, C. Boemann and Boudewijn Rempt. Description -

Re: [calligra] /: Bring back RDF support)

2013-01-20 Thread Friedrich W. H. Kossebau
Hi Ben, Am Mittwoch, 27. Juni 2012, 05:59:30 schrieb Ben Martin: > Git commit 6e04b1605726a1b545da855a61481298efca2da0 by Ben Martin. > Committed on 27/06/2012 at 05:56. > Pushed by benm into branch 'master'. > > Bring back RDF support. I've moved some key classes to use intrusive > reference cou

Re: Review Request 108505: cleanup calligraactive.desktop

2013-01-20 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108505/#review25847 --- This review has been submitted with commit 4f8ab6a105101de792b

Re: Review Request 108505: cleanup calligraactive.desktop

2013-01-20 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108505/#review25845 --- This review has been submitted with commit dbeb7dbf98731d7c440

Re: Review Request 108505: cleanup calligraactive.desktop

2013-01-20 Thread Shantanu Tushar
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108505/#review25840 --- Ship it! Nice catch, thanks :) - Shantanu Tushar On Jan. 20

Re: Review Request 108491: Implement Undo command for Paragraph Settings

2013-01-20 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108491/#review25836 --- This review has been submitted with commit d4869442d2ec15da913

Review Request 108505: cleanup calligraactive.desktop

2013-01-20 Thread Friedrich W. H. Kossebau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108505/ --- Review request for Calligra and Shantanu Tushar. Description --- Two

Re: Review Request 108481: Temporarily swith to path tool to change shape parameters without double click to switch tool

2013-01-20 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108481/#review25829 --- I have some reservations against this. In general I think this

Re: Review Request 108459: Refactor in KoText

2013-01-20 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108459/ --- (Updated Jan. 20, 2013, 8:44 a.m.) Review request for Calligra and Thorste