Re: Review Request: Flow, Karbon, Stage and Sheets: use the currently set size units in the pagelayout dialog

2013-01-05 Thread Inge Wallin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108221/#review24787 --- Ship it! This can only be good. And the code looks ok. - Ing

Review Request: Flow, Karbon, Stage and Sheets: use the currently set size units in the pagelayout dialog

2013-01-05 Thread Friedrich W. H. Kossebau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108221/ --- Review request for Calligra. Description --- Words does it, but Flow,

Review Request: Readd formats menu (Select Masterpage, Edit Page layout) to Flow

2013-01-05 Thread Friedrich W. H. Kossebau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108220/ --- Review request for Calligra and Yue Liu. Description --- KoPAView::in

Re: Review Request: Add media support for epub3

2013-01-05 Thread Gopalakrishna Bhat
> On Jan. 5, 2013, 1:39 p.m., Inge Wallin wrote: > > Good start! Unfortunately I can't comment on the conversion itself since I > > don't know much about multimedia content in epub3 files. But there were a > > couple of question marks inside that I would like either a fix for or a > > comment

Re: Review Request: Add media support for epub3

2013-01-05 Thread Inge Wallin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108201/#review24784 --- Ship it! Looks good now. Good work! filters/words/epub/expo

Re: Review Request: Sync display text with edit text for KoProperty's {Date, DateTime, Time}Edit

2013-01-05 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107890/#review24783 --- This review has been submitted with commit 15bc47cf83b874f91a7

Re: Review Request: Pimp KoReport section editor dialogs

2013-01-05 Thread Friedrich W. H. Kossebau
> On Jan. 2, 2013, 10:16 p.m., Jarosław Staniek wrote: > > I compiled/checked your changes, thanks for attention to details. > > > > 1. How about using KDialogButtonBox instead of QDialogButtonBox? (it's > > available in Qt Designer too) > > > > 2. While we're moving to QFormLayout I propose t

Re: Review Request: Pimp KoReport section editor dialogs

2013-01-05 Thread Friedrich W. H. Kossebau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108096/ --- (Updated Jan. 6, 2013, 1:24 a.m.) Review request for Calligra, Jarosław St

Re: Review Request: Fix wrong style applied when backspace

2013-01-05 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108199/#review24768 --- Ship it! Though I do not think this patch is enough long term

Re: Review Request: Fix applying style to a caret without a selection

2013-01-05 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108191/#review24745 --- Ship it! yes it looks good - thank you - C. Boemann On Jan.

Re: Review Request: Add media support for epub3

2013-01-05 Thread mojtaba shahi
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108201/ --- (Updated Jan. 5, 2013, 2:38 p.m.) Review request for Calligra. Descripti

Re: Review Request: Add media support for epub3

2013-01-05 Thread mojtaba shahi
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108201/ --- (Updated Jan. 5, 2013, 2:37 p.m.) Review request for Calligra. Descripti

Re: Review Request: Add media support for epub3

2013-01-05 Thread mojtaba shahi
> On Jan. 5, 2013, 1:39 p.m., Inge Wallin wrote: > > filters/words/epub/OdtHtmlConverter.cpp, line 1053 > > > > > > Are you hard coding all media to audio here? That would exclude videos, > > wouldn't it? It is

Re: Annotations was: Merge branch 'master' into text-annotations-ingwa

2013-01-05 Thread Inge Wallin
On Friday, January 04, 2013 17:20:08 Gopalakrishna Bhat wrote: > On Wed, Jan 2, 2013 at 8:15 AM, Inge Wallin wrote: > > On Monday, December 31, 2012 10:44:45 Inge Wallin wrote: > > > Git commit c766b2149928783ae435ea8dba0ab36a43cbd593 by Inge Wallin. > > > Committed on 31/12/2012 at 10:43. > > > P

Re: Calligra Sprint 2013

2013-01-05 Thread Thorsten Zachmann
On Saturday 05 January 2013 12:50:59 jigar raisinghani wrote: > Hi, > It was a great idea to have a part of Calligra Sprint in India as it > saves a lot of money due to many Indians. But, as a part of the sprint, we > the first timers(at the sprint) were also looking forward to meet other > me

Re: Review Request: Add media support for epub3

2013-01-05 Thread Inge Wallin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108201/#review24738 --- Good start! Unfortunately I can't comment on the conversion it

Review Request: Add media support for epub3

2013-01-05 Thread mojtaba shahi
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108201/ --- Review request for Calligra. Description --- Add Media support for ep

Re: Calligra Sprint 2013

2013-01-05 Thread Nityam Vakil
Hi, I am myself a first timer (sprints) and it would be really great if I could meet my mentor and other members and work with them side by side. If it is possible the meet should be organized at one place. Thank you, On Sat, Jan 5, 2013 at 3:17 PM, Shantanu Tushar Jha wrote: > Hi Jigar, >

Review Request: Fix wrong style applied when backspace

2013-01-05 Thread Pierre Stirnweiss
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108199/ --- Review request for Calligra and C. Boemann. Description --- When usin

Re: Calligra Sprint 2013

2013-01-05 Thread Shantanu Tushar Jha
Hi Jigar, I understand your concern because there's just no match for actually meeting everyone at a single place. And, If I am not wrong, thats the general view of everyone in the Calligra community. But the final factors are in fact about what we can ask the eV to spare, because 6-7 is a conside